Commit Graph

24356 Commits

Author SHA1 Message Date
Iva Horn
7d932f8a48 fix(file-provider): Updated dependencies.
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
2025-10-17 09:49:16 +02:00
Nextcloud bot
042a943685
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-17 02:37:42 +00:00
Jyrki Gadinger
8ae74384ea
Merge pull request #8889 from nextcloud/feature/noid/xcode-target-is-release
chore: set xcode target to `Debug` only for dev builds
2025-10-16 18:38:47 +02:00
Jyrki Gadinger
7219c3bf20 chore: set xcode target to Debug only for dev builds
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-16 17:53:58 +02:00
Iva Horn
b3e705cbe1 feat(file-provider): Updated NextcloudFileProviderKit from 3.2.5 to 3.2.6
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
2025-10-16 14:11:32 +02:00
Jyrki Gadinger
700fcafe35
Merge pull request #8714 from nextcloud/bugfix/quotadir
fix(quota): return unlimited quota if server query is invalid or file is in folder root.
2025-10-16 10:09:23 +02:00
Jyrki Gadinger
cd8601e3be chore: change the extra quota logging to debug level
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-16 09:13:03 +02:00
Jyrki Gadinger
01526c34e5 fix(quota): parse quota values from servers as double
The server can respond with values like `2.58440798353E+12` instead of
a plain number like `2584407983530`.
`QVariant::toLongLong` does not recognise that as a valid number and
returns `0` instead, breaking the sync for some.

Also added a fallback value in case parsing the value as double doesn't
work either.

Fixes #8555

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-16 09:13:03 +02:00
Jyrki Gadinger
0d83bb2bf9 fix(discoveryphase): remove additional setting of folderQuota
`LsColJob::propertyMapToRemoteInfo` takes care of that too

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-16 09:13:03 +02:00
Jyrki Gadinger
51b5ed53ec fix(discovery): remove extra check for valid server entry
`processFileAnalyzeRemoteInfo` is only called iff `serverEntry.isValid`
anyway

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-16 09:13:03 +02:00
Camila Ayres
559e9c21aa chore: print sync information when checking quota.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-16 09:13:03 +02:00
Camila Ayres
5423d8383b fix(quota): return unlimited quota if server query is invalid or file is in folder root.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-16 09:13:03 +02:00
Nextcloud bot
54cb247c0d
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-16 02:36:39 +00:00
Jyrki Gadinger
979b6cf197
Merge pull request #8885 from nextcloud/bugfix/noid/macos-init-disappearing-cloudstorage-directory
fix(file-provider): report a different error if database is not ready
2025-10-15 17:45:53 +02:00
Jyrki Gadinger
ff43776cb7 fix(file-provider): report a different error if database is not ready
As per [the docs for `NSFileProviderReplicatedExtension
item(for:request:completionHandler:)`][1], the system will automatically
retry calling the method if the error is not one of `.notAuthenticated`,
`.serverUnreachable`, or `.noSuchItem`.

From my observations it seems that if the error `.cannotSynchronize` is
returned for the root container (i.e.
`NSFileProviderRootContainerItemIdentifier`), the system/file provider
framework just ends up deleting the newly created sync directory inside
`~/Library/CloudStorage`.  This broke the entry in the Finder sidebar.

After changing the error to `.notAuthenticated` (which is semantically
wrong, but alas), I now could disable/enable the File Provider as often
as I wanted without the Finder sidebar entry to ever break due to the
directory having been removed previously ...  Strange, this.

[1]: https://developer.apple.com/documentation/fileprovider/nsfileproviderreplicatedextension/item(for:request:completionhandler:)#Discussion

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-15 16:41:10 +02:00
Iva Horn
383a971aa0 fix(file-provider): Updated dependencies.
- NextcloudKit 7.1.6 → 7.1.7
- NextcloudFileProviderKit 3.2.4 → 3.2.5

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
2025-10-15 16:14:28 +02:00
Jyrki Gadinger
2566309a15
Merge pull request #8883 from nextcloud/bugfix/8740/macos-tooltips
fix(tray): use native tooltips when available
2025-10-15 13:58:11 +02:00
Jyrki Gadinger
86ceba756d fix(tray): use Item popupType on Windows
otherwise the text clips through the popup shape for some strange reason
...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-15 13:13:12 +02:00
Jyrki Gadinger
9a92dac5f5 fix(tray): use native tooltips when available
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-15 12:35:16 +02:00
Jyrki Gadinger
9b8c831696 chore: remove unused NCToolTip
Was removed with fb17a4bf9e

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-15 10:46:29 +02:00
Nextcloud bot
eb0b82b175
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-15 02:36:39 +00:00
Iva Horn
b46afb791c fix: Updated NextcloudFileProviderKit reference to 9d3a90e
9d3a90e516
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
2025-10-14 15:10:02 +02:00
Jyrki Gadinger
e68be46635
Merge pull request #8876 from nextcloud/bugfix/nextclouddev
fix(NextcloudDev): add missing template file.
2025-10-14 09:06:08 +02:00
Camila Ayres
1251cdb0a1 fix(NextcloudDev): add missing template file.
Adjust .gitignore to accept a file with 'build' in the name.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-10-14 08:30:08 +02:00
Nextcloud bot
955a47468a
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-14 02:51:54 +00:00
Jyrki Gadinger
32e66991ae
Merge pull request #8872 from nextcloud/fix/token-locks
Fix Token Locks
2025-10-13 10:55:25 +02:00
Iva Horn
272ca1dcf5 fix(file-provider): Updated NextcloudKit and NextcloudFileProviderKit dependencies.
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
2025-10-13 10:17:09 +02:00
Iva Horn
92f13d4be8 fix(file-provider): Updated logging calls in extension implementation.
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-10-13 10:17:09 +02:00
Nextcloud bot
57c5680d60
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-13 07:37:31 +00:00
Jyrki Gadinger
0cad5b1d61
Merge pull request #8870 from nextcloud/rakekniven-patch-1
fix(i18n): Fixed grammar
2025-10-13 09:16:19 +02:00
Jyrki Gadinger
224c9b1f12 fix(test): adapt updated error message strings
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-13 08:38:03 +02:00
rakekniven
335015fa2d
fix(i18n): Fixed grammar
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-10-13 08:08:40 +02:00
Nextcloud bot
4a0138e952
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-12 02:58:50 +00:00
Nextcloud bot
da0836f2e8
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-11 02:43:17 +00:00
Nextcloud bot
dc7e1295ab
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-10 03:05:55 +00:00
Matthieu Gallien
cca6805448
Merge pull request #8862 from nextcloud/bugfix/AllignPlusIcon
fix: Adding elide to menuitems
2025-10-09 12:23:07 +02:00
Tamás Bari
d354b329f4 fix: Adding elide to menuitems
Signed-off-by: Tamás Bari <adaorcpp@gmail.com>
2025-10-09 11:44:41 +02:00
Jyrki Gadinger
c0bd552d7e
Merge pull request #8863 from nextcloud/bugfix/noid/acl-error-logging
fix(filesystembase): log correct ACL errors
2025-10-09 11:44:12 +02:00
Jyrki Gadinger
506e2d9358 fix(filesystembase): log correct ACL errors
In #8860 I noticed that the "insufficient memory error" message is
logged if the last error was anything but `ERROR_INSUFFICIENT_BUFFER`

- fix comparison operator
- format Windows error codes with a hex code and message

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-10-09 10:39:26 +02:00
Nextcloud bot
031cda0e5c
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-10-09 07:05:57 +00:00
Rello
7b89dd1f9e
Merge pull request #8847 from nextcloud/copilot/fix-conflict-dialog-single-quote
fix: HTML-escape file URLs to handle special characters in conflict and case clash dialogs
2025-10-09 09:02:49 +07:00
copilot-swe-agent[bot]
a04811e2d1 fix: properly HTML-escape URLs to handle both single and double quotes
Use Utility::escape() to HTML-escape file URLs before embedding them in
anchor tags. This ensures both single quotes and double quotes (and other
HTML special characters) are properly handled.

The toHtmlEscaped() function converts:
- ' to &#39;
- " to &quot;
- & to &amp;
- < to &lt;
- > to &gt;

This fixes the issue where changing from single to double quote delimiters
would break with double quotes instead.

Signed-off-by: GitHub Copilot <copilot@github.com>

Co-authored-by: nilsding <1809170+nilsding@users.noreply.github.com>
2025-10-09 08:25:18 +07:00
copilot-swe-agent[bot]
4e12a82563 fix: handle single quotes in file paths for conflict and case clash dialogs
Changed HTML anchor attribute delimiters from single quotes to double quotes
in conflictdialog.cpp and caseclashfilenamedialog.cpp to properly handle
file paths containing single quote characters.

Fixes issue where clicking links for files with single quotes in their path
would fail due to malformed HTML.

Signed-off-by: GitHub Copilot <copilot@github.com>

Co-authored-by: Rello <13385119+Rello@users.noreply.github.com>
2025-10-09 08:25:18 +07:00
Rello
bd658a3626
Merge pull request #8851 from nextcloud/bugfix/AllignPlusIcon
Bugfix/allign plus icon
2025-10-09 08:24:32 +07:00
Tamás Bari
53a165f56d fix: Tweaking account dropdown menu style
Signed-off-by: Tamás Bari <adaorcpp@gmail.com>
2025-10-09 07:28:56 +07:00
Tamás Bari
c69d8edc90 fix: Removing non-existent properties
Signed-off-by: Tamás Bari <adaorcpp@gmail.com>
2025-10-09 07:28:56 +07:00
Rello
3adeb70af0 Refactor addAccountButton properties for icon sizing
Signed-off-by: Rello <Rello@users.noreply.github.com>
2025-10-09 07:28:56 +07:00
Matthieu Gallien
e839b25f67
Merge pull request #8849 from nextcloud/bugfix/addChunkUploadHeader
chore(chunk-upload): always sent the total size header
2025-10-08 20:27:07 +02:00
Matthieu Gallien
b533819f20 chore(chunk-upload): always sent the total size header
as documented here
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/WebDAV/chunking.html#uploading-chunks

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-10-08 19:48:51 +02:00
Matthieu Gallien
80d79e411a
Merge pull request #8848 from nextcloud/bugfix/noid/asyncimageresponse-use-qnam-thread
fix(asyncimageresponse): fetch remote resources in the same thread as `Account`
2025-10-08 17:43:16 +02:00