It is a transient dependency through NextcloudFileProviderKit anyway and was conflicting with that (besides still referring to claucambra).
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
The server can respond with values like `2.58440798353E+12` instead of
a plain number like `2584407983530`.
`QVariant::toLongLong` does not recognise that as a valid number and
returns `0` instead, breaking the sync for some.
Also added a fallback value in case parsing the value as double doesn't
work either.
Fixes#8555
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
As per [the docs for `NSFileProviderReplicatedExtension
item(for:request:completionHandler:)`][1], the system will automatically
retry calling the method if the error is not one of `.notAuthenticated`,
`.serverUnreachable`, or `.noSuchItem`.
From my observations it seems that if the error `.cannotSynchronize` is
returned for the root container (i.e.
`NSFileProviderRootContainerItemIdentifier`), the system/file provider
framework just ends up deleting the newly created sync directory inside
`~/Library/CloudStorage`. This broke the entry in the Finder sidebar.
After changing the error to `.notAuthenticated` (which is semantically
wrong, but alas), I now could disable/enable the File Provider as often
as I wanted without the Finder sidebar entry to ever break due to the
directory having been removed previously ... Strange, this.
[1]: https://developer.apple.com/documentation/fileprovider/nsfileproviderreplicatedextension/item(for:request:completionhandler:)#Discussion
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
In #8860 I noticed that the "insufficient memory error" message is
logged if the last error was anything but `ERROR_INSUFFICIENT_BUFFER`
- fix comparison operator
- format Windows error codes with a hex code and message
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Use Utility::escape() to HTML-escape file URLs before embedding them in
anchor tags. This ensures both single quotes and double quotes (and other
HTML special characters) are properly handled.
The toHtmlEscaped() function converts:
- ' to '
- " to "
- & to &
- < to <
- > to >
This fixes the issue where changing from single to double quote delimiters
would break with double quotes instead.
Signed-off-by: GitHub Copilot <copilot@github.com>
Co-authored-by: nilsding <1809170+nilsding@users.noreply.github.com>
Changed HTML anchor attribute delimiters from single quotes to double quotes
in conflictdialog.cpp and caseclashfilenamedialog.cpp to properly handle
file paths containing single quote characters.
Fixes issue where clicking links for files with single quotes in their path
would fail due to malformed HTML.
Signed-off-by: GitHub Copilot <copilot@github.com>
Co-authored-by: Rello <13385119+Rello@users.noreply.github.com>
