This commit addresses two issues within the 'updateMenuPermissions' method:
First, the target selection introduced in be7ad39 was suffering from the same problem as described in #3090 where selected tree items were not preferred for determining targets. This issue caused the chat bar to be erroneously disabled in certain situations, for example when connecting to a channel with "Text Message" permission disabled and switching to a different by left-clicking.
The second issue is an oversight in 441d06f where the 'Use selected item as the chat bar target' option was introduced. The permission check in 'updateMenuPermissions' was not updated to take the new option into account and therefore always used the selected target for the permission query independent of the state of the option.
The fix consists of using the unified 'getContextMenuTargets' for target selection and adding a special case for handling the enabled state of the chat bar by taking the new option into account.
Fixes#1799
This commit addresses two issues within the 'updateMenuPermissions'
method:
First, the target selection introduced in be7ad39fd was suffering
from the same problem as described in #3090 where selected tree items
were not preferred for determining targets. This issue caused the
chat bar to be erroneously disabled in certain situations, for example
when connecting to a channel with "Text Message" permission disabled
and switching to a different by left-clicking.
The second issue is an oversight in 441d06f6d where the 'Use selected
item as the chat bar target' option was introduced. The permission
check in 'updateMenuPermissions' was not updated to take the new
option into account and therefore always used the selected target
for the permission query independent of the state of the option.
The fix consists of using the unified 'getContextMenuTargets' for
target selection and adding a special case for handling the enabled
state of the chat bar by taking the new option into account.
Fixes#1799
We were still using a runner on Ubuntu 18.04, which is getting deprecated by GitHub in the near future. In order to avoid having failing CI jobs due to that and also in order to keep up with changes in Ubuntu, we now build on 20.04 and 22.04 instead.
This commit removes the additional gaps within the chat. The gaps were introduced by Qt's block-padding between frames. With this commit, the block after the last chat message is set to invisible.
The previous approach of a very small fontPoinzSize() within the blockCharFormat() unfortunately didn't work on Windows. This variant should work on both Windows and Linux.
Fixes#5886.
We were still using a runner on Ubuntu 18.04, which is getting
deprecated by GitHub in the near future. In order to avoid having
failing CI jobs due to that and also in order to keep up with changes in
Ubuntu, we now build on 20.04 and 22.04 instead.
This commit removes the additional gaps within the chat. The gaps were
introduced by Qt's block-padding between frames. This commits sets all
those blocks invisible: the leading block is hidden within `Log::Log`,
whereas all following blocks are hidden after their preceding frame
has been added within `Log::log`.
The previous approach of a very small `fontPoinzSize()` within the
`blockCharFormat()` unfortunately didn't work on Windows. This variant
should work on both Windows and Linux; unfortunately, I was only able
to test it on Windows.
Fixes#5886.
In ccbf407 the rememberchannelduration logic was improved. An explicit call to 'setTimeSpec(Qt::UTC)' was removed, because it was assumed that 'secsTo' would already be sufficient as it converts both inputs to UTC automatically. Due to an oversight this lead to a regression.
The reason setTimeSpec is actually needed is because the DB already contains UTC values. The setTimeSpec call tells Qt that the loaded values are actually already UTC and do not have to be converted. Without the call to setTimeSpec, the DB values are effectively converted twice, which gives rememberchannelduration an offset based on the server local time.
The commit 902fe58 introduced links in the log for users and channels. This either never worked correctly, or regressed due to an undocumented behavior change in Qt. The 'channelid' stored in the host part of a QUrl is automatically converted to an IP address (e.g. '1' -> '0.0.0.1') which lets the channel lookup fail. A different code path for clients was present, so the issue was not observed often (or at all) there.
This commit changes the host part composition to contain a string (e.g. '1' > 'id.1') and makes sure this new string is parsed correctly.
Fixes#2961
The commit 902fe5841c introduced links in the log for users
and channels. This either never worked correctly, or regressed due
to an undocumented behavior change in Qt. The 'channelid' stored in
the host part of a QUrl is automatically converted to an IP address
(e.g. '1' -> '0.0.0.1') which lets the channel lookup fail.
A different code path for clients was present, so the issue was not
observed often (or at all) there.
This commit changes the host part composition to contain a string
(e.g. '1' -> 'id.1') and makes sure this new string is parsed correctly.
Fixes#2961
In ccbf4072c the rememberchannelduration logic was improved. An explicit
call to 'setTimeSpec(Qt::UTC)' was removed, because it was assumed that
'secsTo' would already be sufficient as it converts both inputs to UTC
automatically. Due to an oversight this lead to a regression.
The reason setTimeSpec is acutally needed is because the DB already
contains UTC values. The setTimeSpec call tells Qt that the loaded
values are actually already UTC and do not have to be converted.
Without the call to setTimeSpec, the DB values are effectively
converted twice, which gives rememberchannelduration an offset
based on the server local time.
As it was, the sent UserState message would have only contained the user's session ID, which in and of itself is absolutely useless. Thus, it is better to not send a UserState message in this case.
As it was, the sent UserState message would have only contained the
user's session ID, which in and of itself is absolutely useless.
Thus, it is better to not send a UserState message in this case.
This commit extends the quit behavior setting from being a binary toggle
between ask or don't ask, when quitting while connected to a server, to
give the user the options for Mumble to ask, minimize or quit straight
away, either always or only while connected to a server.
Fixes#5282
This commit extends the quit behavior setting from being a binary toggle
between ask or don't ask, when quitting while connected to a server, to
give the user the options for Mumble to ask, minimize or quit straight
away, either always or only while connected to a server.
Fixes#5282
If the systemd module was not installed (or could not be located by
pkg-config for other reasons), a big chunk of text would be emitted to
stdout stating that no such module could be found and how one might
resolve this issue. However, we don't want to throw this at our users as
we have backup code paths implemented for the case in which pkg-config
can't query the necessary information.
This commit makes sure that these warnings are not emitted anymore.
For registered users, the server will now remember their channel
listeners (and their volume adjustments) and will restore them once the
user rejoins this server.
For registered users, the server will now remember their channel
listeners (and their volume adjustments) and will restore them once the
user rejoins this server.
This commit introduces an automatic approach that will publish the
Windows installers to the WinGet repository every time a release is
created on GitHub.
Fixes#5870
This prevents adding all targets in said subdirectories to the ALL
target by default. Instead, only those targets that are explicitly
referenced (e.g. via target_link_libraries) are built.
This also has the side-effect that any install-directives in these
subdirectories are also ignored for the default install targets which
prevents these libraries of unconditionally installing themselves when
issuing a make install. Instead, we now have to make any 3rdparty
component that we do indeed want to install, do so explicitly (e.g. via
install_library()).
The logrotate script is not intended to be used on systems with systemd
support. However, we don't want to take on the burden of having to keep
around and maintain config files for non-systemd systems.
Previously we would define our install paths as relative paths when
using the packaging option and turning them into absolute paths
otherwise.
While relative paths are required for CPack to work properly, we use
the paths e.g. for passing them in via macros and there we absolutely
require the full, absolute paths to be passed.
Thus, this commit removed the discrepancy of the results when built with
packagin=ON vs packagin=OFF and now always defines the install paths as
relative paths. However, we now keep an additional set of paths around
that are now always absolute.
The auxiliary files will now make use of configure_file in order to
ensure that e.g. the binary names used in them always match the names of
the actually built binaries.
Previously the server was only looking for files named e.g. murmur.ini
or murmur.sqlite. With this commit, the server will now look first for
files called mumble_server.ini and mumble_server.sqlite before falling
back to the old names (for backwards compatibility).
This is meant as a means to drive forward the server renaming from
murmur(d) to mumble-server.
