Commit Graph

25236 Commits

Author SHA1 Message Date
jim-p
f4bbd64dec Encoding in diag_packet_capture.php 2015-06-16 11:30:16 -04:00
jim-p
9162143f12 Encoding in interfaces_qinq_edit.php 2015-06-16 11:27:06 -04:00
jim-p
e959a567e5 Encoding in services_dnsmasq.php 2015-06-16 11:18:42 -04:00
jim-p
7a29e65427 Encoding in vpn_ipsec_settings.php 2015-06-16 11:10:58 -04:00
jim-p
5ef9708e4d More encoding 2015-06-16 11:05:47 -04:00
jim-p
d213c48520 Fix some low-hanging potential security issues. 2015-06-16 10:53:04 -04:00
jim-p
621baeb604 Be more careful with encoding on pages that use single quotes around HTML attributes 2015-06-16 10:13:09 -04:00
jim-p
6dbe58e101 Additional encoding for system_advanced_misc.php 2015-06-16 09:24:11 -04:00
jim-p
1a44770de9 Protect single quotes as well to prevent JS injection, due to the way this page uses single quotes for attributes. 2015-06-16 09:11:47 -04:00
jim-p
2a1b44c96e Encode parameters in system_advanced_firewall.php before displaying back to the user. 2015-06-16 08:56:05 -04:00
Renato Botelho
0e40454d52 Keep a copy of old mtree binary during upgrade and use it to avoid crashing. Fixes #4563 2015-06-16 07:34:13 -05:00
Renato Botelho
0ab90dd074 Check also for old FreeBSD release versions 2015-06-16 07:34:13 -05:00
Ermal LUÇI
6d85358c94 Merge manullay pull/1722 2015-06-15 18:18:41 +02:00
Ermal LUÇI
4d474c094f Remove the GUI for the pc-sysinstaller as well and add it to obsoletee files 2015-06-15 16:50:16 +02:00
Ermal LUÇI
353cd8165e Remove pc-sysinstall since it was never finished and probably will be not the choice. If needed can be resurrected. It already is in obsoleted files 2015-06-15 16:48:16 +02:00
Phil Davis
6622518b15 status_queues missing semi-colon
This really looks like it should have a semi-colon. Somehow the PHP interpreter is not being fussy about it in this context, I guess being followed by the "endif;" keyword the interpreter guesses the previous statement must be done.
2015-06-15 09:34:07 -05:00
Ermal LUÇI
da6faa2b57 Ticket #4655 well manually merge pull/1715. Thanks: Phil 2015-06-15 02:58:24 +02:00
Chris Buechler
fd90a77fdf add input validation for proxy URL, port, user. 2015-06-14 00:48:55 -05:00
Ermal LUÇI
d6084ab02f Ok another round of this which unbreaks input error validation messages 2015-06-13 14:35:43 +02:00
Ermal LUÇI
60fc27e0aa Make this right finally :). Thanks-ti: Phil-davis 2015-06-12 20:35:05 +02:00
Ermal LUÇI
4b03b90609 Add hostid script in the source to solve the issue with platforms that do not have proper uuid or duplicate uuid which breaks carp/pfsync and other things in HA setup. 2015-06-12 18:11:58 +02:00
Ermal LUÇI
7144515b87 Activate the redirection that for some reason got disabled 2015-06-12 17:36:34 +02:00
Ermal LUÇI
1c7fd09e4d Ticket #4655 Do not behave against the logic of checkbox and description. 2015-06-11 23:56:55 +02:00
bruno
be37ac8f19 fix checking for overlaps of NAT destination port 2015-06-11 15:18:26 -04:00
Ermal LUÇI
2e7ea1074a Make the host uuid opt-out 2015-06-11 03:46:48 +02:00
Chris Buechler
894d01b6f4 Revert "Ticket #4442 Do not process URL aliases during bootup but trigger it just after finished booting. This completely solves the bootup delays without lowering the timeout as before. Probably need to increase a bit the timeouts now to be friendly to other connections"
This reverts commit 0d44aca646.
2015-06-10 20:14:28 -04:00
Ermal LUÇI
9c189bee28 Send the machine uuid with the headers requesting the version file 2015-06-10 20:11:39 +02:00
Ermal LUÇI
fb36bccf12 Send the host uuid with the request for package 2015-06-10 20:02:42 +02:00
Ermal LUÇI
8b8a463054 Fixes #4537 On 32bit platform do not enable direct dispatch on IPsec since it crashes the system 2015-06-10 19:44:54 +02:00
jim-p
ed97bf788e Activate sync for the root slice in fstab during upgrade. Ticket #4523 2015-06-10 12:49:28 -04:00
Ermal LUÇI
2895e60696 No need to do the same exercise twice. 2015-06-09 02:37:02 +02:00
Ermal LUÇI
8da92d29ab Do not disable APc here 2015-06-09 02:31:45 +02:00
Ermal LUÇI
3ab88f32be Restore the file system in R/W mode during most of rc script seems required on nano. Should unbreak nanobsd 2015-06-09 02:30:50 +02:00
Ermal LUÇI
ad1e7a8cd9 Add a space to the script to avoid that appended parameters seem the same as existing one 2015-06-09 01:36:06 +02:00
jim-p
3386101487 Use skel as the source of new user files rather than copying from root.
Reported-By: https://twitter.com/fitchitis/status/607850849172373504
2015-06-08 08:24:59 -04:00
Ermal LUÇI
0d44aca646 Ticket #4442 Do not process URL aliases during bootup but trigger it just after finished booting. This completely solves the bootup delays without lowering the timeout as before. Probably need to increase a bit the timeouts now to be friendly to other connections 2015-06-07 23:35:20 +02:00
Ermal LUÇI
8c9216d5f2 Fixes #4651 use proper var name on global to have the correct id put on the rule 2015-06-07 20:53:50 +02:00
Renato Botelho
7a923e09da Re-generate broken .mo files, it fixes #4705 2015-06-07 13:40:00 -05:00
Renato Botelho
422fabbcdf Remove duplicate message 2015-06-07 13:39:42 -05:00
jim-p
0e7653f480 Clean up, organize, and expand the info presented by status.php. Save the output to individual text files and compress them into a .tgz for later download. 2015-06-05 16:33:49 -04:00
jim-p
a0be396eb1 Fix CARP plugin call for packages, interface was coming through as NULL during CARP events. 2015-06-05 11:55:41 -04:00
jim-p
b4aac247ac Add INIT event for CARP as an alternate for 'backup', otherwise scripts would not take down services during a MASTER->INIT transition. 2015-06-05 11:55:09 -04:00
jim-p
1557716b7c Also sanitize OpenVPN static/tls keys in status.php 2015-06-05 08:22:06 -04:00
Phil Davis
dc6695c3f4 Setup Wizard can result in invalid LAN DHCP pool calculation
1) consider where the LAN IP is in the subnet range and then put the
DHCP pool in the biggest remaining segment, either above or below.
2) Check the size of the available segment. If it is reasonably big then
leave some space at either end of the segment, like the old code was
doing. Otherwise give all the space to the pool.
3) Do not allow subnet mask 32 - I can't think of a use case for LAN to
have a /32 subnet mask, it kind of breaks the whole concept of LAN.
4) Provide more detailed separate messages if the user tries to use the
network address or broadcast address as the LAN IP.
2015-06-04 17:08:11 -03:00
Phil Davis
b3bba7fe13 Improve setup wizard host name check
Redmine #4712
It seems good enough to make the regex strings here be "reasonable". The full checks are done after pressing Next and the correct routines are called that do an exhaustive check. There seems not much point in trying to re-engineer all that here also.
Odd things like "-hostname" and "hostname-" would be allowed through here but are caught by the full validation check.
"." and "|" were being allowed in this regex - no idea why!
2015-06-04 17:06:31 -03:00
Chris Buechler
eefd77734b A number of things block waiting for file download timeouts, sometimes multiple times across multiple files (many URL Table aliases, for instance). The long timeout causes very long boot times (10-20+ minutes) on many configs with pfblocker if booted disconnected from the Internet. This is strictly the timeout for the HTTP/HTTPS connection attempt. Once connected, it can run past that. 5 seconds should be more than enough for any properly-functioning network. Part of Ticket #4442. 2015-06-03 00:57:24 -05:00
Chris Buechler
7112bcc8ea device_type isn't used here 2015-06-02 23:36:56 -05:00
Chris Buechler
dbd919ecd5 Don't call growl if the configured address isn't an IP or resolvable
hostname. Avoids 1 minute timeout delay in fsockopen in growl.class. Cuts
that down to about a 20 second timeout. Ticket #4739
2015-06-02 19:30:38 -05:00
Chris Buechler
f135a01087 trigger a reboot after restoration of full backup. Ticket #4107 2015-06-02 11:56:21 -05:00
Renato Botelho
8c288bce6d Deprecate /usr/local/bin/3gstat 2015-06-02 10:12:34 -03:00