Commit Graph

24519 Commits

Author SHA1 Message Date
Chris Buechler
effb3a3cfe Can't skip this if booting, ends up breaking config. Ticket #4071 2014-12-03 20:43:03 -06:00
Chris Buechler
e78509cc09 fix IPv6 static routes, is_ipaddrv6 returns true for strings including a
CIDR mask, which then ended up broken.
2014-12-03 12:42:05 -06:00
Chris Buechler
3064001823 Change our default resolv-retry back to OpenVPN's default. Changing this
didn't help the ticket where it was intended to help, which was later
fixed differently. This change in defaults is problematic in a lot of
scenarios, go back to the way things were before. Ticket #3894
2014-12-03 11:05:16 -06:00
Renato Botelho
576af57027 Merge pull request #1359 from phil-davis/patch-1 2014-12-03 10:57:48 -02:00
Phil Davis
efa2869209 Display installed pkg version even if pkg server not available
Forum: https://forum.pfsense.org/index.php?topic=84820.0
It seems reasonable to me to display the currently installed package version numbers, along with text like "Latest: N/A". and the Version box being red-filled when someone goes to System->Packages and displays the installed packages but the package server is not reachable for some reason.
This code does it.
What do you think?
2014-12-03 17:27:58 +05:45
Chris Buechler
a94b1edc7f Merge pull request #1348 from phil-davis/patch-4 2014-12-02 21:35:54 -06:00
Chris Buechler
c042bc3b10 Merge pull request #1357 from DasTestament/patch-1 2014-12-02 21:28:32 -06:00
Chris Buechler
d12e3d3c46 reload Unbound here, fixes some instances of PD-assigned v6 IPs missing from unbound.conf 2014-12-02 20:50:19 -06:00
Chris Buechler
a0e9e17d2d If get_interface_ip(v6) is passed an IP, return the IP.
Properly set up interface binding for v6 link local IPs. Ticket #4021

except had to comment out the fix for now because of #4062 to avoid config breakage.
2014-12-02 20:15:04 -06:00
jim-p
0b0d83cbf0 Use clog -f /var/log/filter.log to view firewall log entries, so they are displayed in the new format. 2014-12-02 12:46:14 -05:00
Chris Buechler
690b557cbf wait 10 minutes before retrying on soft failures to avoid us getting DoSed
if something is wrong there (like someone's system can't validate the
cert)
2014-12-02 11:14:03 -06:00
Chris Buechler
a82b458fcc don't include cert.pem in the obsoletedfiles list. 2014-12-02 11:08:08 -06:00
Ermal LUÇI
3377dc9da6 Preserve exit code lost from s/exit/return/ 2014-12-02 12:59:54 +01:00
Ermal LUÇI
110967a4ba Try to not make useless entries in the config file for very rare used configuration values. Makes config file readble and with less size 2014-12-02 12:35:36 +01:00
Ermal LUÇI
7f06001481 Cleanup whitespace. 2014-12-02 12:24:28 +01:00
Ermal LUÇI
52550ca5e3 Remove exit from as much as possible backend code 2014-12-02 12:01:15 +01:00
Ermal LUÇI
9ea554ee5c Remove exit from as much as possible backend code 2014-12-02 11:33:21 +01:00
Ermal LUÇI
8ad1ee636a Remove exit and also properly close open files 2014-12-02 11:28:37 +01:00
Ermal LUÇI
2eb3efc20a Lock rc.linkup based on interface to avoid races in between up/down events which might create a loop. This is more a timing issue but better enforce serialization here. check_reload_status forces this but not between start and stop but just between similar events. Probably need to bring more inteligence there. 2014-12-02 11:24:47 +01:00
Ermal LUÇI
6a1ed2cd20 Avoid calling exit in backend now that fpm is used for php since its a pesimization and can break calling scripts assumption on locks. 2014-12-02 11:18:39 +01:00
Ermal LUÇI
1ff8e8f65a Comment out copy paste of v4 code. No need to delete arp entries on v6. 2014-12-02 11:07:22 +01:00
Ermal LUÇI
f74c9aba39 Comment out copy paste of v4 code. No need to delete arp entries on v6. 2014-12-02 11:06:18 +01:00
Chris Buechler
9eabb24865 also take into account the "all" option in Unbound Network Interfaces when
setting 127.0.0.1 into resolv.conf.
2014-12-01 16:54:47 -06:00
Renato Botelho
be5b413308 Revert "/etc/ssl/cert.pem was obsoleted by mistake, remove it"
Since /usr/local/ssl/cert.pem is in place now, it can be obsoleted

This reverts commit bb788b8ceb.
2014-12-01 09:18:05 -02:00
Renato Botelho
bb788b8ceb /etc/ssl/cert.pem was obsoleted by mistake, remove it 2014-12-01 09:17:03 -02:00
Dmitriy K.
4dd7ca8041 Update filter.inc
Add missing gettext.

p.s: Is it really needed to log? Lots of rules causes lots of spam on ifaces without gw. Such kind of this logging should be controllable by user via option at least.
2014-12-01 14:06:28 +03:00
Ermal LUÇI
7ceff68a58 Unlink temporary xml file to avoid filling up space with junk files 2014-12-01 10:02:55 +01:00
Chris Buechler
e3afacbb41 Only set i_dont_care_about_security_and_use_aggressive_mode_psk=yes where there is a P1 with aggressive+PSK enabled. Log a warning when such a configuration is in use. 2014-11-29 13:43:33 -06:00
Renato Botelho
cc62e5eda0 Merge pull request #1356 from phil-davis/patch-3 2014-11-29 10:27:45 -02:00
Phil Davis
9c97e4b88c Correctly delete xml file after restore and conversion to rrd
When doing "Generating RRD graphs" at bootup, the data is restored from /cf/conf/rrd.tgz into xml format files in /var/db/rrd. Those xml files are then convert to rrd files. After that, the xml files should be deleted - but the xml file path was not quite right, so they were not being deleted.
This fixes it.
2014-11-29 18:05:46 +05:45
Renato Botelho
345145e20b Merge pull request #1355 from phil-davis/patch-2 2014-11-29 10:10:45 -02:00
Phil Davis
8c2a5a738b Fix bracketing of if statement in unbound
Stops message:
Warning: in_array() expects parameter 2 to be array, null given in /etc/inc/unbound.inc on line 607
The problem was introduced when lines 607-608 were added without adding these brackets.
IMHO programming standards should include ALWAYS using brackets for "if" and other similar statements. That way this sort of code addition accident does not happen. But I guess there are others who have different opinions.
2014-11-29 17:30:39 +05:45
Chris Buechler
978b8f508b fix syntax on prefix6 for DHCPv6 PD 2014-11-28 22:58:17 -06:00
Chris Buechler
c5cd9b7503 validate MTU and MSS as integers, and don't allow MSS larger than pf will accept to avoid broken rulesets. 2014-11-28 19:33:30 -06:00
Chris Buechler
a96dc32e35 Add input validation on vpn_ipsec_settings.php. Fixes #4052. 2014-11-28 19:17:18 -06:00
Chris Buechler
5a663a5d56 Skip v6 WANs in Unbound access-control. Ticket #4023 2014-11-28 17:30:16 -06:00
Chris Buechler
80075b9e87 fix v6 access-control in Unbound, Ticket #4023 2014-11-28 16:30:49 -06:00
Ermal LUÇI
719db60e4b Ticket #4009 Force serial console whenever the installer told us so. 2014-11-28 23:26:34 +01:00
Chris Buechler
f4620b36fd check if Unbound is enabled in addition to dnsmasq for v6 DNS assignment. Fixes #4051 2014-11-28 16:09:10 -06:00
Chris Buechler
b7960673be Fix input validation for DNS resolver when localhost is enabled in resolv.conf and "all" chosen in Network Interfaces. While here, set something other than '' when all is chosen. 2014-11-28 15:54:58 -06:00
Ermal
2388a1ace9 Merge pull request #1354 from phil-davis/patch-2 2014-11-28 21:47:30 +00:00
Ermal LUÇI
7b9dfd6b32 Correct some logic and remove temporary files 2014-11-28 21:53:35 +01:00
Ermal LUÇI
7966b0dff9 Make restore one by one to help https://forum.pfsense.org/index.php?topic=84693.0 2014-11-28 21:50:48 +01:00
Phil Davis
8676899f08 Process RRD backup compression in var
Prior to this the RRD xml files were added uncompressed to the archive in /cf/conf and then that archive was compressed at the end.
My /cf partition is only 50MB. The uncompressed archive of all the xml files is already 35MB. With a few config backups, or a few more VLANs (xml files) I will soon run into the 50MB limit.
This change creates each xml from rrd one at a time, then compresses that 1 xml into a tgz in /var/db/rrd, deletes the xml then loops to the next rrd file.
At the end of the loop, there are a bunch of /var/db/rrd/*.tgz files, which are small (they take up <2MB on my system, from XMLs that total 35MB). They are then unpacked and put into 1 /cf/conf/rrd.tgz in a single command.
Thus there is no time when 35MB of xml content has to be stored anywhere.
This should work for systems with a lot of RRD files that turn into XML and then TGZ one at a time.
2014-11-28 23:24:10 +05:45
Ermal LUÇI
c1819b4870 Process the rrd files one by one to fix https://forum.pfsense.org/index.php?topic=84693.0. Restore will come after 2014-11-28 17:05:09 +01:00
Ermal LUÇI
fea0b65224 Correct typo on variable. Should help https://forum.pfsense.org/index.php?topic=84451.0 2014-11-28 16:48:36 +01:00
Renato Botelho
16d6c1df8c Add a parameter on platform_booting to help detect if it's on GUI on console and use it in appropriate places, it fixes #4049 2014-11-28 12:43:51 -02:00
Renato Botelho
5acce70485 Fix sapi name check to detect if it's on console, ticket #4049 2014-11-28 12:15:04 -02:00
Ermal LUÇI
e48a7cf4b1 Remove the . here they just confuse things as in Ticket #4049. Also check that the script is called from console to trigger the convertion and mounting of floppy. 2014-11-28 13:11:12 +01:00
Ermal LUÇI
d8648df4ed Remove these booting settings since are useless 2014-11-28 13:05:18 +01:00