* 'Status_-_System_Logs_-_Consolidation' of https://github.com/NOYB/pfsense:
Redmine #5731 Error when setting various system log settings from factory default config
HTML Compliance - Status - System Logs - Firewall Summary View
Fixup AJAX stuff so dynamic updating works.
Rename functions per Phil suggestions.
Remove commented out test code.
Can' t do that here. Remove space between php tags.
Status - System Logs - Consolidate - Firewall Summary View
Status - System Logs - Consolidate - Firewall Dynamic View
Status - System Logs - Consolidate - Common Functions
The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.
The <a> name attribute is not supported in HTML5. Use the id attribute instead.
s/miscellaneous_common_code/status_logs_common_code/
s/build_if_list/status_logs_build_if_list/
As for getGETPOSTsettingvalue I'm open to it going anywhere that makes sense. Would be nice not to need too many additional inc's to get it though. Anything in guiconfig.inc or filter_logs.inc hierarchy shouldn't require anything additional.
Add advanced filtering to firewall dynamic view.
Add manage log to dynamic view.
Update dynamic view view log selection method to same method as firewall and system logs.
Factor common code section into to functions and place in include file.
getGETPOSTsettingvalue
miscellaneous_common_code
tab_array_logs_common
log_filter_form_system_submit
filter_form_system
log_filter_form_firewall_submit
filter_form_firewall
build_if_list
manage_log_code
manage_log_section
The code that provides the data for this is already in
bandwidth_by_ip.php in both 2.2.* and master 2.3.
The description option is in the Display dropdown list in 2.2.*, but it
got missed in the bootstrap conversion and integration process.
With just this 1-line addition the Display Description option can be
selected and works.