At this point $iface is an undefined var. So the last test of this "if" statement is useless.
That code fragment was introduced in commit e4d40f41aa
I think that code fragment came from a similar thing that is inside a "foreach $iface" loop in interfaces_pps_edit.php
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_ppps_edit.php#L300
and was pasted into the condition here back in 2011 without being changed.
What I have done to the test here seems what would have been intended. Any better ideas are welcome.
1) The var $iface is not set at lines 2457 or 2464. It is a var that was used higher up local to build_ipv6interface_list() - it is not relevant to the single fields track6-prefix-id--hex and track6-prefix-id-max
2) When the user selects a different track6-interface then trigger update_track6_prefix() which will update the help text track6-prefix-id-range.
Related to forum https://forum.pfsense.org/index.php?topic=107962.msg601309#msg601309
This pull request does not directly address the reported issue of the track6-prefix-id not "taking". It just fixes up some code issues that I noticed.
Error: Duplicate attribute class.
<div class=alert alert-warning class=hidden id=no_cookies>Your browser must support cookies to login.</div>
Consolidate multiple class attributes.
Error: Attribute autocorrect not allowed on element input at this point.
<input type=text class=form-control name=usernamefld id=usernamefld placeholder=Enter your username autocorrect=off autocapitalize=none spellcheck=false>
Non standard IOs Safari, Android Chrome attribute.
Error: Attribute autocapitalize not allowed on element input at this point.
<input type=text class=form-control name=usernamefld id=usernamefld placeholder=Enter your username autocorrect=off autocapitalize=none spellcheck=false>
Non standard IOs Safari, Android Chrome attribute.
Stops widgets from "going missing" when the user reduces the dashboard columns in System, General Setup.
If the user just lowers dashboard columns to see what happens, then increases it again, the actual column settings are preserved in the config, so the widgets go back where they were. That seems a good thing.
If the user lowers dashboard columns and then also saves the dashboard, the newly-limited column settings will be saved.
Forum: https://forum.pfsense.org/index.php?topic=107865.0
Not certain that the list needs to be sorted here. Looks like it is already in order. If it does then a valid callback function will need to be accessible.
Error: Non-space characters found without seeing a doctype first. Expected e.g. <!DOCTYPE html>.
Warning: uasort() expects parameter 2 to be a valid callback, function 'cpusercmp' not found or invalid function name in /usr/local/www/system_groupmanager_addprivs.php on line 91
Error: Element head is missing a required instance of child element title.
Warning: uasort() expects parameter 2 to be a valid callback, function 'cpusercmp' not found or invalid function name in /usr/local/www/system_groupmanager_addprivs.php on line 91
Error: Stray doctype.
Error: Stray start tag html.
