Commit Graph

61028 Commits

Author SHA1 Message Date
Côme Chilliet
e64e08ecac
Fix primary key change in user_ldap migration
Use a backup table to copy the data, drop table and recreate it with
 correct primary key, then copy the data back and drop the backup table.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-13 14:06:58 +01:00
Carl Schwan
992c26f8ed
Merge pull request #30531 from nextcloud/performance/optimize-filesystemtags-flow-groupfolder
Optimize FileSystemTags workflow for groupfolder
2022-01-13 13:52:29 +01:00
Carl Schwan
cbf9064b8e
Fix psalm issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 12:30:27 +01:00
Carl Schwan
695165260f
Add helper method in Wrapper
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 10:39:36 +01:00
Carl Schwan
0479fff37c
The storage is not static anymore
Don't call twice $cache->getId

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 10:39:36 +01:00
Carl Schwan
1f392d666a
Optimize FileSystemTags workflow for groupfolder
In https://github.com/nextcloud/server/pull/28774 we disabled the
caching for the groupfolder application since it worked due to the fact
that in groupfolders, getFileIds could be called with the same $cacheId
and path for actually different groupfolders.

This revert this change and instead add the folderId from the
groupFolder to the cacheId. This solve the issue of the uniqueness of
the cacheId inside GroupFolder. Downside is that we introduce
groupfolder specific implementation inside the server repo.

The seconf optimization is to not consider paths starting with
__groupfolders in executeCheck. This is due to the fact that files in
the groupfolder application call two times executeCheck one time with
the url __groupfolder/<folderId>/<path> and the other time with <path>.
The first time will always return an empty systemTags array while the
second call will return the correct system tags.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 10:39:32 +01:00
Carl Schwan
89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin
Fix psalm not running
2022-01-13 09:51:04 +01:00
Vincent Petry
7d5a63ab21
Merge pull request #30620 from nextcloud/bugfix/14897/fix-cancelling
Properly abort uploads
2022-01-13 09:26:46 +01:00
Carl Schwan
b1048864f0
Merge pull request #30600 from nextcloud/fix/30595/idn-email-share
Fix idn emails not working in shares
2022-01-13 09:24:26 +01:00
Nextcloud bot
094fbb9c0d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-13 02:26:35 +00:00
Carl Schwan
6312c0df69
Check style update
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 00:19:07 +01:00
Carl Schwan
fffc19f5c3
Fix types warnings from psalm
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:33:46 +01:00
Vincent Petry
11c7e100ae
Properly hide progress bar after error
Whenever an error occurs, also hide the progress bar.

The logic was also adjusted to properly detect uploads that are pending
deletion, in which case the progress bar can already be hidden.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-12 20:21:12 +01:00
Vincent Petry
6c4d4d8bc4
Properly abort uploads
Add a new approach for flagging an upload as aborted because we can't
rely on the browser fully cancelling the request as we now seem to
receive an error response from the server instead of a jQuery "abort"
message.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-12 20:21:12 +01:00
Carl Schwan
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:03:06 +01:00
Louis
8d813219c0
Merge pull request #30605 from nextcloud/fix/remove_legacy_build_files
Clear dist folder during build
2022-01-12 15:56:23 +01:00
Louis
9ec76d35b6
Merge pull request #30606 from nextcloud/deps/drop_eslint-webpack-loader
Drop eslint-loader
2022-01-12 15:55:56 +01:00
Louis
2e1491771e
Merge pull request #30572 from nextcloud/fix/lint_warnings
Fix lint warnings
2022-01-12 15:48:36 +01:00
Vincent Petry
db9fbc9307
Merge pull request #30593 from nextcloud/bugfix/19048/fix-changedirectory-recommendations
Trigger "changeDirectory" event on URL change
2022-01-12 14:41:50 +01:00
Joas Schilling
0d0fcd316a
Merge pull request #30625 from nextcloud/enh/jsconfig-theme-perf
Remove shortFooter/longFooter to avoid unnecessary navigation loading
2022-01-12 14:23:31 +01:00
Julius Härtl
55fd974926
Remove shortFooter/longFooter to avoid unnecessary navigation loading
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-01-12 12:16:39 +01:00
Louis
55cb608449
Merge pull request #30485 from nextcloud/fix/correctly_set_the_mtime_in_bulk_upload
Set the file's mtime from the headers in bulk upload
2022-01-12 11:57:23 +01:00
Louis Chemineau
ae6a9807c8 Drop eslint-loader
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-12 11:34:58 +01:00
Vincent Petry
8c75fcfbb8
Merge pull request #30609 from nextcloud/fix/noid/request-url-cli-check
Fix RequestURL check for cli commands
2022-01-12 09:07:05 +01:00
Nextcloud bot
41529ec22d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-12 02:26:58 +00:00
Carl Schwan
7ecb65f725
Add check before sending email that email address is valid
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 20:59:44 +01:00
Carl Schwan
08bf47a5de
Fix RequestURL check for cli commands
Fix https://github.com/nextcloud/files_automatedtagging/issues/526

Fix https://github.com/nextcloud/groupfolders/issues/1855

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 19:45:07 +01:00
Pytal
2bc0749cb6
Merge pull request #30588 from nextcloud/bugfix/noid/fix-unset-scopes 2022-01-11 10:12:11 -08:00
Vincent Petry
809e305444
Trigger "changeDirectory" even on URL change
When using the browser back button or clicking on sections on the left
sidebar (like favorites), the "changeDirectory" jQuery event did not get
called, so apps like recommendations would not notice the directory
change.

This fixes the issue by also setting changeUrl to true when the file
list's directory got changed as a result from a URL change.

Added optional changedThroughUrl argument to make sure the event
recipient knows if the change was done through a URL change and make it
possible prevent a loop in the onDirectoryChange handler that actually
changes the URL when the origin was already from a URL change.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-11 17:48:03 +01:00
Louis Chemineau
bfdfafde79 Compile frontend to update license files
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +01:00
Louis Chemineau
14e57bf70a Replace license information to SPDX expression
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +01:00
Louis Chemineau
bc47234e6b Remove legacy build files
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:16:05 +01:00
Louis Chemineau
37e5050d69 Import type from packages
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:13:08 +01:00
Louis Chemineau
9fc6cc9634 Add generic type and description when its missing
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:13:04 +01:00
Louis Chemineau
d92cbf5149 Typing corrections
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:12:55 +01:00
Louis Chemineau
69b8044b8f Set the file's mtime from the headers in bulk upload
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:10:14 +01:00
Louis Chemineau
2b1de9957c Clear dist folder during build
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 16:59:35 +01:00
Carl Schwan
d4a5e480ab
Fix idn emails not working in shares
Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 15:44:25 +01:00
MichaIng
796764aafd
Merge pull request #30533 from nextcloud/fix/avoid-zero-division
Avoid zero division in setup checks
2022-01-11 13:39:02 +01:00
Joas Schilling
c47406ad3c
Merge pull request #30291 from nextcloud/image-memory-limit
Prevent loading images that would require too much memory.
2022-01-11 13:35:56 +01:00
blizzz
b23934a45e
Merge pull request #30569 from nextcloud/fix/userlang_firstlogin
Default to language from request in L10N\Factory->getUserLanguage()
2022-01-11 12:59:07 +01:00
Joas Schilling
172be810b8
Fix test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 12:54:41 +01:00
Joas Schilling
bce7f09336
Merge pull request #30570 from nextcloud/rakekniven-branch3
Removed obselete language files - Pt. II
2022-01-11 11:56:56 +01:00
Joachim Bauch
d3d65e5c88
Prevent loading images that would require too much memory.
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.

The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
2022-01-11 11:44:38 +01:00
MichaIng
79cdb565dc Avoid zero division in setup checks
Fixes: https://github.com/nextcloud/server/issues/30532

Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 10:26:57 +00:00
Louis
6c3e9822e6
Merge pull request #30582 from nextcloud/fix/streamline_clearing_static_state
Streamline reseting of private static properties
2022-01-11 11:22:48 +01:00
Louis Chemineau
25ade6218a Streamline reseting of private static properties
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 10:29:25 +01:00
Joas Schilling
3c84570901
Fix undefined/unset scope in account properties
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 10:15:06 +01:00
Nextcloud bot
7484abb6c0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-11 02:27:07 +00:00
John Molakvoæ
5faba45e63
Merge pull request #30571 from nextcloud/fix/missing-jquery 2022-01-10 20:03:21 +01:00