Commit Graph

67818 Commits

Author SHA1 Message Date
Varun Patil
e6038268d8
Merge pull request #38374 from nextcloud/pulsejet/patch-ubr-nonce
webpack: add nonce to unsupported-browser-redirect chunk
2023-05-24 04:19:46 -07:00
Arthur Schiwon
b2e34267cd
Merge pull request #38415 from nextcloud/object-store-init-root
don't always check if we need to setup the object store root
2023-05-24 13:06:14 +02:00
Varun Patil
60a7610ca6 webpack: add nonce to unsupported-browser-redirect chunk
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-24 10:38:43 +00:00
F. E Noel Nfebe
4220442fa1
Merge pull request #37458 from Fenn-CS/fix/37424/better-501-error-logging
Avoid db connections when logging db connection errors
2023-05-24 08:46:03 +01:00
John Molakvoæ
4811a02740
Merge pull request #38329 from nextcloud/pulsejet/patch-webpack 2023-05-24 09:02:59 +02:00
Nextcloud bot
294035f523
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-24 00:17:47 +00:00
Simon L
3a9abb256e
Merge pull request #36316 from nextcloud/improve-fatal-logging
Log to `error_log` in fatal case
2023-05-23 23:02:18 +02:00
Daniel Kesselberg
7d02d98d9e
chore: recompile
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-05-23 22:36:14 +02:00
Varun Patil
ace6df86d8
Fix lint errors
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-23 22:34:15 +02:00
Varun Patil
48e1a58345
Optimize webpack chunks
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-23 22:34:14 +02:00
Varun Patil
66a8a9fba1
Use consistent imports for Vue components
This makes tree shaking possible

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-23 22:34:14 +02:00
Arthur Schiwon
0fca8238dd
Merge pull request #37665 from fsamapoor/patch-2
Refactors Command/Encryption/Enable.php to improve code readability.
2023-05-23 20:56:18 +02:00
Robin Appelman
cc0ad25c98
don't always check if we need to setup the object store root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-23 17:44:40 +02:00
Robin Windey
1dcc8559cf
Log to error_log in fatal case
Signed-off-by: Robin Windey <ro.windey@gmail.com>
2023-05-23 17:11:52 +02:00
Johannes
7ec1ceb79a
Merge pull request #38413 from nextcloud/fix/38412/save-avatar-SAB
fix(SAB): Save avatar to SAB
2023-05-23 15:55:26 +02:00
Julia Kirschenheuter
ea46959ef8
Merge pull request #38075 from nextcloud/fix/36923-The_Default_quota_input_field_in_the_Settings_section_is_not_programmatically_linked_to_its_visual_label
Add label to "default quota" multiselect
2023-05-23 15:33:48 +02:00
Simon L
3894a86e74
Merge pull request #38308 from nextcloud/fix/check-for-php-auth-server-variables
fix(carddav): Check if SERVER variables are set before accessing them
2023-05-23 14:33:49 +02:00
julia.kirschenheuter
1c90d7faf1 Add label to "default quota" multiselect
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-23 14:12:45 +02:00
Johannes Merkel
5983ef001d
fix(SAB): Save avatar to SAB
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-05-23 11:15:34 +02:00
Simon L
0713c1c4c6
Merge pull request #38393 from nextcloud/enh/noid/improve-issue-template
bug-report-template - move `Official All-in-One appliance` to the bottom
2023-05-23 11:01:15 +02:00
Anna Larch
3c93ce9c25
fix(carddav): Check if SERVER variables are set before accessing them
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-05-23 10:58:29 +02:00
John Molakvoæ
4e9e91a215
Merge pull request #38400 from nextcloud/cleanup/drop-oc-appsettings 2023-05-23 10:38:16 +02:00
Nextcloud bot
79334ebf90
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-23 00:17:26 +00:00
Louis
c8e85a4ecf
Merge pull request #38365 from JanisPlayer/patch-3
add imaginary_key
2023-05-22 23:39:26 +02:00
JanisPlayer
c71a3065a7 Allow to specify an imaginary key
Signed-off-by: JanisPlayer <54918417+JanisPlayer@users.noreply.github.com>
2023-05-22 22:19:51 +02:00
Robin Appelman
b253fe4a6b
Merge pull request #38259 from nextcloud/webui-share-reload
reload filelist when adding or removing shares
2023-05-22 16:53:16 +02:00
Robin Appelman
5479eb3cc2
Merge pull request #38291 from nextcloud/fix-loading-themed-logo
fix loading custom logo image
2023-05-22 16:39:38 +02:00
fenn-cs
d0fc159975 Avoid db connection when logging db connection errors
`\OC\Log\LogDetails::logDetails` depends on `\OC_App::getAppVersions()`
which makes a database connection causing the logger to break when the database
service is unavaiable.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-05-22 15:17:04 +01:00
fenn-cs
bb2c2bb7f0 Replace ILogger method calls index.php
This commit replaces more ILogger method calls with
 `Psr\Log\LoggerInterface` as we gradually move away from the
 custom ILogger.

This commit aslo, sets the customPsrLogger to not depend on the
 database to `logfile` config value.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-05-22 15:17:04 +01:00
Robin Appelman
8de2984349 reload filelist when adding or removing shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-05-22 13:22:52 +00:00
Robin Appelman
51984dc273
fix loading custom logo image
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-22 15:10:54 +02:00
Côme Chilliet
b313e2a507
Merge pull request #38162 from nextcloud/automated/noid/master-update-psalm-baseline
[master] Update psalm-baseline.xml
2023-05-22 14:30:10 +02:00
Joas Schilling
f74143be4b
Merge pull request #38164 from nextcloud/show-pending-popover-menu-when-password-is-enabled-by-default
Show pending popover menu when password is enabled by default
2023-05-22 14:17:27 +02:00
Joas Schilling
fdf7fd45be
Merge pull request #38227 from nextcloud/allow-enforcing-share-passwords-only-when-already-asking-for-a-password
Allow enforcing share passwords only when already asking for a password
2023-05-22 14:06:18 +02:00
Joas Schilling
9f8fa4802b
chore(assets): Recompile JS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-22 12:53:21 +02:00
Daniel Calviño Sánchez
d4631921b4
Show pending popover menu when password is enabled by default
When "Enforce password protection" is enabled in the sharing settings a
popover menu is shown to set a password before the share is created. On
the other hand, when "Always ask for a password" was enabled in the
sharing settings and a new link share was created the share was
immediately created with a default password; the user was not able to
specify a password (nor create the share without password).

The component template already provided the needed elements to also ask
for the password without enforcing it, but the popover menu was not
shown due to "enableLinkPasswordByDefault" being missing in "if"
conditions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:49:23 +02:00
Daniel Calviño Sánchez
d80f8fc84f
Rename "pendingPassword" to "pendingEnforcedPassword"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:49:15 +02:00
Joas Schilling
c1f3bcff70
chore(assets): Recompile JS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-22 12:46:59 +02:00
Daniel Calviño Sánchez
2c1a1b1779
Disable "Enforce password protection" if not asking for a password
"Enforce password protection" is a subcase of "Always ask for a
password", so it should be disabled if its parent option is unchecked.
Although other dependant options in the sharing settings are fully
hidden instead of just disabled this option is disabled but shown to
avoid confusion when updating from a previous Nextcloud version where
"Always ask for a password" was unchecked and "Enforce password
protection" was checked.

Besides that, due to their dependency the enforced password protection
is now automatically unchecked too if its parent option is unchecked.

Finally, the groups excluded from password requirements are also
disabled when "Always ask for a password" is unchecked, as they might be
still shown if "Enforce password protection" was checked due to an
update from a previous version.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:44:34 +02:00
Daniel Calviño Sánchez
6daf962b4c
Split long line
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:44:18 +02:00
Daniel Calviño Sánchez
2c97bca5d0
Indent "Enforce password protection"
"Enforce password protection" is a subcase of "Always ask for a
password", so it should be indented to visually show the dependency.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:44:17 +02:00
Daniel Calviño Sánchez
f9039b4fbd
Replace "div" with "span" inside "p"
The permitted contents of a paragraph are only phrasing contents, so
"div" elements can not be used, although "span" can. Besides being
invalid HTML it seems that the browser ends the paragraph at the div, so
the label/input that appears after it is treated as being in a new
paragraph, which is not indented by default, and thus is not aligned
with the rest of its sibling inputs.

Note that an additional div is nevertheless added once the page is
loaded to be able to select the groups, but this one does not break its
parent paragraph (maybe due to being added after the page load, but I do
not really know). Nevertheless, it needs to be explicitly indented, and
the second indentend wrapper needs to be removed, as it affects only the
label but not the div/input, and therefore the label had an extra
indentation over the input.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:44:17 +02:00
Daniel Calviño Sánchez
8fa09bec09
Move "br" immediately after "label" for consistency with other elements
The rest of "<br/>" elements in the file appear immediately after their
previous "</label>" rather than in a new line.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:44:17 +02:00
Daniel Calviño Sánchez
74bddb7a1a
Add missing end tag for "label"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-05-22 12:44:16 +02:00
Simon L
f7a6ed0389 bug-report-template - move archive to the top
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-22 11:21:33 +02:00
nextcloud-command
753cf1688c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2023-05-22 02:29:09 +00:00
Nextcloud bot
30e445773d
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-22 00:17:43 +00:00
Nextcloud bot
96f0118312
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-21 00:17:10 +00:00
Ferdinand Thiessen
a08b098476 chore: Remove deprecated OC.appSettings
Was deprecated since NC17 and scheduled for removal on NC18.
No apps use it and neither do core.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-05-20 15:28:23 +02:00
dependabot[bot]
428366cc7c
Merge pull request #38372 from nextcloud/dependabot/npm_and_yarn/tar-6.1.15 2023-05-20 03:54:51 +00:00