Carl Schwan
7619dceff4
Fix tests with email templates
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-18 20:56:50 +01:00
Carl Schwan
89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin
...
Fix psalm not running
2022-01-13 09:51:04 +01:00
Carl Schwan
b1048864f0
Merge pull request #30600 from nextcloud/fix/30595/idn-email-share
...
Fix idn emails not working in shares
2022-01-13 09:24:26 +01:00
Carl Schwan
6312c0df69
Check style update
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 00:19:07 +01:00
Louis
2e1491771e
Merge pull request #30572 from nextcloud/fix/lint_warnings
...
Fix lint warnings
2022-01-12 15:48:36 +01:00
Carl Schwan
7ecb65f725
Add check before sending email that email address is valid
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 20:59:44 +01:00
Pytal
2bc0749cb6
Merge pull request #30588 from nextcloud/bugfix/noid/fix-unset-scopes
2022-01-11 10:12:11 -08:00
Louis Chemineau
14e57bf70a
Replace license information to SPDX expression
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +01:00
Joas Schilling
c47406ad3c
Merge pull request #30291 from nextcloud/image-memory-limit
...
Prevent loading images that would require too much memory.
2022-01-11 13:35:56 +01:00
Joas Schilling
172be810b8
Fix test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 12:54:41 +01:00
Joachim Bauch
d3d65e5c88
Prevent loading images that would require too much memory.
...
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.
The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.
Signed-off-by: Joachim Bauch <bauch@struktur.de>
2022-01-11 11:44:38 +01:00
Louis Chemineau
25ade6218a
Streamline reseting of private static properties
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 10:29:25 +01:00
Louis Chemineau
92e60caa86
Revert "Streamline reseting of private static properties"
...
This reverts commit e50121d4c0 .
2022-01-10 18:42:07 +01:00
Louis Chemineau
e50121d4c0
Streamline reseting of private static properties
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-10 17:34:48 +01:00
Louis Chemineau
447cd553b6
Reset $scriptDeps in tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:15:48 +01:00
Louis Chemineau
1261fa5384
Adapt test to new dist file layout
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:14:53 +01:00
Joas Schilling
55986382e8
Merge pull request #30378 from nextcloud/feature/accept-multiple-args-on-concat
...
Accept multipe args on concat
2022-01-07 12:16:46 +01:00
Vitor Mattos
f732cf1b04
Unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-07 09:54:41 +01:00
Christopher Ng
19a3656fd9
Fix email verification
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-01-06 23:47:42 +00:00
Joas Schilling
773c407965
Merge pull request #29921 from nextcloud/feature/noid/allow-to-count-commments-with-multiple-verbs
...
Allow to count comments with multiple verbs
2022-01-05 13:44:07 +01:00
Joas Schilling
03abaaaee5
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-05 11:53:33 +01:00
Joas Schilling
977d8479e3
Merge pull request #30393 from nextcloud/feature/add-group-concat-aggregator-function
...
Add group_concat aggregator function
2022-01-04 17:34:37 +01:00
Joas Schilling
46ad6fa3c7
Add a test with integer
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-04 09:15:17 +01:00
Joas Schilling
43fa2d5c8c
Test with real data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-03 21:43:51 -03:00
Vitor Mattos
fb6a9f308d
Add unit test
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-03 21:41:38 -03:00
Vitor Mattos
7b9fea85b6
Add unit test and orderBy parameter
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-03 12:45:00 -03:00
Jonas Meurer
491bd6260c
Sort app scripts topologically by its dependencies
...
Implement a proper topological sorting algorithm. Based on the
implementation by https://github.com/marcj/topsort.php
Logs an error in case a circular dependency is detected.
Fixes : #30278
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-12-29 16:40:05 +01:00
Julius Härtl
61dd1d3d97
Pass username prefill through unauthenticated request redirects
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-29 11:52:31 +01:00
Julius Härtl
d73fe0ccd9
Merge pull request #29879 from nextcloud/bugfix/noid/sharing-enumeration-addressbooks
2021-12-21 08:11:04 +01:00
Jonas Meurer
8dd119402a
Improve unit testing for Util::addScript() and Util::getScript()
...
Instead of checking for a predefined order of the scripts, test the
logic: core first, dependencies before their children, no duplicates and
all scripts still listed.
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-12-20 11:40:17 +01:00
Côme Chilliet
ec4fff20e8
Avoid Deprecation warning from Zip tests on PHP 8.1
...
It is not allowed anymore to open an empty file as a new zip archive.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:58:40 +01:00
Côme Chilliet
e053feb5db
Fix PHP deprecation warning in File/ViewTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:32 +01:00
Julius Härtl
2fe8042fff
Add integration tests for email completion
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-08 09:08:54 +01:00
John Molakvoæ (skjnldsv)
791d57051a
Adapt tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-12-02 21:13:07 +01:00
Robin Appelman
6b3c703794
Merge pull request #29735 from nextcloud/background-scan-one-by-one
...
find users for background scan one by one
2021-12-02 17:09:43 +00:00
Robin Appelman
e95745c074
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:43:16 +01:00
Joas Schilling
6d33d75be1
Remove unused imports
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-02 14:51:44 +01:00
Joas Schilling
617528312a
Fix last tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-02 10:39:49 +01:00
Joas Schilling
3e20cffc86
More test fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:38:57 +01:00
Joas Schilling
c6ae53096c
More test fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:17:19 +01:00
Joas Schilling
9f00179037
More unit test adjustments
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 21:40:14 +01:00
Carl Schwan
a8866b0253
Fix tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-12-01 19:53:24 +01:00
Arthur Schiwon
d384edc9c6
add method to shorten a string to given byte size to Utils
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-26 16:21:40 +01:00
Vincent Petry
fd487c1a43
Merge pull request #29432 from nextcloud/fix/support-php-8.1
...
Support PHP 8.1 - First batch
2021-11-23 15:41:20 +01:00
Côme Chilliet
8b271b8a12
Fix tests and avoid PHP errors in them
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:01 +01:00
Côme Chilliet
cd72045433
Make mock config return default value to fix warnings
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:00 +01:00
Côme Chilliet
25fa0b8acd
Fix TempManager test errors about passing null to is_dir
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:00 +01:00
Côme Chilliet
065531570d
Fix Encryption tests on PHP 8.1
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:59 +01:00
Côme Chilliet
bb9c099e42
Fix FolderTest calls to Mountpoint constructor with wrong type
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:59 +01:00
Côme Chilliet
3a1b3745eb
Fix DateTime constructor calls with null
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:58 +01:00
Côme Chilliet
bc3acfc957
Fix test class names
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:57 +01:00
Côme Chilliet
66bdda568a
Fix Guzzle function calls
...
Since 1.7.0 and 2.0 these functions are turned into static methods.
See https://github.com/guzzle/psr7#upgrading-from-function-api
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:57 +01:00
Côme Chilliet
113756db30
Fix ArrayAccess and JsonSerializable return types
...
First round of modifications for PHP 8.1
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:56 +01:00
Vincent Petry
f01ad7b8d8
Improve normalizer detecting IPv4 inside of IPv6
...
The subnet for an IPv4 address inside of IPv6 is now returned in its
IPv4 form.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-22 16:46:25 +01:00
Vincent Petry
7e08a4ab15
Fix getting subnet of ipv4 mapped ipv6 addresses
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-22 14:10:11 +01:00
Vincent Petry
c42a890126
Merge pull request #29622 from nextcloud/feat/objectstore_multibucket-shift
...
Implement multibucket shift for ObjectStore
2021-11-19 17:26:44 +01:00
Vincent Petry
c92a0e4152
Normalize directory entries in Encoding wrapper
...
Directory entry file names are now normalized in getMetaData(),
getDirectoryContents() and opendir().
This makes the scanner work properly as it assumes pre-normalized names.
In case the names were not normalized, the scanner will now skip the
entries and display a warning when applicable.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-17 09:43:25 +01:00
Naoto Kobayashi
e9b414fbe3
OC_Util: Add fallbacks to check if current locale is UTF8
...
Using escapeshellcmd to get current locale causes error
if the function is disabled.
Add fallbacks to prevent the error.
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 00:40:52 +09:00
Naoto Kobayashi
25f15f86a9
Add check whether escapeshellcmd behaves the same as basename
...
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-15 18:33:50 +09:00
Naoto Kobayashi
455bff5c17
Fix missing setlocale with php 8
...
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").
Fix it by using escapeshellcmd instead of basename.
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-14 09:18:59 +09:00
Joas Schilling
265c2c125c
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-12 15:01:56 +01:00
John Molakvoæ
6ab2feaa54
Implement multibucket shift for ObjectStore
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-11-11 15:09:28 +01:00
Joas Schilling
3b91e4cc48
Add unit test for share enumeration method
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 14:42:57 +01:00
Joas Schilling
fa036b2001
Move common logic to share manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 10:10:53 +01:00
Christoph Wurst
95480f5a91
Merge pull request #29524 from nextcloud/bugfix/noid/fix-phpunit-warnings
...
Fix missing import of ILogger
2021-11-02 19:23:23 +01:00
Joas Schilling
f8463e1fc6
Fix missing import of ILogger
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-02 16:47:16 +01:00
Côme Chilliet
58b6f35522
Enable Avatar tests as well for PHP>=8
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-28 17:49:32 +02:00
Côme Chilliet
23a4e17bd1
Revert "Do not run image tests on php8"
...
This reverts commit d690f90928 .
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-28 17:49:21 +02:00
Joas Schilling
c42f5bc5f6
Add an OCP for trusted domain helper
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-28 10:24:16 +02:00
John Molakvoæ
f4e4a85fcf
Merge pull request #27440 from nextcloud/is-file-handle
2021-10-23 11:18:52 +02:00
John Molakvoæ
a06001e085
Merge pull request #29363 from nextcloud/fair-use-push
2021-10-23 10:53:22 +02:00
Vitor Mattos
d613b32045
add check isFairUseOfFreePushService on login
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +02:00
Joas Schilling
b578a1e8b5
Fair use of push notifications
...
We want to keep offering our push notification service for free, but large
users overload our infrastructure. For this reason we have to rate-limit the
use of push notifications. If you need this feature, consider setting up your
own push server or using Nextcloud Enterprise.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-23 00:54:50 +02:00
Arthur Schiwon
e26d6f080b
fix populating account array with missing default values
...
- both $userData and $defaultUserData have numeric indices
- each element contains at least the name and other fields
- appending the missing data array is sufficient
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-10-22 23:05:43 +02:00
acsfer
dae769d082
Update Tests
2021-10-22 12:16:11 +02:00
John Molakvoæ
2be0eda47c
Merge pull request #29220 from nextcloud/s3-external-list
2021-10-22 12:06:05 +02:00
John Molakvoæ
c98039c1df
Merge pull request #26725 from nextcloud/fix-federated-scope-not-shown-when-public-addressbook-upload-is-disabled
2021-10-22 11:52:56 +02:00
John Molakvoæ
0a35937662
Merge pull request #26347 from J0WI/clean-path-regex
2021-10-22 11:42:30 +02:00
John Molakvoæ
7e3b6e7088
Merge pull request #29344 from nextcloud/dependabot/composer/doctrine/dbal-3.1.3
2021-10-22 11:35:02 +02:00
Christoph Wurst
7dd7256cfe
Prevent duplicate auth token activity updates
...
The auth token activity logic works as follows
* Read auth token
* Compare last activity time stamp to current time
* Update auth token activity if it's older than x seconds
This works fine in isolation but with concurrency that means that
occasionally the same token is read simultaneously by two processes and
both of these processes will trigger an update of the same row.
Affectively the second update doesn't add much value. It might set the
time stamp to the exact same time stamp or one a few seconds later. But
the last activity is no precise science, we don't need this accuracy.
This patch changes the UPDATE query to include the expected value in a
comparison with the current data. This results in an affected row when
the data in the DB still has an old time stamp, but won't affect a row
if the time stamp is (nearly) up to date.
This is a micro optimization and will possibly not show any significant
performance improvement. Yet in setups with a DB cluster it means that
the write node has to send fewer changes to the read nodes due to the
lower number of actual changes.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-22 09:32:22 +02:00
Christoph Wurst
130ab63ca1
Bump doctrine/dbal from 3.0.0 to 3.1.3
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-22 09:03:45 +02:00
Julien Veyssier
0bef570fe9
Merge pull request #29256 from nextcloud/fix/noid/harmonize-appstoreenabled-check
...
Fix appstoreenabled check
2021-10-21 12:42:14 +02:00
Joas Schilling
f24e8212c3
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-21 09:27:12 +02:00
Joas Schilling
7f1dc52a66
Change origin field to appId
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-20 14:47:28 +02:00
John Molakvoæ
5e23800a95
Do not remove current user on findOne
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-20 11:53:45 +02:00
John Molakvoæ
873e8e219c
Add appName to contactsmenu action API
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-20 11:53:45 +02:00
Christopher Ng
309354852f
Profile backend
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:59:35 +00:00
Christopher Ng
7215148a24
Add new account properties
...
- New properties
- Organisation
- Role
- Headline
- Biography
- Profile Enabled property
- Fix errors with building default account properties
- Fix L10N factory method `getLanguage` not public error
- Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:44:40 +00:00
Robin Appelman
294b218895
ci
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-15 15:35:12 +02:00
John Molakvoæ
f7a4ff4d63
Merge pull request #27217 from nextcloud/techdebt/noid/make-debugging-a-cron-job-easier
2021-10-15 11:09:23 +02:00
John Molakvoæ
b6a3ba136c
Merge pull request #29235 from nextcloud/feat/appstore/enterprise
2021-10-15 11:06:32 +02:00
Christoph Wurst
67baaaaff9
Merge pull request #29231 from nextcloud/fix/calendar-providers-instances
...
Build instances of the calendar providers before using them
2021-10-14 19:29:34 +02:00
Christoph Wurst
c75a12c154
Build instances of the calendar providers before using them
...
What we get from the registration context are only the class names. We
still have to load the classes before we can use them.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-14 16:06:51 +02:00
John Molakvoæ
1f76423500
Send the subscription key to the appstore requests
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-14 14:48:45 +02:00
Julius Härtl
acbe4b46c3
Merge pull request #29157 from nextcloud/enh/opendocument
2021-10-14 12:58:34 +02:00
Joas Schilling
9cd9f4b4bc
Move queries to the joblist
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +02:00
Joas Schilling
811d0cd1b5
Merge pull request #29135 from nextcloud/feat/appstore-filtering
...
Allow to filter apps from the appstore
2021-10-14 09:50:37 +02:00
Anna Larch
a58d1e6b06
Add Public Calendar Provider
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-14 08:22:24 +02:00
Julius Härtl
2f38781c96
Fix integrity checker tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-13 18:10:37 +02:00
John Molakvoæ
1a6bac5874
Allow to whitelist apps from the apsptore
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-13 11:13:33 +02:00
Christoph Wurst
e163d199d8
Merge pull request #29015 from nextcloud/enhancement/l10n-factory-find-generic-language
...
Add L10n factory method for generic language heuristics
2021-10-13 10:58:07 +02:00
Christoph Wurst
5b727fc7da
Add L10n factory method for generic language heuristics
...
The existing `findLanguage` method tries its best to find the best
language for the current users. For some tasks we don't want this but
rather determine the most generic language for *another* user, e.g. when
the current user trigger an email notifiaction to someone else. In this
case the current user's language is a bad guess in many multi-language
environments.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-13 09:57:21 +02:00
Joas Schilling
3487aeeb1f
Add integration tests for group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-12 14:05:38 +02:00
Daniel
9187e986e1
Merge pull request #28907 from nextcloud/bug/noid/close-stream-local
...
explicitly close source stream on local / encryption storage
2021-10-08 10:02:01 +02:00
Louis
9a569ff387
Merge pull request #29064 from nextcloud/feature/add_cache_to_local_integration_tests_container
...
Add caching for local run of integration and acceptance tests
2021-10-06 21:04:47 +02:00
Louis Chemineau
b13ce08ac8
Add cache for local integration test container
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-10-06 13:33:47 +02:00
Louis Chemineau
32dc976e0d
Fix app-files acceptance tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-10-06 10:09:14 +02:00
Julius Härtl
d68f028251
Merge pull request #27733 from PhrozenByte/enhancement/noid/IURLGenerator-linkToDefaultPageUrl
2021-10-05 13:06:59 +02:00
Daniel Kesselberg
e6ab948949
Make AppsEnableTest and AppsDisableTest independet of the app version number
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-10-01 23:08:59 +02:00
Carl Schwan
04f1882386
Merge pull request #28189 from nextcloud/work/carl/admin-delegation
...
Implement Admin Delegation
2021-09-29 22:48:32 +02:00
Carl Schwan
6958d8005a
Add admin privilege delegation for admin settings
...
This makes it possible for selected groups to access some settings
pages.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +02:00
Joas Schilling
a586739e17
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-09-29 10:02:21 +02:00
Julius Härtl
9161f6ca4a
Remove tests that just prove mocked calls and don't actually validate anything useful
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-09-27 14:24:48 +02:00
Julius Härtl
cab44b6311
Run oci tests against phpunit9/php8
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-09-27 14:24:05 +02:00
Daniel Kesselberg
e60a829b42
explicitly close source stream on local storage
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-09-21 17:41:59 +02:00
John Molakvoæ
cbe406ea3e
Bump @nextcloud/vue
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-09-16 18:12:00 +02:00
Daniel Kesselberg
024881dbd3
Add email addresses to contacts menu
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-09-15 16:58:44 +02:00
John Molakvoæ
a994ef0c4f
Merge pull request #28792 from nextcloud/fix/noid/lost-password-missing-prefix
...
fixes missing prefix to validate password reset token
2021-09-14 09:50:22 +02:00
Lukas Reschke
0dcc5c0e9f
Merge pull request #28728 from nextcloud/add-database-backend-limiter
...
Add database ratelimiting backend
2021-09-13 13:07:37 +02:00
Arthur Schiwon
6857136f06
fixes missing prefix to validate password reset token
...
- also fixes the test which missed asserting the presence of it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-10 19:06:50 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +02:00
Arthur Schiwon
4461b9e870
enable the user to set a primary (notification) email address (backend)
...
- specific getters and setters on IUser and implementation
- new notify_email field in provisioning API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:04 +02:00
Arthur Schiwon
a20de15b43
add a job to clean up expired verification tokens
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:35 +02:00
Arthur Schiwon
aacaad2a3f
implement verification for additional mails
...
- mails added by (sub)admins are automatically verified
- provisioning_api controller as verification endpoint
- IAccountProperty gets a locallyVerified property
- IPropertyCollection gets a method to fetch an IAccountProperty by value
- an remove equivalent was already present
- AccountManager always initiates mail verification on update if necessary
- add core success template for arbitrary title and message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:35 +02:00
Arthur Schiwon
19cc757531
move verification token logic out of lost password controller
...
- to make it reusable
- needed for local email verification
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:29 +02:00
Lukas Reschke
c21a721fc1
Merge pull request #28725 from nextcloud/disallow-public-page-in-2fa-flow
...
Remove 2FA exemption from PublicPage annotation
2021-09-07 10:44:34 +02:00
Lukas Reschke
19ad636373
Resolve absolute path in tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 21:26:27 +02:00
Lukas Reschke
6337bb3f59
Adjust tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 17:46:02 +02:00
Lukas Reschke
378cc922c4
Adjust logic to store period instead of current timestamp
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 17:31:36 +02:00
Lukas Reschke
8da6a9bea9
Adjust tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 09:09:42 +00:00
Bernd Rederlechner
3866f388b1
Refactor writeObject to only use MultipartUpload when required
...
Signed-off-by: Bernd Rederlechner <Bernd.Rederlechner@t-systems.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
2021-08-20 17:02:25 +02:00
Christoph Wurst
4b0e18ae1b
Merge pull request #27294 from pjft/patch-2
...
Update TwoFactorChallengeController.php
2021-08-19 12:40:40 +02:00
Daniel Calviño Sánchez
83b39d6111
Add missing scope to test
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-08-18 19:05:33 +02:00
Jonas Meurer
7c76e85dde
Use IURLGenerator function to get value of \OC::$WEBROOT global
...
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-08-16 10:56:47 +02:00
acsfer
11169c86f8
Tests update
2021-08-15 12:23:29 +02:00
John Molakvoæ
67e6468b9e
Merge pull request #28220 from nextcloud/get-by-id-multiple-mounts-single-storage
2021-08-09 19:27:23 +02:00
Daniel Rudolf
a1d6189dfa
Fix UrlGeneratorTest
...
And again... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-08-05 13:55:35 +02:00
Daniel Rudolf
aa455e71d9
Merge branch 'master' into enhancement/noid/IURLGenerator-linkToDefaultPageUrl
2021-08-04 18:52:55 +02:00
Daniel Rudolf
b768cade2b
Fix UrlGeneratorTest
...
Again... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-08-04 18:52:53 +02:00
Julien Veyssier
416d10f76c
refs #21045 add app config to disable unlimited quota and to set max quota
...
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +00:00
Julius Härtl
db7ffb0bf9
Merge pull request #28175 from nextcloud/jail-search-root
2021-07-29 09:27:53 +02:00
Robin Appelman
5c2e7c7d28
fix Folder->getById() when a single storage is mounted multiple times
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-28 17:21:04 +02:00
Robin Appelman
4d5e8bcb99
add test for searching within a "root jail"
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-28 17:11:12 +02:00
Julius Härtl
b31c08e536
Merge pull request #28075 from nextcloud/enh/noid/admin_audit-report-full-path
...
Admin Audit - Sharing: createShare - report the full path
2021-07-26 12:35:48 +02:00
Julius Härtl
858d846999
Let memory limit set in tests fit the used amount
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-22 17:05:29 +02:00
szaimen
4570bb4f65
Admin Audit - Sharing: createShare - report the full path
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-22 14:20:05 +00:00
Julius Härtl
7179002600
Allow to get a local cloud id without going through the contacts manager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-14 16:08:05 +02:00
Joas Schilling
11d21e5f5c
Add a unit test to check for casting a IQueryFunction
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-07 14:19:24 +02:00
Lukas Reschke
415d704959
Merge pull request #27198 from nextcloud/tests/run-s3-tests
...
Run s3 tests again
2021-07-05 11:52:48 +02:00
Daniel Rudolf
1e5962ae98
Fix UrlGeneratorTest::testGetDefaultPageUrlWithDefaultApps()
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:39:26 +02:00
Daniel Rudolf
15a445f743
Move UtilTest::testDefaultApps() to UrlGeneratorTest
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:26:55 +02:00
Daniel Rudolf
e16bf707aa
Fix UtilTest::testDefaultApps()
...
Oh wow... This definitly was no best practice... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:00:29 +02:00
Daniel Rudolf
e478db9161
Deprecate RedirectToDefaultAppResponse
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 15:13:08 +02:00
Julius Härtl
55cabef723
Use minio for s3 tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-01 08:22:24 +02:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 -04:00
Daniel Rudolf
0df68f0697
Remove unused imports
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-06-30 16:48:22 +02:00
Daniel Rudolf
12059eb65b
Add IUrlGenerator::linkToDefaultPageUrl()
...
Replaces the deprecated \OC_Util::getDefaultPageUrl() and makes this API public.
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-06-30 16:20:57 +02:00
Julius Härtl
3f44fd00e2
Run s3 tests again
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-30 14:30:04 +02:00
Arthur Schiwon
506227b509
adjust internal data handling logic to fix store and load
...
- format as stored previously in oc_accounts table is kept
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:48:01 +02:00
Arthur Schiwon
c7bf4295cc
adjust email verification checker
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:47:36 +02:00
Arthur Schiwon
3d6ffd3da2
adjust verification state updater method
...
- also fixes scope of internal methods
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:42:42 +02:00
Arthur Schiwon
af3fdbea7b
make AccountManager actually write multi value properties
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:12 +02:00
Arthur Schiwon
638c04d6e0
accounts event handler to use eventdispatcher, DI and Accounts API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +02:00
Arthur Schiwon
13818005a3
prov api reports additional emails on getUser
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:10 +02:00
Joas Schilling
a651dbd2c0
Fix app version check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-25 11:49:32 +02:00
Pytal
9ed379da22
Merge pull request #27635 from nextcloud/fix/datetime-constants
...
Fix usage of DateTime constants
2021-06-23 09:56:28 -07:00
Christoph Wurst
6d5cfe0c66
Move DateTime::RFC2822 to DateTimeInterface::2822
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:30:43 +02:00
Christoph Wurst
770881d5d6
Move DateTime::ATOM to DateTimeInterface::ATOM
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:28:07 +02:00
blizzz
ee7a484284
Merge pull request #26346 from J0WI/clean-auth-regex
...
Cleaner removePassword regex
2021-06-23 11:20:19 +02:00
pjft
b1086e25bb
Add logging to 2FA failure
...
For security reasons, we may want to monitor failures of 2FA challenges in order to ban attackers who might try to access compromised accounts but are stopped by the 2FA challenge.
Right now, the only hindrance is rate-limiting, but it's probably not enough.
Added dependency injection.
Signed-off-by: pjft <paulo.j.tavares@gmail.com>
2021-06-21 20:43:12 +01:00
Julius Härtl
a94236483e
Let apps toggle an unread counter on app icons
...
Co-authored-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-16 17:12:56 +02:00
blizzz
818fc95b03
Merge pull request #26571 from nextcloud/bugfix/noid/existing-link-no-reshare
...
Only allow removing existing shares that would not be allowed due to reshare restrictions
2021-06-16 15:26:12 +02:00
Robin Appelman
66e10718c6
split of query building bits from searchhelper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:40 +02:00
Robin Appelman
f938daa6e4
update tests and fix some edge cases around new search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:36 +02:00
Robin Appelman
e198dc1b20
rework search api to allow searching on multiple caches at once
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:22 +02:00
Julius Härtl
964fd27666
Handle single action unshare
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-09 10:43:50 +02:00
kesselb
89c534858e
Merge pull request #27414 from francoisfreitag/test-at-2
...
Rewrite LegacyHelperTest without $this->at()
2021-06-08 22:07:16 +02:00
Christoph Wurst
745543d8c0
Merge pull request #27306 from nextcloud/enh/noid/set-local-domain-for-swiftmailer
...
Set local domain for swiftmailer
2021-06-08 15:43:39 +02:00
blizzz
662ab937e0
Merge pull request #27189 from nextcloud/feat/26866/account-collection-properties
...
Extend Accounts with multivalue properties (PropertyCollection)
2021-06-08 14:25:18 +02:00
Arthur Schiwon
ff2382e5a4
CI: more flexible assertions
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-07 23:41:04 +02:00
François Freitag
21762a1e94
Rewrite LegacyHelperTest without $this->at()
...
The at() matcher has been deprecated. It will be removed in PHPUnit 10.
Please refactor your test to not rely on the order in which methods are
invoked.
Signed-off-by: François Freitag <mail@franek.fr>
2021-06-07 21:43:30 +02:00
Morris Jobke
92d19bd79b
Merge pull request #27374 from nextcloud/bugfix/noid/adjust-unit-tests
...
Bugfix/noid/adjust unit tests
2021-06-07 11:12:22 +02:00
François Freitag
70edda0342
Port dav calendar settings page to Vue.js
...
- Drop reliance on deprecated global jQuery object.
- Allow testing user interactions.
- Use newer technology stack.
---
Test user interactions with the groupware dav settings
Add infrastructure to test Vue components:
- Use recommended libraries:
- https://vuejs.org/v2/guide/testing.html#Recommendations
- Use jest-dom for robust assertions on the DOM state
- Use user-event to be more representative of user actions
- Code is transpiled by Jest, with the help of vue-jest.
Ignore test files for no-unpublished-import. Prevent ESLint from
flagging:
```
/home/runner/work/server/server/apps/dav/src/views/CalDavSettings.spec.js
Error: 1:24 error "@testing-library/vue" is not published node/no-unpublished-import
Error: 2:23 error "@testing-library/user-event" is not published node/no-unpublished-import
```
Signed-off-by: François Freitag <mail@franek.fr>
2021-06-05 11:22:25 +02:00
Joas Schilling
181aab416a
Fix warnings about logException
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-04 10:57:09 +02:00
Arthur Schiwon
44827e37c0
allow interacting with IAccountPropertyCollections
...
- in fact the API could be done in a nicer way and it might be possible to
work without IAccountPropertyCollection, but only with the
IAccountProperties.
- To keep it simple at first and not overengineer the blunt attempt is
followed
- If necessary helpful in the further cause of development adjustements or
extensions can be done quickly with this base
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +02:00
Arthur Schiwon
0bade27479
add IAccountPropertyCollection with implementation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +02:00
Arthur Schiwon
afea57352b
update unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +02:00
Lukas Reschke
377514aad1
Escape filename in Content-Disposition
...
We should escape all occurences of ' and \ in here.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-02 19:22:17 +02:00
John Molakvoæ
d0cf20cc51
Merge pull request #26792 from nextcloud/user-delete-cleanup-files
...
better cleanup of user files on user deletion
2021-06-02 17:02:00 +02:00
Christoph Wurst
b29c3aa03f
Merge pull request #25658 from nextcloud/dav-respect-disallow-sharing-with-groups
...
Dav respect disallow sharing with groups
2021-06-01 12:07:29 +02:00
Daniel Kesselberg
747325fc43
Set local domain for swiftmailer transport
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-05-31 15:04:00 +02:00
François Freitag
b0847abcc2
Rewrite requesttoken.spec.js with Jest
...
[Jest](https://jestjs.io/ ) is a test runner that focuses on simplicity.
It instruments babel to transform modules and test them.
Using Jest simplifies the existing configuration and allows dropping a
bunch of workarounds, as well as following the shared Babel
configuration for new code.
Signed-off-by: François Freitag <mail@franek.fr>
2021-05-30 10:44:34 +02:00
Thomas Citharel
1c0d975654
Make dav respect disallowing sharing with groups
...
Closes #25390
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-05-26 11:19:59 +02:00
blizzz
1b47886abb
Merge pull request #27035 from nextcloud/techdebt/26866/userscontroller-accountmanager-api
...
do not use private AccountManager in UsersController
2021-05-25 21:22:37 +02:00
Morris Jobke
726d01843e
Merge pull request #26600 from hosting-de/feature/occ-tags
...
Add commands to manage tags via OCC
2021-05-25 16:54:06 +02:00
Arthur Schiwon
847ed37afc
do not use private AccountManager in UsersController
...
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +02:00
Johannes Leuker
d606799ee2
Add commands to manage tags via OCC
...
list, add, delete, edit
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-05-25 11:29:32 +02:00
Morris Jobke
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
...
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +02:00
Valdnet
1627eb45bb
l10n: Fix test
2021-05-20 09:26:38 +02:00
Julius Härtl
35b910cf8e
Merge pull request #26322 from nextcloud/recent-search
...
Use file search for recent files and optimize getting share types
2021-05-18 09:44:08 +02:00