Commit Graph

6347 Commits

Author SHA1 Message Date
Vincent Petry
01dbd22c9c
Validate requested length is random string generator
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-05-12 13:58:18 +02:00
John Molakvoæ
3c6253f965
Remove old legacy SvgController and IconsCacher
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-10 23:24:07 +02:00
Côme Chilliet
a953401999
Migrate phpunit configuration to new format
Fixes:
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-09 11:51:14 +02:00
Joas Schilling
7b3e2217de
Fix user agent trimming on installation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-09 08:36:34 +02:00
blizzz
0284c0f717
Merge pull request #32276 from nextcloud/fix/ldap_error_handling
Do not dispatch postSetPassword when setPassword fails
2022-05-05 20:19:28 +02:00
Vincent Petry
7718c9776c
Merge pull request #32113 from nextcloud/bugfix/noid/fix-csp-merging-bools
Add CSP policy merge priority for booleans
2022-05-05 17:26:48 +02:00
Louis Chemineau
8a2cf5bb68 Do not dispatch postSetPassword when setPassword fails
Also Improve error message when setPassword fails

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-05 17:21:23 +02:00
Joas Schilling
d3efd40a24
Merge pull request #32259 from nextcloud/adjust-acceptance-tests-to-changes-in-notifications-markup
Adjust acceptance tests to changes in notifications markup
2022-05-05 09:21:00 +02:00
Joas Schilling
24e25a6b64
Merge pull request #32249 from nextcloud/bugfix/noid/fix-missing-subline-info
Expose shareWithDisplayNameUnique also on autocomplete endpoint
2022-05-05 09:20:45 +02:00
Daniel Calviño Sánchez
3c451f8357 Adjust acceptance tests to changes in notifications markup
Since nextcloud/notifications#1178 each notification in the list is a
"<li>" rather than a "<div>".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-05-03 23:16:24 +02:00
Joas Schilling
290697b08f
Merge pull request #32220 from nextcloud/feature/add-tests-to-validate-emojis
Include more emoji chars to test and fixes after include it
2022-05-03 16:08:19 +02:00
Joas Schilling
6e4d721278
Expose shareWithDisplayNameUnique also on autocomplete endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-03 12:51:23 +02:00
Côme Chilliet
459202d54c
Merge pull request #31752 from nextcloud/fix/remove-still-more-ilogger
Move away from deprecated ILogger
2022-05-02 10:15:10 +02:00
Vitor Mattos
cefcd55994
Include more emoji chars to test and fixes after include it
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-04-29 14:00:57 -03:00
Côme Chilliet
8184e356f4
Remove test for removed class SearchResultSorter
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-28 14:56:26 +02:00
Joas Schilling
902476fa20
Extract the EmojiService from user status and add an OCP interface
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-28 07:09:44 -03:00
Joas Schilling
a4cd9fd37c
Add a unit test for translation with trailing colon
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-26 11:05:19 +02:00
Carl Schwan
59e0402691
Merge pull request #32069 from nextcloud/cleanup/allconfig-sql
Cleanup AllConfig
2022-04-25 18:56:15 +02:00
Kirill Popov
0b27b9e658 Get not only time-sensitive next job from list but any
Before the change webcron used to select
**only** time-sensitive tasks.

Signed-off-by: Kirill Popov <kirill.s.popov@gmail.com>
2022-04-24 21:55:53 +03:00
Carl Schwan
8bbdd9ea0c Cleanup AllConfig
- Port to QueryBuilder
- More typing when possible
- Import classes with 'use'

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-22 16:03:29 +02:00
John Molakvoæ
05a33ad713
Fix acceptance
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:29 +02:00
John Molakvoæ
3c75a99267
Phpunit
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:28 +02:00
Joas Schilling
efb432865f
Fix test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-20 13:08:31 +02:00
Carl Schwan
7817845538 Add a metadata service to store file metadata
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-13 14:06:29 +02:00
Vincent Petry
cd95fce105
Merge pull request #31932 from nextcloud/feat/ignore_second_dn
Add settings to ignore second display name in search
2022-04-13 09:52:38 +02:00
Louis Chemineau
37f1c8640e Add settings to ignore second display name in search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-12 17:27:59 +02:00
Maxence Lange
d70d90702f
Merge pull request #31907 from nextcloud/enh/noid/tag-remote-as-globalscale
confirm user is internal to globalscale
2022-04-12 11:10:36 -01:00
Maxence Lange
10eafd70c8 confirm user is internal to globalscale
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2022-04-12 09:11:05 -01:00
Cyrille Bollu
c6a5c07041 Adds a "Request password" button to the public share authentication page for shares
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.

- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
  attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords

-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue

See https://github.com/nextcloud/server/issues/31005

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +02:00
Robin Appelman
151c800397
allow reusing known folder info when getting directory contents
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-06 14:40:34 +02:00
Vincent Petry
b8b4d247b4
Merge pull request #31194 from nextcloud/feat/allow-to-exclude-groups-from-password-enforcement
Allow to disable password policy enforcement for selected groups
2022-04-06 10:13:23 +02:00
Carl Schwan
a29251e02d Allow to disable password policy enforcement for selected groups
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +00:00
Robin Appelman
754603a04e
dont needlessly resolve path when getting internalPath/storage from Node
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-04 15:40:24 +02:00
Carl Schwan
135bdb3d58
Merge pull request #30823 from nextcloud/work/profiler
Built-in profiler

This adds the required API for collecting information about requests. This information
can then be displayed with the new 'profiler' app.
2022-04-04 12:56:37 +02:00
Carl Schwan
7d272c54d0 Add a built-in profiler inside Nextcloud
The webui is provided by a seperate application named profiler

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-04 10:28:26 +02:00
Côme Chilliet
d3d53494d4
Merge pull request #31750 from nextcloud/fix/ci-should-fail-on-deprecation-warnings
Convert deprecation warnings to exception in phpunit
2022-04-01 14:11:41 +02:00
Vincent Petry
18c013d8fc
Add CSP policy merge priority for booleans
When two booleans conflict when merging CSP policies, true will win.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-01 13:56:34 +02:00
Côme Chilliet
dd357d7f9b
Merge pull request #31679 from nextcloud/bugfix/noid/ensure-string-columns-to-be-maximum-of-4000
Ensure string column limit of 4.000 characters
2022-03-31 11:37:43 +02:00
Côme Chilliet
cba4d85d9b
Convert deprecation warnings to exception in php unit
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-29 21:48:35 +02:00
Vincent Petry
576e4e8f2a
Merge pull request #31592 from nextcloud/fix/direct-arg-flow-v2
Add direct arg to login flow
2022-03-29 18:21:40 +02:00
Côme Chilliet
765999f454
Merge pull request #31609 from nextcloud/fix/migrate-away-from-ilogger
Migrate from ILogger to LoggerInterface in lib/private
2022-03-29 09:39:38 +02:00
Vincent Petry
80388663af Add direct arg to login flow
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-Authored-by: Carl Schwan <carl@carlschwan.eu>
2022-03-28 10:28:45 +02:00
Joas Schilling
129bae62d4
Ensure string column limit of 4.000 characters
https://docs.oracle.com/en/database/oracle/oracle-database/19/refrn/datatype-limits.html#GUID-963C79C9-9303-49FE-8F2D-C8AAF04D3095

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-25 12:44:51 +01:00
Côme Chilliet
bfd09a0669 Avoid select with no FROM clause for Oracle in tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 20:35:02 +00:00
Côme Chilliet
efebbacca4 Add octetLength and charLength to function builder, and tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 20:35:02 +00:00
Côme Chilliet
3546cfba1c
Fix more ILogger related problems from tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:27 +01:00
Côme Chilliet
1809386862
Fix codestyle
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:27 +01:00
Côme Chilliet
61f7f13bd8
Migrate from ILogger to LoggerInterface where needed in the tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:26 +01:00
Joas Schilling
367be7c55f
Allow reactions also with other combined emojis
Honerful copying the EmojiService from UserStatus for now
I think this should be put into a decent place and then reused,
but I couldn't find somethin short term before beta1

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-24 15:13:09 +01:00
Joas Schilling
d683e0d3d1
Automatically cut the token name on the first level
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 21:38:53 +01:00
Joas Schilling
343476f54f
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 11:00:34 +01:00
Joas Schilling
89e293d3fd
Test disabled for now due to multiple reasons
see https://github.com/nextcloud/server/pull/31580#issuecomment-1069182234 for details

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-22 17:07:48 +01:00
Joas Schilling
0acd4b5f82
Merge pull request #31235 from nextcloud/techdebt/noid/extract-request-id
Extract request id handling to dedicated class so it can be injected without DB dependency
2022-03-22 12:08:45 +01:00
Christopher Ng
108abd77ed Add profile default setting for admin
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +00:00
Christopher Ng
1fc0b4320c Add global profile toggle config
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +00:00
Christopher Ng
2d9d0702f0 Add method to set all account properties from json
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-17 16:33:19 +00:00
Christopher Ng
a99d33c72d Discard duplicate collection name from account serialization
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-17 04:27:39 +00:00
Joas Schilling
04a4562a01
Merge pull request #31513 from nextcloud/techdebt/noid/enforce-primary-keys
Enforce primary keys as they are required to be performant in MySQL c…
2022-03-15 10:53:11 +01:00
Joas Schilling
21f96308c4
Overwrite the channel
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:16:30 +01:00
Joas Schilling
1970d3dc9a
Add a test for primary keys
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 14:04:04 +01:00
Julius Härtl
bd03dd37be
Allow to set a strict-dynamic CSP through the API
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-03-09 15:10:27 +01:00
Robin Appelman
917c74e214
type fixes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:16 +01:00
Robin Appelman
d81713e5c1
simplify setup of circular SetupManager<->Manager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:09 +01:00
Robin Appelman
22875bf367
move logic to decide what to setup to setupmanager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:03 +01:00
Robin Appelman
1c468129af
adjust tests to new fs setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:59 +01:00
Robin Appelman
8b22a463e9
Merge pull request #31266 from nextcloud/root-setup-mountprovider
move root mount setup to mountproviders
2022-03-04 13:44:05 +00:00
John Molakvoæ
821a0dc875
Merge pull request #31387 from nextcloud/fix/common-main-core-script-order 2022-03-04 14:37:41 +01:00
John Molakvoæ
58d516b509
Make sure common and main core scripts are loaded first
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-03-04 10:22:56 +01:00
Daniel Calviño Sánchez
a3f3ffe6a6 Update images in scripts to run local tests in Docker
PHP 7.3 support was dropped for Nextcloud 24. The Docker images are
updated to the same images used for integration and acceptance tests in
CI.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-03-03 19:53:26 +01:00
Julius Härtl
2dd96fe8da
Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +01:00
Julius Härtl
eede608c0e
Add event logging to app loading
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +01:00
Robin Appelman
d08d0ebdda
skip localstorage dependend user test when not using local user storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-25 16:33:11 +01:00
Robin Appelman
8b7c8447a0
move root mount setup to mountproviders
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-24 17:21:42 +01:00
Robin Appelman
cfb7923e08
store mountprovider for each mount in the mounts table
this enabled more fine grained filesystem setup

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-23 18:02:33 +01:00
Joas Schilling
d078d53683
Fix tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 11:01:58 +01:00
Joas Schilling
cc6653e45c
Adjust and add unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 11:01:58 +01:00
Christoph Wurst
cb252c5591
Add Transactional trait for atomic DB operations
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-17 09:58:41 +01:00
Christopher Ng
e485451eed Add test
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-02-11 23:34:25 +00:00
Robin Appelman
2673775f6e
fix fs cache test user setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:28 +01:00
Christoph Wurst
cd7a217c29
Merge pull request #31007 from nextcloud/enhancement/bootstrap-calendar-resource-room-backend-registration
Move calendar resource/room backend registration to IBootstrap
2022-02-09 10:25:03 +01:00
Joas Schilling
c58f8d6025
Merge pull request #30945 from nextcloud/techdebt/noid/background-job-time-windows
Background job time windows
2022-02-08 14:46:20 +01:00
Joas Schilling
6dd60b6d30
Only allow avatars in 64 and 512 pixel size
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-07 16:47:51 +01:00
Joas Schilling
b765f79368
Allow apps to specify if their background job can be delayed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-07 13:54:54 +01:00
Christoph Wurst
9a656e5b35
Move calendar resource/room backend registration to IBootstrap
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-07 12:51:42 +01:00
Joas Schilling
82f602e857
Merge pull request #30354 from nextcloud/enhancement/talk-api
Add a Talk API for OCP
2022-02-04 09:54:13 +01:00
Joas Schilling
2f2538a57a
Merge pull request #30888 from nextcloud/comments-interface
Update ICommentsManager with reaction methods
2022-02-04 09:38:04 +01:00
Christoph Wurst
2c356d0852
Add a Talk API for OCP
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-04 08:53:18 +01:00
Vitor Mattos
8ec7c5c8ae
Update ICommentsManager with reaction methods
Fix psalm errors
Reorder methods and remove return null
Use best pattern on docblock

Goals: update https://github.com/ChristophWurst/nextcloud_composer/ with reaction methods.
The script
https://github.com/ChristophWurst/nextcloud_composer/blob/master/build.sh
only get lib/public classes

Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-02-03 12:52:18 -03:00
Robin Appelman
c712987878
send request id in response header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-01 14:24:01 +01:00
Joas Schilling
e8c66d0f89
Merge pull request #30794 from nextcloud/techdebt/noid/allow-to-get-comments-with-verb
Allow to get comments with a given set of verbs
2022-01-28 16:41:42 +01:00
Joas Schilling
429380337f
Fix fake manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 14:02:34 +01:00
Vitor Mattos
7bb01b6ccc
Refactor and fixes on tests
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:40:29 -03:00
Vitor Mattos
b9f74584a1
Fix check after change from string to mb_string
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:41 -03:00
Joas Schilling
189f9f96ce
Limit the summary and sort it afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 -03:00
Vitor Mattos
f7cd995612
Order the reaction summary, improvements on validations
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 -03:00
Vitor Mattos
1ce894a50c
Disable reactions if database don't support utf8mb4
Fix column size

Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:37 -03:00
Vitor Mattos
52affa9ddd
Skip if dont support 4 bytes UTF8
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:07 -03:00
Vitor Mattos
b6d9e0542d
Fix column size to work with Oracle. Add unit tests
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 -03:00
Vitor Mattos
425b5cf081
Add unit tests
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 -03:00
Vitor Mattos
afe5b6dd8a
Prevent query error when use subquery
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 -03:00