mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
23,159 Commits 194 Branches 287 Tags 562 MiB
de757bcdfb
Commit Graph

23159 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Camila Ayres
de757bcdfb chore(migration): remove duplicated code when copying legacy config to new path. 
Signed-off-by: Camila Ayres <hello@camilasan.com>
 2025-04-15 20:47:11 +00:00
Jyrki Gadinger
2bcb322cc3
Merge pull request #8166 from nextcloud/backport/8160/stable-3.16 
[stable-3.16] fix(msi): allow custom installation directory
 2025-04-15 16:49:51 +02:00
Jyrki Gadinger
f8f1d27d19 fix(msi): allow custom installation directory 
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
 2025-04-15 14:36:02 +00:00
Jyrki Gadinger
1f13988015
Merge pull request #8162 from nextcloud/backport/8156/stable-3.16 
[stable-3.16] fix(theme): correct dark/light mode check on Win10
 2025-04-15 14:59:41 +02:00
Jyrki Gadinger
c9f0f4263e fix(theme): correct dark/light mode check on Win10 
`Utility::registryGetKeyValue` returns an invalid QVariant should the
key not exist -- which is the case if that switch has never been toggled
before.

--> Fix this by ensuring the QVariant is valid, and only then try to
convert it to a bool.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
 2025-04-15 14:26:53 +02:00
Jyrki Gadinger
3baee2efa1
Merge pull request #8159 from nextcloud/backport/5543/stable-3.16 
[stable-3.16] Use AccountPtr in Account signals instead of raw pointer
 2025-04-15 14:26:43 +02:00
Claudio Cambra
5944d80c88 fix(gui): Use AccountPtr in setup wizard 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 14:13:34 +02:00
Claudio Cambra
4d1d351d75 Fix use of saveAccount in networksettings 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 14:13:34 +02:00
Claudio Cambra
9da26d79bb Use AccountPtr in testpushnotifications 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 14:13:34 +02:00
Claudio Cambra
ecf5c113a8 Use AccountPtr in serverVersionChanged signal instead of raw pointer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 14:13:34 +02:00
Claudio Cambra
761d035766 Replace use of raw pointer in wantsAccountSaved signal with AccountPtr 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 14:13:34 +02:00
Claudio Cambra
df6ec7baaa Emit AccountPtr from pushNotificationsDisabled in Account rather than raw pointer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 14:13:34 +02:00
Claudio Cambra
536b032a03 Use AccountPtr in pushNotificationsReady signal in Account rather than raw pointer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 14:13:34 +02:00
Jyrki Gadinger
9929b4695e
Merge pull request #8158 from nextcloud/backport/5288/stable-3.16 
[stable-3.16] Exclude NavigationPaneHelper from non-Windows compile
 2025-04-15 14:12:55 +02:00
Claudio Cambra
b794a3b3d3 Only build NavigationPaneHelper on Windows 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 13:59:22 +02:00
Claudio Cambra
62e468fdbc Ifdef all mentions of navigationpanehelper out of non-Windows builds 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2025-04-15 13:59:22 +02:00
Jyrki Gadinger
2147a6c0ad
Merge pull request #8163 from nextcloud/backport/8038/stable-3.16 
[stable-3.16] skip single test or whole test file for macOS: they are broken
 2025-04-15 13:59:05 +02:00
Matthieu Gallien
abd4cf5252 skip single test or whole test file for macOS: they are broken 
would need careful analyze to fix those

until we can get them fixed, better make the other tests be required in
the CI

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-15 13:44:51 +02:00
Jyrki Gadinger
1a3930315a
Merge pull request #8157 from nextcloud/backport/8111/stable-3.16 
[stable-3.16] fix(PinState): don't trigger sync when file's PinState changed to Unspecified.
 2025-04-15 13:44:05 +02:00
Camila Ayres
f4146a621b test(cfapi): check for spurious attribute changes. 
Signed-off-by: Camila Ayres <hello@camilasan.com>
 2025-04-15 08:30:25 +00:00
Camila Ayres
38b71912fb fix(PinState): don't trigger sync when file's PinState changed to Unspecified. 
LibreOffice/Microsoft office might touch the files for unknown reasons,
creating a constant sync state (icon) visible in the parent folder.

This fix excludes PinState changes from a new sync if the trigger
might have been an external application.

Signed-off-by: Camila Ayres <hello@camilasan.com>
 2025-04-15 08:30:24 +00:00
Nextcloud bot
5fbafd458a
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2025-04-15 03:07:07 +00:00
Matthieu Gallien
77ea21aa9a
Merge pull request #8153 from nextcloud/backport/8145/stable-3.16 
[stable-3.16] simplify deletions of invalid read-only items: do not interrupt sync
 2025-04-14 18:59:59 +02:00
Matthieu Gallien
1a5d043f79 fix: do not interrupt sync when cleaning invalid read-only items 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-14 16:38:43 +00:00
Nextcloud bot
d719d94c08
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2025-04-14 03:03:14 +00:00
Nextcloud bot
0ef7cb9dbc
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2025-04-13 03:03:54 +00:00
Nextcloud bot
79346911ba
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2025-04-12 03:05:50 +00:00
Nextcloud bot
3c2cdd68ad
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2025-04-11 03:04:51 +00:00
Matthieu Gallien
d1a591ae31
Merge pull request #8141 from nextcloud/backport/8140/stable-3.16 
[stable-3.16] disable use of bulk upload for small files
 2025-04-10 17:13:54 +02:00
Matthieu Gallien
f0a9c5a302 disable use of bulk upload for small files 
this feature causes many issues with impact on users so we prefer to
disable it again

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:56:34 +00:00
Matthieu Gallien
3a96497389
Merge pull request #8139 from nextcloud/backport/8048/stable-3.16 
[stable-3.16] Bugfix/slow bulk upload
 2025-04-10 15:09:50 +02:00
Matthieu Gallien
b352ab545e
simple way to add more logs related to upload progress 
will be important to try to see upload performance bottlenecks

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:41 +02:00
Matthieu Gallien
937e1df1f5
clean up some no longer needed logs 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:41 +02:00
Matthieu Gallien
10ad077807
better logs to track sending of data during bulk upload 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:41 +02:00
Matthieu Gallien
c31bcc4cd4
clean code and logs during bulk upload 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:41 +02:00
Matthieu Gallien
39cf125c17
no need to disable buffering from Qt in POST requests 
data of the files are ready in a memory buffer so Qt will not buffer
them anyway

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:41 +02:00
Matthieu Gallien
b0067c3988
use maximum chunk size to decide the size of a bulk upload request 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:41 +02:00
Matthieu Gallien
5b9284237a
remove useless log 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:40 +02:00
Matthieu Gallien
c74765a931
define content length header with bulk upload requests 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:40 +02:00
Matthieu Gallien
2ed48e9c7d
use memory to buffer the data of the files sent during bulk upload 
should help make it faster to send all data

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:40 +02:00
Matthieu Gallien
f84d41b9bf
disable buffering when POSTing for bulk upload 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 14:55:40 +02:00
Camila Ayres
454a7a5768
Add test for syncing with bulk upload when there are errors. 
Signed-off-by: Camila Ayres <hello@camilasan.com>
 2025-04-10 14:54:13 +02:00
Camila
c7cffd9b56
Change bulk upload batch size when there is a sync error. 
- Cancel sync after try with smaller bulk upload batch size also throws error.
- Continue syncing when there is no error.
- Remove file from bulk upload black list only when upload succeeded.

Signed-off-by: Camila <hello@camila.codes>
 2025-04-10 14:54:13 +02:00
Matthieu Gallien
493e234e8f
Merge pull request #8137 from nextcloud/backport/8094/stable-3.16 
[stable-3.16] Bugfix/use newer bulk upload checksum header
 2025-04-10 14:37:34 +02:00
Matthieu Gallien
ec0e2d6ce0 only send the md5 custom checksum header when server expects it 
server before 32.0.0 release expects a custom header with an MD5
checksum during bulk upload

the header name is: X-File-MD5

see https://github.com/nextcloud/server/pull/51729

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 09:31:04 +00:00
Matthieu Gallien
89a0af11fa with release 32.0.0 md5 custom checksum is removed from bulkupload 
makes our fake server require an md5 custom checksum for bulk upload
until version 32.0.0

starting with 32.0.0 this custom checksum must be empty

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 09:31:04 +00:00
Matthieu Gallien
c67469e044 fix format of checksum header that was missing checksum type 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 09:31:04 +00:00
Matthieu Gallien
a287326f8f sending header X-File-MD5 that is currently mandatory 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 09:31:03 +00:00
Matthieu Gallien
84247296d8 automated tests of bulk upload needs to check checksums like real 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2025-04-10 09:31:03 +00:00
Nextcloud bot
fbb6df023b
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2025-04-10 03:03:42 +00:00