Commit Graph

10593 Commits

Author SHA1 Message Date
Jyrki Gadinger
bf6b3ca7ae fix apps menu not closing when the window is hidden, and make group folders menu work again
this change resolves this ReferenceError when the window is being closed:
```
2025-01-08 10:56:40:389 [ warning default qrc:/qml/src/gui/tray/MainWindow.qml:100 ]:   qrc:/qml/src/gui/tray/MainWindow.qml💯 ReferenceError: appsMenu is not defined
```

I also noticed that the "Open local or group folders" dropdown menu
wouldn't show up due to this error:
```
2025-01-08 10:56:23:327 [ warning default qrc:/qml/src/gui/tray/TrayFoldersMenuButton.qml:33 ]: qrc:/qml/src/gui/tray/TrayFoldersMenuButton.qml:33: Error: Cannot call method QQuickPopup::open on QQuickLoader_QML_48(0x5569fb4648d0)
```
--> wrapped the calls to the open/close methods in a closure

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-01-08 10:55:47 +01:00
Jyrki Gadinger
19eab9d569 remove old vim swap file
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-01-08 10:55:21 +01:00
Claudio Cambra
0daec76aee Use dark palette colour for secondary text
Improves readability in dark mode

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-07 10:56:37 +01:00
Claudio Cambra
b89bd88f98 Replace use of midlight palette colour for secondary text with mid colour
Improves visibility

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-07 10:56:37 +01:00
Joshua Noeske
80b6d0e961 Make extraction of ETag header independent of capitalisation.
Fixes #7703.

Signed-off-by: Joshua Noeske <git@joshuanoeske.de>
2025-01-07 09:38:12 +01:00
Matthieu Gallien
2701a3c9f4 ensure proper read write access to root folder and db files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-01-07 08:45:16 +01:00
Matthieu Gallien
6f8a40f73e prevent implicit hydration when checking PIN state
to enable move to trash, we check availability of a folder recursively

that will trigger implicit hydration of its content

we will now prevent moving to trash for VFS CfApi native VFS on Windows

will fix teh bug and probably be much more robust and reliable

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-01-03 17:14:28 +01:00
Matthieu Gallien
f12f66f4e6 fix code style
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-01-03 17:14:28 +01:00
Matthieu Gallien
3f49361712 force dehydratation of lnk files when vfs metadata are wrong
Close #7696

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-01-03 17:14:28 +01:00
Fredrik Eriksson
65db9a0253 Fix index check
Also fixes handling of empty netrc.

Signed-off-by: Fredrik Eriksson <feffe@fulh.ax>
2025-01-03 14:46:33 +01:00
Fredrik Eriksson
38f1d05636 Fix .netrc parsing
Fixes: #7177
Signed-off-by: Fredrik Eriksson <feffe@fulh.ax>
2025-01-03 14:46:33 +01:00
kleifgch
5d36070d15 Call setDesktopFileName without .desktop suffix
As clarified in [1], the method expects to be called without the suffix.

[1] 0c5135a9df

Signed-off-by: kleifgch <81602214+kleifgch@users.noreply.github.com>
2025-01-02 11:57:13 +01:00
Camila Ayres
d9e42e7ad1 Remove assert for when the timestamp is not empty.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-01-02 11:33:37 +01:00
Camila Ayres
c3a7306b2d Remove extra \n.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-01-02 11:02:34 +01:00
Camila Ayres
932a223f59 Use Qt::ElideRight.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-01-02 11:02:34 +01:00
Matthieu Gallien
b2b5fb793c ensure no crash due to uncatched exception from std c++ lib
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-01-02 10:20:27 +01:00
Matthieu Gallien
1f32d1f9d7 prevent crash by catching more exception types from c++ std lib
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-01-02 10:20:27 +01:00
Claudio Cambra
f2182ad9cf Use non-deprecated qChecksum in qtlocalpeer of qtsingleapplication
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
b2a70435c8 Use QDomDocument content method returning ParseResult
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use ParseResult returning QDomDocument setContent

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f parseresult

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
4f2223b582 Replace QWebSocket::error with errorOccurred
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
f2d49f5591 Use std::prev ove -1ing the iterator
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use std::prev for it rather than -1 in Syncengine

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
87b6b3cfbd Use matchView instead of match
match is deprecated

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
7d9077c9a9 Use unique_ptr over scoped pointer
take is deprecated in scoped pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f handle

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use unique_ptr instead of scoped pointer for propagator firstJob

Fixes deprecation warning

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use unique_ptr for discoveryphase, replace take with release

Fix deprecation warn

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f unique

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
4bfc155e5f Use char16_t cast instead of ushort cast
Fix deprecation warning

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
3e1bdf7412 Replace deprecated QVariant types with QMetaType
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use QVariant metaType instead of type

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f metatype

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
0da3c6d3b9 Do not use const char * to add data to crypto hash
method is deprecated

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix qbyte

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
00b616ba9d Remove unneeded take from systray
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
d66e5bfc99 Use QTimeZone::UTC instead of Qt::UTC
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f qtimezone

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
8425f2e3c5 Replace use of QCheckBox::stateChanged with QCheckBox::checkStateChanged
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
85e8aff5d8 Replace use of itemDelegate with itemDelegateForIndex
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
fdf0ec5137 Replace use of deprecated QLibraryInfo::location with QLibraryInfo::path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
30ee3d65ee Ensure use of QMessageBox-using QMessageBox::critical
Fixes deprecation warnings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f ensure qmessagebox

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f2 ensure qm

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f3

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f4

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Claudio Cambra
1009fed86a Replace all uses of qAsConst with std::as_const
Fixes deprecation warnings on Qt 6.8.0

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Matthieu Gallien
5d2ee18886 remove deprecated API
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-12-16 16:15:40 +01:00
Matthieu Gallien
321c583b69 allow dehydrating pinned LNK files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-12-16 16:15:40 +01:00
xjzsq
3dfba6bf79 Fix a bug preventing sync root in folder on drive roots
Fixes: <https://github.com/nextcloud/desktop/issues/7658>

Signed-off-by: xjzsq <sdxjzsq@126.com>
2024-12-16 15:10:07 +01:00
Rello
a5d1070c4b
Update src/gui/folderman.cpp
Co-authored-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
2024-12-16 11:06:05 +01:00
Rello
bb49203128
improvement of error message
Signed-off-by: Rello <Rello@users.noreply.github.com>
2024-12-16 10:41:53 +01:00
rakekniven
d92b31b661
chore(i18n): Corrected spelling and improved grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-12-13 08:15:21 +01:00
Camila Ayres
d3d7963dc0 All conditions must be true to use virtual files in the selected location.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-12-12 12:15:44 +01:00
Camila Ayres
7581f29201 Add [[nodiscard]] to functions.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-12-12 12:15:44 +01:00
Camila Ayres
f9ec7380b0 Remove unused variable.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-12-12 12:15:44 +01:00
Hannah von Reth
cb05cedd10 Warn if we encounter an unsupported configuration 2024-12-12 12:15:44 +01:00
Hannah von Reth
47132d3beb Fix crash on missing sync root
Fixes: #9016
2024-12-12 12:15:44 +01:00
Hannah von Reth
0fa84e960f Fix network drive detection
We can't rely on the file system detection because Windows is reporting the underlying file system.

Fixes: #8272
2024-12-12 12:15:44 +01:00
Camila Ayres
90bcf65ee6 Include folders when displaying the local metadata about a conflict.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-12-12 10:47:14 +01:00
Matthieu Gallien
be85f3c1ec optionally install PDB files when building them
would allow installing PDB files when doing Windows builds producing
debug symbols

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-12-12 10:08:15 +01:00
Matthieu Gallien
a8021a2dff
use modern non deprecated hash algorithm and parameters
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-12-12 10:02:51 +01:00
Matthieu Gallien
ae0203c462 dehydrate placeholder files using CfDehydratePlaceholder
might be enough to get this working reliably

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-12-11 14:47:00 +01:00
Matthieu Gallien
6310e3e645 improve definition of MIRALL_VERSION_SUFFIX and MIRALL_VERSION_BUILD
should allow ompiling with MIRALL_VERSION_SUFFIX be empty

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-12-11 11:07:28 +01:00