mirror of
https://github.com/nextcloud/desktop.git
synced 2025-10-26 11:17:43 +00:00
fix apps menu not closing when the window is hidden, and make group folders menu work again
this change resolves this ReferenceError when the window is being closed:
```
2025-01-08 10:56:40:389 [ warning default qrc:/qml/src/gui/tray/MainWindow.qml:100 ]: qrc:/qml/src/gui/tray/MainWindow.qml💯 ReferenceError: appsMenu is not defined
```
I also noticed that the "Open local or group folders" dropdown menu
wouldn't show up due to this error:
```
2025-01-08 10:56:23:327 [ warning default qrc:/qml/src/gui/tray/TrayFoldersMenuButton.qml:33 ]: qrc:/qml/src/gui/tray/TrayFoldersMenuButton.qml:33: Error: Cannot call method QQuickPopup::open on QQuickLoader_QML_48(0x5569fb4648d0)
```
--> wrapped the calls to the open/close methods in a closure
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
This commit is contained in:
parent
19eab9d569
commit
bf6b3ca7ae
@ -100,8 +100,8 @@ ApplicationWindow {
|
||||
|
||||
if (Systray.isOpen) {
|
||||
trayWindowHeader.currentAccountHeaderButton.accountMenu.close();
|
||||
appsMenu.close();
|
||||
openLocalFolderButton.closeMenu()
|
||||
trayWindowHeader.appsMenu.close();
|
||||
trayWindowHeader.openLocalFolderButton.closeMenu()
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@ -222,8 +222,8 @@ HeaderButton {
|
||||
}
|
||||
|
||||
Component.onCompleted: {
|
||||
foldersMenuLoader.openMenu = open
|
||||
foldersMenuLoader.closeMenu = close
|
||||
foldersMenuLoader.openMenu = function() { open() }
|
||||
foldersMenuLoader.closeMenu = function() { close() }
|
||||
}
|
||||
|
||||
Connections {
|
||||
|
||||
@ -26,6 +26,8 @@ Rectangle {
|
||||
id: root
|
||||
|
||||
readonly property alias currentAccountHeaderButton: currentAccountHeaderButton
|
||||
readonly property alias openLocalFolderButton: openLocalFolderButton
|
||||
readonly property alias appsMenu: appsMenu
|
||||
|
||||
color: Style.currentUserHeaderColor
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user