Jyrki Gadinger
c139f91145
Merge pull request #8465 from nextcloud/bugfix/remote-wipe
...
fix(remotewipe): do not reopen sync db before wiping
2025-07-29 11:53:46 +02:00
Jyrki Gadinger
679dcbe6dd
fix(filesystem): avoid multiple directory separators when joining paths
...
On Windows using paths prefixed with `\\?\` to allow using long file
names require the rest of the path to be valid, a path like
`\\?\C:\Users\\jyrki` will fail in different ways...
This helps with making setting/removing permission ACLs more reliable.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-29 10:30:18 +02:00
Jyrki Gadinger
7d51761a7a
fix(remotewipe): do not reopen sync db before wiping
...
also use `FileSystem::removeRecursively` to properly handle deletion of
read-only directories/files
There's now an integration test for this feature after all those years
as well ;-)
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-29 10:30:18 +02:00
Camila Ayres
6fbe162370
Merge pull request #8490 from nextcloud/cmd-env-vars
...
adds ability to specify user and password via env variables
2025-07-29 10:18:31 +02:00
Camila Ayres
c7689e7545
fix(cmd): use qgetenv.
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-29 09:16:07 +02:00
bonni
6abd4c70c4
Revert "Merge branch 'cmd-env-vars' of github.com:internet-memme/nc-desktop into cmd-env-vars"
...
This reverts commit e2e3c92bc3fa9a9a4e9b0fec6954f4aec7e418e7, reversing
changes made to def7b65d122f93d58d1f41268247d2de8206f27f.
2025-07-29 09:16:07 +02:00
bonni
4d02d0b3ac
reads env vars in --non-interactive
...
Signed-off-by: bonni <post@bonni.codes>
Signed-off-by: internet-memme <142409719+internet-memme@users.noreply.github.com>
Co-authored-by: Claudio Cambra <developer@claudiocambra.com>
2025-07-29 09:15:25 +02:00
Nextcloud bot
c9879c2a34
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-29 02:51:19 +00:00
Camila Ayres
be39eeb258
Merge pull request #8458 from nextcloud/bugfix/links
...
Rename fav links
2025-07-28 17:10:21 +02:00
Camila Ayres
55e89a4ec2
fix(folder): don't display username in folder when there is only one account.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-28 15:23:25 +02:00
Camila Ayres
ec74f8d274
fix(folder): rename VFS folders using same pattern of sync folders.
...
- Migrate vfs mode from config and load cfapi plugin for the folder.
- Move rename logic to Utility class.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-28 15:23:25 +02:00
Camila Ayres
1cc9f689c4
feat(utility): migrate fav links.
...
Add helper function to get path to links folder.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-28 15:23:25 +02:00
Camila Ayres
4b7ef6eab7
fix(application): add folders after accounts are created during migration.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-28 15:23:22 +02:00
Camila Ayres
abe58a6640
fix(navigationpane): check for unbranded application name when removing registry entries.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-28 14:11:56 +02:00
Camila Ayres
cd8cf2635b
feat(navigationpane): use url - account for root folder, folder name for the rest.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-28 14:11:55 +02:00
Camila Ayres
5044c90ba0
Merge pull request #8467 from nextcloud/create-pr-for-patch-to-cmakelists-and-account-manager
...
Add legacy account selection dialog.
2025-07-28 14:09:29 +02:00
Rello
be6c34d0e4
chore: add SPDX headers
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-28 12:01:04 +02:00
Rello
cb78bdd075
feat: add legacy account selection dialog.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-28 12:01:04 +02:00
Nextcloud bot
ff5e8659d3
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-28 02:52:35 +00:00
Nextcloud bot
0ce8bd4ab8
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-26 02:52:22 +00:00
Rello
b24a6e9e26
Merge pull request #8486 from nextcloud/perf/sync-improvements
...
perf(activitylistmodel): store conflicts in a separate list
2025-07-25 13:02:31 +02:00
Jyrki Gadinger
88cfbcafea
perf(activitylistmodel): store conflicts in separate list
...
Figuring out whether a sync conflict occurred by iterating through the
entire activity list each time a new activity was added is really slow,
even more so when there already are thousands of previous activities.
This was especially noticeable during complete initial full syncs
involving more than ~5000 files.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-25 12:10:52 +02:00
Jyrki Gadinger
34876bf130
perf(activitylistmodel): avoid creation of temporary Activity objects
...
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-25 12:10:52 +02:00
Nextcloud bot
f9c813d6f2
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-25 02:51:02 +00:00
Jyrki Gadinger
d3c31e613e
Merge pull request #8450 from nextcloud/bugfix/implicitHydrationDoNotAbortSync
...
fix: implicit hydration will not abort synchronization
2025-07-24 12:59:39 +02:00
Matthieu Gallien
ff7109e61b
fix: implicit hydration will not abort synchronization
...
should avoid constant sync/abort loop for people having many files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-07-24 11:11:18 +02:00
Nextcloud bot
34082271b6
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-24 02:53:38 +00:00
Nextcloud bot
d6995e89a8
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-23 03:00:31 +00:00
Jyrki Gadinger
8d811888dd
Merge pull request #8477 from nextcloud/bugfix/mac-crafter-asyncparsablecommand
...
fix(mac-crafter): use AsyncParsableCommand everywhere
2025-07-22 11:06:09 +02:00
Jyrki Gadinger
5ca272cb49
fix(mac-crafter): use AsyncParsableCommand everywhere
...
For some reason using `ParsableCommand` structs as subcommands of an
`AsyncParsableCommand` does not correctly handle all passed CLI
arguments.
The behaviour before this commit was as follows:
```
% mac-crafter create-dmg
Error: Missing expected argument '<app-bundle-path>'
Help: <app-bundle-path> Path to the desktop client app bundle.
Usage: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]
See 'mac-crafter create-dmg --help' for more information.
% mac-crafter create-dmg /tmp/Nextcloud.app
OVERVIEW: Create a DMG for the client.
USAGE: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]
ARGUMENTS:
<app-bundle-path> Path to the desktop client app bundle.
[...]
```
After changing every command struct to derive from
`AsyncParsableCommand`:
```
% mac-crafter create-dmg
Error: Missing expected argument '<app-bundle-path>'
Help: <app-bundle-path> Path to the desktop client app bundle.
Usage: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]
See 'mac-crafter create-dmg --help' for more information.
% mac-crafter create-dmg /tmp/Nextcloud.app
Required command "create-dmg" is missing, installing...
[...]
```
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-22 09:49:22 +02:00
Nextcloud bot
fe2861dacc
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-22 03:04:44 +00:00
Jyrki Gadinger
644d6a20c7
Merge pull request #8474 from nextcloud/xcode-debugger-enablement
...
Enable Xcode Debugger
2025-07-21 15:42:51 +02:00
Iva Horn
99e760363a
fix(macOS): Enable debugger to attach to process.
...
- Disable hardened runtime for debug builds.
- Add required get-task-allow entitlement conditionally.
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-07-21 14:11:16 +02:00
Jyrki Gadinger
3a2ec9927b
Merge pull request #8475 from nextcloud/ci/appimage-builds
...
ci: change download url of appimagetool
2025-07-21 14:07:57 +02:00
Jyrki Gadinger
e0ba1db826
ci: change download url of appimagetool
...
The appimagetool as previously provided from the AppImageKit repo was
deprecated and removed.
The new versions as provided by the appimagetool repository also ship
with an updated runtime which from my understanding improve
compatibility (e.g. libfuse is now statically linked, so systems don't
need to have it present) and seem to slightly reduce the binary size as
well.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-21 13:09:53 +02:00
Nextcloud bot
78b8c59f70
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-21 04:47:24 +00:00
Nextcloud bot
13e7468344
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-20 02:59:31 +00:00
Matthieu Gallien
fe8923ccd8
Merge pull request #8466 from nextcloud/Rello-codex/exclude-----from-ignore-list-evaluation
...
ignore list evaluation
2025-07-18 09:23:58 +02:00
Matthieu Gallien
1a710eac1d
fix: simplify code reverting to the original version
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2025-07-18 08:48:34 +02:00
Matthieu Gallien
5f57734e87
fix: use proper type of string view
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2025-07-18 08:48:34 +02:00
Rello
0ccba7edfb
fix(ignore-list): skip star pattern
...
Signed-off-by: Rello <Rello@users.noreply.github.com>
2025-07-18 08:48:34 +02:00
Nextcloud bot
d5c7d113f4
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-18 03:14:09 +00:00
Jyrki Gadinger
88abb326fb
Merge pull request #8456 from nextcloud/bugfix/improvePermissionsChangeWithoutEtagChange
...
fix: do not recurse inside a remote folder when etag did not change
2025-07-17 09:32:33 +02:00
Matthieu Gallien
0a3a29f832
fix: do not recurse inside a remote folder when etag did not change
...
we do not want to remote discover a folder just because the permissions
are modified but not the etag
for any valid case, etag must change
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-07-17 08:57:34 +02:00
Matthieu Gallien
98061f71d9
feat: test to ensure etag constant means no PROPFIND on a folder
...
should help ensure we send a PROPFIND only when the folder etag changes
if some metadata apparently change, this is not enough to send a
PROPFIND request
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-07-17 08:57:34 +02:00
Nextcloud bot
e281f72bf2
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-17 02:50:33 +00:00
Matthieu Gallien
c7cd3585d3
Merge pull request #7951 from nextcloud/feature/rmglobalnetwork
...
Removes global network settings
2025-07-16 19:21:48 +02:00
Camila Ayres
56e3b284c1
feat: migrate global network settings to account specific network settings.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-16 19:21:37 +02:00
Camila Ayres
e591644914
feat: all proxy settings are account specific settings.
...
The default is to use QNetworkProxy::NoProxy.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-16 19:21:37 +02:00
Camila Ayres
1696549a83
feat: remove "Network" action.
...
- Remove global proxy and network options from UI.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-16 19:21:37 +02:00