Jyrki Gadinger
88cfbcafea
perf(activitylistmodel): store conflicts in separate list
...
Figuring out whether a sync conflict occurred by iterating through the
entire activity list each time a new activity was added is really slow,
even more so when there already are thousands of previous activities.
This was especially noticeable during complete initial full syncs
involving more than ~5000 files.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-25 12:10:52 +02:00
Jyrki Gadinger
34876bf130
perf(activitylistmodel): avoid creation of temporary Activity objects
...
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-25 12:10:52 +02:00
Nextcloud bot
f9c813d6f2
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-25 02:51:02 +00:00
Jyrki Gadinger
d3c31e613e
Merge pull request #8450 from nextcloud/bugfix/implicitHydrationDoNotAbortSync
...
fix: implicit hydration will not abort synchronization
2025-07-24 12:59:39 +02:00
Matthieu Gallien
ff7109e61b
fix: implicit hydration will not abort synchronization
...
should avoid constant sync/abort loop for people having many files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-07-24 11:11:18 +02:00
Nextcloud bot
34082271b6
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-24 02:53:38 +00:00
Nextcloud bot
d6995e89a8
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-23 03:00:31 +00:00
Jyrki Gadinger
8d811888dd
Merge pull request #8477 from nextcloud/bugfix/mac-crafter-asyncparsablecommand
...
fix(mac-crafter): use AsyncParsableCommand everywhere
2025-07-22 11:06:09 +02:00
Jyrki Gadinger
5ca272cb49
fix(mac-crafter): use AsyncParsableCommand everywhere
...
For some reason using `ParsableCommand` structs as subcommands of an
`AsyncParsableCommand` does not correctly handle all passed CLI
arguments.
The behaviour before this commit was as follows:
```
% mac-crafter create-dmg
Error: Missing expected argument '<app-bundle-path>'
Help: <app-bundle-path> Path to the desktop client app bundle.
Usage: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]
See 'mac-crafter create-dmg --help' for more information.
% mac-crafter create-dmg /tmp/Nextcloud.app
OVERVIEW: Create a DMG for the client.
USAGE: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]
ARGUMENTS:
<app-bundle-path> Path to the desktop client app bundle.
[...]
```
After changing every command struct to derive from
`AsyncParsableCommand`:
```
% mac-crafter create-dmg
Error: Missing expected argument '<app-bundle-path>'
Help: <app-bundle-path> Path to the desktop client app bundle.
Usage: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]
See 'mac-crafter create-dmg --help' for more information.
% mac-crafter create-dmg /tmp/Nextcloud.app
Required command "create-dmg" is missing, installing...
[...]
```
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-22 09:49:22 +02:00
Nextcloud bot
fe2861dacc
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-22 03:04:44 +00:00
Jyrki Gadinger
644d6a20c7
Merge pull request #8474 from nextcloud/xcode-debugger-enablement
...
Enable Xcode Debugger
2025-07-21 15:42:51 +02:00
Iva Horn
99e760363a
fix(macOS): Enable debugger to attach to process.
...
- Disable hardened runtime for debug builds.
- Add required get-task-allow entitlement conditionally.
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-07-21 14:11:16 +02:00
Jyrki Gadinger
3a2ec9927b
Merge pull request #8475 from nextcloud/ci/appimage-builds
...
ci: change download url of appimagetool
2025-07-21 14:07:57 +02:00
Jyrki Gadinger
e0ba1db826
ci: change download url of appimagetool
...
The appimagetool as previously provided from the AppImageKit repo was
deprecated and removed.
The new versions as provided by the appimagetool repository also ship
with an updated runtime which from my understanding improve
compatibility (e.g. libfuse is now statically linked, so systems don't
need to have it present) and seem to slightly reduce the binary size as
well.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-21 13:09:53 +02:00
Nextcloud bot
78b8c59f70
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-21 04:47:24 +00:00
Nextcloud bot
13e7468344
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-20 02:59:31 +00:00
Matthieu Gallien
fe8923ccd8
Merge pull request #8466 from nextcloud/Rello-codex/exclude-----from-ignore-list-evaluation
...
ignore list evaluation
2025-07-18 09:23:58 +02:00
Matthieu Gallien
1a710eac1d
fix: simplify code reverting to the original version
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2025-07-18 08:48:34 +02:00
Matthieu Gallien
5f57734e87
fix: use proper type of string view
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2025-07-18 08:48:34 +02:00
Rello
0ccba7edfb
fix(ignore-list): skip star pattern
...
Signed-off-by: Rello <Rello@users.noreply.github.com>
2025-07-18 08:48:34 +02:00
Nextcloud bot
d5c7d113f4
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-18 03:14:09 +00:00
Jyrki Gadinger
88abb326fb
Merge pull request #8456 from nextcloud/bugfix/improvePermissionsChangeWithoutEtagChange
...
fix: do not recurse inside a remote folder when etag did not change
2025-07-17 09:32:33 +02:00
Matthieu Gallien
0a3a29f832
fix: do not recurse inside a remote folder when etag did not change
...
we do not want to remote discover a folder just because the permissions
are modified but not the etag
for any valid case, etag must change
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-07-17 08:57:34 +02:00
Matthieu Gallien
98061f71d9
feat: test to ensure etag constant means no PROPFIND on a folder
...
should help ensure we send a PROPFIND only when the folder etag changes
if some metadata apparently change, this is not enough to send a
PROPFIND request
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-07-17 08:57:34 +02:00
Nextcloud bot
e281f72bf2
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-17 02:50:33 +00:00
Matthieu Gallien
c7cd3585d3
Merge pull request #7951 from nextcloud/feature/rmglobalnetwork
...
Removes global network settings
2025-07-16 19:21:48 +02:00
Camila Ayres
56e3b284c1
feat: migrate global network settings to account specific network settings.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-16 19:21:37 +02:00
Camila Ayres
e591644914
feat: all proxy settings are account specific settings.
...
The default is to use QNetworkProxy::NoProxy.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-16 19:21:37 +02:00
Camila Ayres
1696549a83
feat: remove "Network" action.
...
- Remove global proxy and network options from UI.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-07-16 19:21:37 +02:00
Matthieu Gallien
2527a30fd5
Merge branch 'Rello-codex/add-logging-to-missing-cfapicallback-functions'
2025-07-16 17:41:43 +02:00
Matthieu Gallien
9712fe221c
fix: use proper categorized logging
...
Co-authored-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2025-07-16 17:40:44 +02:00
Matthieu Gallien
ffc5d7653f
fix: use proper categorized logging
...
Co-authored-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2025-07-16 17:40:34 +02:00
Rello
2492c0548a
fix: Add consistent logging to CFAPI callbacks
...
Signed-off-by: Rello <Rello@users.noreply.github.com>
2025-07-16 17:39:20 +02:00
Matthieu Gallien
1f49f4a024
Merge pull request #8389 from nextcloud/Rello-patch-1
...
fix(startup) respect update checker during startup in macOS
2025-07-16 17:15:11 +02:00
Rello
0747d0053d
fix(startup) respect update checker during startup in macOS
...
fixes https://github.com/nextcloud/desktop/issues/8029
Signed-off-by: Rello <Rello@users.noreply.github.com>
2025-07-16 17:14:59 +02:00
Matthieu Gallien
4d111921b8
Merge pull request #8457 from nextcloud/mac-crafter-swift6
...
Updated mac-crafter to Swift 6
2025-07-16 17:12:18 +02:00
Iva Horn
472684cf2e
fix(mac-crafter): Checked in Package.resolved.
...
- mac-crafter is an executable application, not a library
- Ensures all developers use identical dependency versions
- Provides reproducible builds across different environments
- Prevents "works on my machine" dependency issues
- Critical for production deployment consistency
- Enables reliable CI/CD builds with same dependency versions
- Helps with debugging by ensuring same versions across dev/test/prod
- Standard practice for applications vs libraries which should remain flexible
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-07-16 16:15:33 +02:00
Iva Horn
5f3c381617
fix(mac-crafter): Updated .gitignore to not exclude source code files expected to be checked in.
...
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-07-16 16:15:33 +02:00
Iva Horn
6b8828537f
feat(doc): Minor improvements to root README.
...
- Moved hint about mac-crafter further up where it already becomes relevant for contributors in macOS before they work through the unnecessary steps now below it.
- Moved hint about system requirements above list of requirements to not interrupt the reading flow.
- Fixed spelling of macOS mentions.
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-07-16 14:23:25 +02:00
Iva Horn
c898525d74
feat(mac-crafter): Added instructions to README on how to run and debug mac-crafter from Xcode.
...
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-07-16 14:23:25 +02:00
Iva Horn
3e27c5f0f7
feat(mac-crafter): Reorganized commands in dedicated source code files for improved developer experience.
...
Had to rename Utils/Codesign.swift to Utils/Codesigning.swift to avoid duplicate module name compiler error.
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-07-16 14:23:25 +02:00
Iva Horn
e93e23f0a7
feat(mac-crafter): Update to Swift 6.1 and Strict Concurrency Checks.
...
- Isolated global state into an actor.
- Updated declarations and calls to reflect asynchronicity.
- The replacement of the enumerator with subpathsOfDirectory(atPath:) was suggested by Copilot to necessarily avoid the use of synchronous enumeration in an asynchronous context.
- Updated README.
Signed-off-by: Iva Horn <iva.horn@icloud.com>
2025-07-16 11:56:55 +02:00
Matthieu Gallien
a334ebc1f1
Merge pull request #8272 from nextcloud/l10n/update-en-source
...
fix(l10n): fix plural forms in source language
2025-07-16 09:28:34 +02:00
Jyrki Gadinger
bb47be6f27
fix(l10n): correct plural forms in source language (en)
...
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-16 09:27:40 +02:00
Nextcloud bot
89c55fbfe2
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-15 02:49:00 +00:00
Nextcloud bot
f559808300
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-14 02:47:27 +00:00
Nextcloud bot
15daf725ad
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-13 02:47:19 +00:00
Jyrki Gadinger
1f4b0b5b26
Merge pull request #8460 from nextcloud/rakekniven-patch-1
...
chore(l10n): Exclude string from translation
2025-07-12 15:25:48 +02:00
rakekniven
af56869ba9
chore(l10n): Exclude string from translation
...
Reported at Transifex
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2025-07-12 14:49:24 +02:00
Nextcloud bot
e877582df6
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-07-12 02:48:18 +00:00