Commit Graph

23071 Commits

Author SHA1 Message Date
Claudio Cambra
697c3080ca gui/macOS: Do not assume accountState will always be valid
When removing an account this can change

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 12:11:22 +01:00
Claudio Cambra
182ff73c84 gui/macOS: Constify methods in file provider socket controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 12:11:22 +01:00
Nextcloud bot
11a2d77b23
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-25 03:06:07 +00:00
Matthieu Gallien
976f8a8a76
Merge pull request #8067 from nextcloud/ci/useCustomWindowsCraftCache
use our own craft cache on windows
2025-03-24 14:39:58 +01:00
Matthieu Gallien
7243742cc2 use our own craft cache on windows
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-24 10:43:08 +01:00
Matthieu Gallien
6818bd056b
Merge pull request #8066 from nextcloud/bugfix/fix-windows-build
fix Windows build
2025-03-24 10:42:58 +01:00
Jyrki Gadinger
0776f42772 fix Windows build
`cl` didn't quite like it:

```
error C2445: result type of conditional expression is ambiguous: types 'QByteArray' and 'const char [1]' can be converted to multiple common types
```

just changing the `auto` to `QByteArray` results in the same compile error

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-24 09:50:21 +01:00
Nextcloud bot
584ee9f26a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-24 03:03:30 +00:00
Nextcloud bot
9d09777381
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-22 03:02:39 +00:00
Nextcloud bot
702efe59a0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-21 03:27:43 +00:00
Matthieu Gallien
b074399491
Merge pull request #8052 from nextcloud/bugfix/sendProperHeaderForChecksumDuringBulkUpload
use standard way to find the checkum type and really send it to server
2025-03-20 14:45:39 +01:00
Matthieu Gallien
18085d899e use standard way to find the checkum type and really send it to server
will fix missing checksum for bulk upload

will ensure consistent behavior between bulk upload, plain old upload
and chunked upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-20 09:13:18 +01:00
Nextcloud bot
0a47e62817
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-20 03:07:28 +00:00
Matthieu Gallien
28710b03ad
Merge pull request #8050 from nextcloud/bugfix/highlightTooBrightAppimage
Bugfix/highlight too bright appimage
2025-03-19 14:11:10 +01:00
Matthieu Gallien
0e346e8d32 try to force the highlight to not be too bright
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-19 14:10:02 +01:00
Matthieu Gallien
28d3936f9c
Merge pull request #8045 from nextcloud/bugfix/header-colours
explicitly set colours for header items
2025-03-19 13:10:41 +01:00
Jyrki Gadinger
0f84c803f8 align status icon display with e.g. Talk more
- status icons have now a white background/border
- "Invisible"/"Offline" icons are now hidden
- UserModel.status property is now available in QML too when needed

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-19 11:57:51 +01:00
Jyrki Gadinger
896cd11963 use colour from Style instead of palette for icons
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-19 11:57:11 +01:00
Jyrki Gadinger
2e321d238f explicitly set colours for header items
the _Universal_ theme notably sets [`icon.color` on `Button`s][0] and
also the [`color` on `Label`s][1], ignoring what's set through the
`palette` property ...

[0]: 215619d71b/src/quickcontrols/universal/Button.qml (L23)
[1]: 215619d71b/src/quickcontrols/universal/Label.qml (L12)

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-19 11:57:05 +01:00
Nextcloud bot
b5c3b08f4a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-19 03:05:53 +00:00
Matthieu Gallien
4e9a94750b
Merge pull request #8041 from nextcloud/bugfix/inputPinTitleTooWide
Bugfix/input pin title too wide
2025-03-18 12:06:44 +01:00
Matthieu Gallien
853f9b7a0c
use a better and shorter title for input dialog for PIN code
we have to make sure the title is short and easy to understand

if it is too long, it will be truncated giving a bad experience for the
user

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-18 11:46:36 +01:00
Matthieu Gallien
ab46047eca
French title for input dialog for PIN is too wide
the whole title is not readable

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-18 11:43:25 +01:00
Matthieu Gallien
1299268c36
Merge pull request #8038 from nextcloud/ci/ignoreFailingTestsOnMacOS
skip single test or whole test file for macOS: they are broken
2025-03-18 10:35:07 +01:00
Matthieu Gallien
2daeaadead
skip single test or whole test file for macOS: they are broken
would need careful analyze to fix those

until we can get them fixed, better make the other tests be required in
the CI

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-18 09:51:16 +01:00
Matthieu Gallien
887232822e
Merge pull request #8033 from nextcloud/bugfix/win10-dark-theme
gui: fix dark mode change on Windows 10 with universal style
2025-03-18 08:54:21 +01:00
Jyrki Gadinger
46ac99b25a gui: fix dark mode change on Windows 10 with universal style
The _Universal_ QML style has a theme that uses the colour scheme from
the system.  This can be set by either configuring
`qtquickcontrols2.conf` or setting the environment variable
`QT_QUICK_CONTROLS_UNIVERSAL_THEME=System`.

Unfortunately, due to [QTBUG-128825], setting the theme in the
configuration file/environment variable results in the dark/light mode
setting only be set during startup, not during runtime.  Not ideal, but
still better than not having a broken dark mode theme at all.

Fixes #7991

[QTBUG-128825]: https://bugreports.qt.io/browse/QTBUG-128825

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-17 15:35:49 +01:00
Matthieu Gallien
ae97206a5b
Merge pull request #8034 from nextcloud/ci/fixWindowsBuild
Ci/fix windows build
2025-03-17 14:20:00 +01:00
Matthieu Gallien
f2461e299d move a destructor to cpp implementation to avoid undefined type error
during compilation, the compiler wil need to generate a destructor

given the type needed is not known in the header (forward declaration),
the destructor cannot be generated

moving to the cpp implementation means that the type is currently known
(not forward declared)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-17 13:45:33 +01:00
Matthieu Gallien
4c07bdfb90 implicit lambda capture of this is deprecated, make it explicit
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-17 12:33:47 +01:00
Claudio Cambra
046f23f569
Merge pull request #8022 from nextcloud/bugfix/roll-back-jpeg-workarounds
gui: Remove now unneeded jpeg-related workarounds for macOS
2025-03-15 23:12:34 +08:00
Claudio Cambra
6a853ff1ed gui: Remove now unneeded jpeg-related workarounds for macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-14 16:40:06 +01:00
Matthieu Gallien
220d297fe9
Merge pull request #5681 from nextcloud/bugfix/const-autofy-ignore-list
Modernise ignorelisttablewidget code
2025-03-14 16:39:39 +01:00
Claudio Cambra
ec38926108 Const and autofy ignorelisttablewidget
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-14 15:01:52 +01:00
Matthieu Gallien
b6c0f56d1a
Merge pull request #8027 from nextcloud/bugfix/do-not-assume-account-exists-mac-vfs-domain
gui/macOS: Avoid UB in edge cases where there is no matching accountstate for a domain
2025-03-14 14:56:01 +01:00
Claudio Cambra
3d92e50322 gui/macOS: Avoid UB in edge cases where there is no matching account state for a domain
Do not assume existence of an account for a given domain identifier --
users can modify the config in unexpected ways

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-14 14:47:07 +01:00
Matthieu Gallien
f91a63d02a
Merge pull request #7984 from nextcloud/ci/clarifyDeprecatedLambdaCaptureWarnings
Ci/clear deprecated lambda capture warnings
2025-03-14 11:38:59 +01:00
Matthieu Gallien
04f4834c56 remove unused variable
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-14 11:10:16 +01:00
Matthieu Gallien
2863b273cb default this capture is deprecated, so capture it explicitly
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-14 11:10:16 +01:00
Matthieu Gallien
046d539206 require std c++ 20 ISO standard
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-14 11:10:16 +01:00
Matthieu Gallien
9c58ed2dcc
Merge pull request #8016 from nextcloud/ci/disableMoreDroneTests
remove gcc and clang build checks
2025-03-14 09:17:16 +01:00
Matthieu Gallien
82f02d64f7 remove gcc and clang build checks
they are redondant apart from the end-to-end tests

those end-to-end tests were never reliable and regularly fail removing
the usefulness of running them

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-14 09:17:03 +01:00
Nextcloud bot
97a06928a7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-14 03:10:07 +00:00
Matthieu Gallien
2a8f17be9b
Merge pull request #8012 from nextcloud/bugfix/fixUploadEncryptedFilesIntoReceivedShare
ensure user receiving an encrypted share maintain proper state
2025-03-13 12:34:17 +01:00
Matthieu Gallien
89e6d2af17 ensure user receiving an encrypted share maintain proper state
will make sure the client internal database keeps proper encryption
information

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-13 12:26:53 +01:00
Matthieu Gallien
b573b32370
Merge pull request #8009 from nextcloud/bugfix/careful-not-to-log-details
gui/macOS: Do not log account detail-related messages that were not sent on dead file provider socket
2025-03-13 12:11:00 +01:00
Claudio Cambra
0a872ef17a gui/macOS: Do not log account detail-related messages that were not sent on dead file provider socket
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-13 12:10:49 +01:00
Matthieu Gallien
243ae42cb6
Merge pull request #7971 from nextcloud/bugfix/include-reshared-shares
display reshares in sharing dialog
2025-03-13 12:08:02 +01:00
Jyrki Gadinger
50182442b2 display reshares in sharing dialog
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-13 12:07:49 +01:00
Matthieu Gallien
4d7c66130f
Merge pull request #7988 from hefee/hefee/fix-without-webengine-build
Fix build when BUILD_WEBENGINE=OFF
2025-03-13 11:56:25 +01:00