try to use const and auto as much as possible
remove useless constructor argument that is always using the default value
makes code cleaner
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
no need to carry some hack when we can use the same standard and cross
platform feature directly from Qt code
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
originally using qFatal or qCFatal should have written a crash dump log
file
bring it back and ensure the crash would happen via the default Qt log
message handler
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
when a build is configured without the network proxy feature, ensure we
do not show any UI related to network proxy settings in the new account
wizard
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also ensure we properly check the state of the dialog when needed and only when needed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
connect the new UI to real proxy settings and allow modification and
store them when the user has finished setting them up
close#8602
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Discussed in forum.
e .g. "5m" is not correct
Corrrect form is "5min"
See https://en.wikipedia.org/wiki/Minute for reference
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Some callbacks do not contain a valid value for the `ProcessInfo` member
despite `CF_CONNECT_FLAG_REQUIRE_PROCESS_INFO` being set.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
The `hydrationRequestReady` signal could be emitted before it was
connected to the event loop, resulting in the data transfer never being
started.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
If only VFS sync is configured, the sync state would be stuck to
`SyncPrepare` otherwise, unless a file is downloaded/uploaded from the
configured VFS directory.
I think this broke with ee3ae980a8, where
the EnumerationListener that reported the sync states got removed.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Using the short local folder name has some interesting side effects,
such as ending up as being e.g. "C:\MySyncRoot" or "Desktop\MySyncRoot"
due to it just removing the path to the current user's home directory.
IMO using the remote path for the sidebar entry is more logical -- I
don't care where I synced it to locally, I just want to know what my
sync destination is.
To improve future maintenance I moved the generation of the sidebar
display name to a separate method, and added some quick unit tests.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
- only activate VFS for the account if the user chose to do so
- don't display the "VFS is now active" messagebox during account setup
- set VFS enabled in the FileProviderSettingsController, the
enabled/disabled state is set in a .plist file (e.g.
`~/Library/Preferences/com.nextcloud.desktopclient.plist`) ...
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
