Commit Graph

23320 Commits

Author SHA1 Message Date
Matthieu Gallien
14be21cef2 fix(propagation): ensure we run file removal propagation steps
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-28 11:45:54 +02:00
Matthieu Gallien
47163dedac fix(propagation): more logs on folder deletions propagation step
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-28 11:45:54 +02:00
Matthieu Gallien
dba9c6d9c4 fix(propagation): ensure we delete pending folders before terminating
we might forget to run the pending folder deletions when terminating
synchronization

ensure we check if any of them are to be done

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-28 11:45:54 +02:00
Matthieu Gallien
f3bc7cf7b0 fix(filesystem): use platform specific API to make a file read-only
on Windows we may fail to mark a file read-only be read-write again
using high level API

switch to use of low level C API from Microsoft

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-28 11:45:54 +02:00
Matthieu Gallien
fcee45d2b5 fix(filesystem): log more permissions when deleting a file fails
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-28 11:45:54 +02:00
Matthieu Gallien
7010a7283a
Merge pull request #8135 from SnejPro/explorer-shortcut
Include server path to windows explorer shortcut
2025-04-28 10:44:10 +02:00
SnejPro
0689d1daa8 fix compile error
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
6d336e92fe fix
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
3d7c946776 fix
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
a91cc1f2c7 fix string
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
1afa0f0c6a fix declaration
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
34d394995b fix definition error
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
c54b98fed5 fix port should be shown after url
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
9d902d0dba Revert "modify workflow for my needs"
This reverts commit 757b55b5bfa3a240f282be9c6d95fa0eb3c5f692.

Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
7f65f653af definition shortcutName
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
b5edc87051 modify workflow for my needs
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
fea9317cf3 define shortcutName
- when more than one nextcloud instances:
-- cloud@example.org - prettyName

Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
SnejPro
93e5770bce Include server path to windows explorer shortcut
Signed-off-by: SnejPro <11321022+SnejPro@users.noreply.github.com>
2025-04-28 10:44:00 +02:00
Matthieu Gallien
45a5e07c34
Merge pull request #8201 from nextcloud/bugfix/sharing-search-popup-sizing
fix(gui): resize sharee search results list dependent on required space
2025-04-28 09:46:26 +02:00
Jyrki Gadinger
fe0140f8fe fix(gui): resize share search results list dependent on required space
In the case there are more search results present than there's space for
it, always display a scrollbar.  Some QtQuick themes don't make it
obvious that the list is scrollable.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-04-28 09:11:55 +02:00
Nextcloud bot
2faee5535c
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-04-28 03:05:06 +00:00
Andy Scherzinger
2d8649bda8
Merge pull request #8210 from nextcloud/docs/noid/reuse
Migrate more headers to SPDX
2025-04-27 16:40:11 +02:00
Nextcloud bot
f768f0941e
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-04-27 03:01:40 +00:00
Nextcloud bot
48f6584152
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-04-26 03:02:30 +00:00
Andy Scherzinger
49038ade94
docs(reuse): Migrate to SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-04-25 17:27:21 +02:00
Matthieu Gallien
96f4b0b76e
Merge pull request #8200 from nextcloud/bugfix/doNotRuntimeCrash
fix(assert): remove runtime assert that could crash production builds
2025-04-25 17:19:17 +02:00
Matthieu Gallien
4ef159c734 fix(assert): remove runtime assert that could crash production builds
use debug only assert to remove the possibility that we self inflict
crashes on users

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-25 17:19:05 +02:00
Matthieu Gallien
c416f5bd6f
Merge pull request #8206 from nextcloud/bugfix/warn-unused-var
fix(gui): Fix set but unused warning in switch statement for sync status compute
2025-04-25 17:18:35 +02:00
Claudio Cambra
200471d7f1 fix(gui): Fix set but unused warning in switch statement for sync status compute
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-04-25 17:18:25 +02:00
Matthieu Gallien
e204cbe450
Merge pull request #8181 from nextcloud/bugfix/invalidfilenamedialog
fix(gui): handle invalid file name edge case on Windows
2025-04-25 14:31:21 +02:00
Jyrki Gadinger
069d5dc670 fix(gui): don't append another slash to the relative path
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-04-25 14:31:11 +02:00
Jyrki Gadinger
482820979a refactor: add new filePath method to folder
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-04-25 14:31:11 +02:00
Jyrki Gadinger
e3fde47cab fix(gui): always hide the error label if we are allowed to rename
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-04-25 14:31:11 +02:00
Jyrki Gadinger
1fba0db68b fix(gui): update info text with proper invalid characters
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-04-25 14:31:11 +02:00
Jyrki Gadinger
6a2ee743bd fix(gui): handle invalid file name edge case on Windows
File names like "c:blah" would break the usage of the dialogue,
displaying a path like "c://blah" instead.

Apparently `QDir::filePath` checks if the passed file name is an
absolute file name using `!QFileInfo::isRelative`, which is the case if
the second character in the string is a colon -- probably indicating a
drive letter.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-04-25 14:31:11 +02:00
Nextcloud bot
f466f555be
fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-04-25 03:01:47 +00:00
Matthieu Gallien
24536d738a
Merge pull request #8152 from nextcloud/bugfix/translation-adjustments
Translation adjustments
2025-04-24 12:39:33 +02:00
Jyrki Gadinger
e529195bbe fix(l10n): use proper plural forms in UserStatusSelectorModel
Many languages have different ways of handling plurals where checking
for `n == 1` is simply not enough.

Fixes #8149

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-04-24 12:39:22 +02:00
Jyrki Gadinger
9eaa949657 fix(l10n): provide proper translatable strings for Folder/Directory
in German this ended up as "Datei Namen"/"Ordner Namen", whereas these
should be compounds instead (i.e. "Dateinamen", "Ordnernamen")

Fixes #7962

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-04-24 12:39:22 +02:00
Matthieu Gallien
cea8013653
Merge pull request #8193 from nextcloud/bugfix/doNotCrashWhenPropagatingChangesWithMoveOrRename
Bugfix/do not crash when propagating changes with move or rename
2025-04-24 11:49:58 +02:00
Matthieu Gallien
c004fd4b5a
fix(rename): avoid hitting runtime assert when renaming virtual files
when propagating a rename to the child items, we must not make child
items be done from propagator point of view

they will be part of their own propagator item and that will create
issues

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-24 11:47:20 +02:00
Matthieu Gallien
505557ce7b
fix(rename): handle complex rename/move scenario
ensure we do not leak records and properly update them in client
database

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-24 11:47:19 +02:00
Matthieu Gallien
5d7e43fecb feat(discovery): add more info for renamed items
add original name
add renamed name
add target name

should make it easier to analyze rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-24 11:18:26 +02:00
Matthieu Gallien
892ccb11d6 feat(discovery): add missing inode info for discovered files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-24 11:18:26 +02:00
Matthieu Gallien
84bf56114d perf(discovery): optimize empty strings
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-24 11:18:26 +02:00
Matthieu Gallien
d92ed441a2
Merge pull request #8195 from nextcloud/bugfix/useQFileAgain
revert to QFile::remove to remove single files
2025-04-24 11:18:03 +02:00
Matthieu Gallien
0eacdcee70
fix(filesystem): warn when trying to delete an already deleted file
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-24 10:29:20 +02:00
Matthieu Gallien
2bcf7ce54e
fix(filesystem): still use std::filesystem::remove for folders
this API has a way to provide an error when failing to delete a folder

we may want to know why teh folderf ailed to be deleted

QDir::rmdir does not provide any error when failing to delete a folder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-24 10:29:20 +02:00
Matthieu Gallien
2b8f129680
fix: Revert "stop using QFile api to delete a single local file"
This reverts commit 58d28ab330.

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-04-24 10:29:16 +02:00
Matthieu Gallien
baf60490e6
Merge pull request #8189 from nextcloud/bugfix/filesystemRemoveFileNotWorking
Bugfix/filesystem remove file not working
2025-04-23 15:02:46 +02:00