Commit Graph

23107 Commits

Author SHA1 Message Date
Claudio Cambra
092c8d774c
Merge pull request #8080 from nextcloud/bugfix/objcpp-mem
gui/macOS: Fix memory issues in Objective-C++ code for FileProvider support
2025-03-27 15:15:58 +01:00
Claudio Cambra
499ca78f68
gui/macOS: Properly retain/release NSFileProviderManager(s)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 13:08:12 +01:00
Claudio Cambra
0c57f0c45a gui/macOS: Avoid need to retain/release things in file provider edit locally
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
3a55aba2d3 gui/macOS: Avoid crash from bad manager release
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
2ee5c2628b gui/macOS: Avoid retain call on extensionNcAccount by allocing new string
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
16a59fcd19 gui/macOS: Improve overall memory management in XPCUtils::getDomainManagers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
9d07744752 gui/macOS: Do not leak debug log string after use
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
09c8af7371 gui/macOS: Use explicit type in connections array arg
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
d1fbbf64f0 gui/macOS: Correctly release objects received via FileProviderUtils functions
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
8e95e97921 gui/macOS: Properly wait for eviction result in materialised items model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
6733adb2e8 gui/macOS: Do not leak local url and error objects in edit locally job
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
ac96e80f04 gui/macOS: Correctly retain/release manager and domain in sync status object
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
74949beeab gui/macOS: Constify some Obj-C pointers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
fc2cc48c87 gui/macOS: Avoid unnecessary retain on alloced objects
Fixes leaks

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Claudio Cambra
5813931ccf gui/macOS: Avoid leaking objc objects added to arrays and dicts
The array/dict will retain them

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-27 12:07:15 +01:00
Nextcloud bot
ab88bc3dd7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-27 03:05:19 +00:00
Matthieu Gallien
d4ffe5da5f
Merge pull request #8081 from nextcloud/bugfix/translations-again
set `CFBundleDevelopmentRegion` to `"en"` and set `CFBundleAllowMixedLocalizations`
2025-03-26 18:27:34 +01:00
Jyrki Gadinger
da43f3dfb4 set CFBundleDevelopmentRegion to "en" and set CFBundleAllowMixedLocalizations
according to [1] the value should be a ISO 639-1 code, so let's correct
it

`CFBundleAllowMixedLocalizations` is the most interesting one: with this
being set the reported QLocale will no longer be English as well

(this also bumps the version info to 2025 :D)

[1]: https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundledevelopmentregion

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-26 17:45:02 +01:00
Jyrki Gadinger
6888a8df89
Merge pull request #8077 from nextcloud/bugfix/correct-talk-icon-border-colour
gui/tray: change the status icon background colour again
2025-03-26 16:21:24 +01:00
Jyrki Gadinger
cf326c1c77 gui/tray: change the status icon background colour again
As discussed, it's supposed to be the same colour as the header
background indeed...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-26 14:27:06 +01:00
Claudio Cambra
27dfae85cb
Merge pull request #8076 from nextcloud/bugfix/sync-progress-vfs
gui/macOS: Fix broken file provider domain progress reporting in settings window
2025-03-26 12:46:38 +01:00
Claudio Cambra
d70564f7ca
gui/macOS: Correctly release download/upload progress observers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-26 10:36:14 +01:00
Claudio Cambra
ca3653b13f
gui/macOS: Ensure file provider domain progress instances are correctly retained
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-26 10:25:58 +01:00
Nextcloud bot
c9409c9df4
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-26 03:04:01 +00:00
Claudio Cambra
9abb020317
Merge pull request #8072 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.14.0
Bump cpp-linter/cpp-linter-action from 2.13.4 to 2.14.0
2025-03-25 15:39:29 +01:00
dependabot[bot]
3f9aa4d4d6 Bump cpp-linter/cpp-linter-action from 2.13.4 to 2.14.0
Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.13.4 to 2.14.0.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.13.4...v2.14.0)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-25 15:29:46 +01:00
Claudio Cambra
d2a49ec2a1
Merge pull request #8073 from nextcloud/feature/free-space-up-finder-vfs
shell_integration/macOS/FileProviderUIExt: Add "free up space" menu entry
2025-03-25 15:28:58 +01:00
Claudio Cambra
fb64a59f4a shell_integration/macOS/FileProviderUIExt: Use more reliable new userInfo entry for downloaded state
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 15:23:25 +01:00
Claudio Cambra
66ea9276ad shell_integration/macOS/FileProviderUIExt: Log eviction process
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 15:23:25 +01:00
Claudio Cambra
0da4edefc5 shell_integration/macOS/FileProviderUIExt: Auto dismiss vc when evicting item
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 15:23:25 +01:00
Claudio Cambra
83a4781ba9 shell_integration/macOS/FileProviderUIExt: Add "free up space" action to context menu
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 15:23:25 +01:00
Claudio Cambra
8466170816 shell_integration/macOS/FileProviderUIExt: Add non-async eviction
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 15:23:25 +01:00
Claudio Cambra
0bf321dea1 shell_integration/macOS/FileProviderUIExt: Add eviction procedure
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 15:23:25 +01:00
Claudio Cambra
5664683939
Merge pull request #3510 from Tachi107/systemd-user-service
Add systemd user service
2025-03-25 15:22:35 +01:00
Andrea Pappacoda
f3696ba0aa Add systemd user service
Signed-off-by: Andrea Pappacoda <andrea@pappacoda.it>
2025-03-25 14:42:58 +01:00
Claudio Cambra
0f9e7b2ef8
Merge pull request #8053 from nextcloud/work/dont-assume-valid-accountstate
gui/macOS: Do not assume accountState will always be valid in socket controller
2025-03-25 12:11:39 +01:00
Claudio Cambra
697c3080ca gui/macOS: Do not assume accountState will always be valid
When removing an account this can change

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 12:11:22 +01:00
Claudio Cambra
182ff73c84 gui/macOS: Constify methods in file provider socket controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-03-25 12:11:22 +01:00
Nextcloud bot
11a2d77b23
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-25 03:06:07 +00:00
Matthieu Gallien
976f8a8a76
Merge pull request #8067 from nextcloud/ci/useCustomWindowsCraftCache
use our own craft cache on windows
2025-03-24 14:39:58 +01:00
Matthieu Gallien
7243742cc2 use our own craft cache on windows
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-24 10:43:08 +01:00
Matthieu Gallien
6818bd056b
Merge pull request #8066 from nextcloud/bugfix/fix-windows-build
fix Windows build
2025-03-24 10:42:58 +01:00
Jyrki Gadinger
0776f42772 fix Windows build
`cl` didn't quite like it:

```
error C2445: result type of conditional expression is ambiguous: types 'QByteArray' and 'const char [1]' can be converted to multiple common types
```

just changing the `auto` to `QByteArray` results in the same compile error

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-03-24 09:50:21 +01:00
Nextcloud bot
584ee9f26a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-24 03:03:30 +00:00
Nextcloud bot
9d09777381
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-22 03:02:39 +00:00
Nextcloud bot
702efe59a0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-21 03:27:43 +00:00
Matthieu Gallien
b074399491
Merge pull request #8052 from nextcloud/bugfix/sendProperHeaderForChecksumDuringBulkUpload
use standard way to find the checkum type and really send it to server
2025-03-20 14:45:39 +01:00
Matthieu Gallien
18085d899e use standard way to find the checkum type and really send it to server
will fix missing checksum for bulk upload

will ensure consistent behavior between bulk upload, plain old upload
and chunked upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-03-20 09:13:18 +01:00
Nextcloud bot
0a47e62817
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-03-20 03:07:28 +00:00
Matthieu Gallien
28710b03ad
Merge pull request #8050 from nextcloud/bugfix/highlightTooBrightAppimage
Bugfix/highlight too bright appimage
2025-03-19 14:11:10 +01:00