we should return false from
BulkPropagatorDownloadJob::scheduleSelfOrChild() because we have no
child jobs that are not done and waiting to be started
ensure we update the job status only once (even in case of errors)
ensure we update the state of the items once and only once
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
filter new placeholder items by invalid modtime and only proceed with
creating only the valid ones
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
use the proper VFS plug-in API to request all files to be cerated as a
single batch
will now need a proper implementation using the batch Windows CfApi
function
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should allow to speed API calls to Windows CfApi by reducing their
numbers by asking for a list of new placeholders via a single call
instead of one for each new item
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
this code does not make sense
I tested manually and this code is never called
I doubt this code is needed or useful
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
try to use const and auto as much as possible
remove useless constructor argument that is always using the default value
makes code cleaner
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
no need to carry some hack when we can use the same standard and cross
platform feature directly from Qt code
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
originally using qFatal or qCFatal should have written a crash dump log
file
bring it back and ensure the crash would happen via the default Qt log
message handler
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
when a build is configured without the network proxy feature, ensure we
do not show any UI related to network proxy settings in the new account
wizard
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also ensure we properly check the state of the dialog when needed and only when needed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
connect the new UI to real proxy settings and allow modification and
store them when the user has finished setting them up
close#8602
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Discussed in forum.
e .g. "5m" is not correct
Corrrect form is "5min"
See https://en.wikipedia.org/wiki/Minute for reference
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Some callbacks do not contain a valid value for the `ProcessInfo` member
despite `CF_CONNECT_FLAG_REQUIRE_PROCESS_INFO` being set.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
The `hydrationRequestReady` signal could be emitted before it was
connected to the event loop, resulting in the data transfer never being
started.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
If only VFS sync is configured, the sync state would be stuck to
`SyncPrepare` otherwise, unless a file is downloaded/uploaded from the
configured VFS directory.
I think this broke with ee3ae980a8, where
the EnumerationListener that reported the sync states got removed.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Using the short local folder name has some interesting side effects,
such as ending up as being e.g. "C:\MySyncRoot" or "Desktop\MySyncRoot"
due to it just removing the path to the current user's home directory.
IMO using the remote path for the sidebar entry is more logical -- I
don't care where I synced it to locally, I just want to know what my
sync destination is.
To improve future maintenance I moved the generation of the sidebar
display name to a separate method, and added some quick unit tests.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
