mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(readonly): avoid implicit hydration when modifying permissions

Browse Source 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
This commit is contained in:
Matthieu Gallien 2025-05-28 17:14:46 +02:00
parent 69b5b7beed
commit 3c8aeee167
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/libsync/filesystem.cpp
View File

@ -473,7 +473,17 @@ bool FileSystem::setFolderPermissions(const QString &path,
const auto childFiles = currentFolder.entryList(QDir::Filter::Files);
for (const auto &oneEntry : childFiles) {
const auto childFile = QDir::toNativeSeparators(path + QDir::separator() + oneEntry);
if (!SetFileSecurityW(childFile.toStdWString().c_str(), info, &newSecurityDescriptor)) {
const auto &childFileStdWString = childFile.toStdWString();
const auto attributes = GetFileAttributes(childFileStdWString.c_str());
// testing if that could be a pure virtual placeholder file (i.e. CfApi file without data)
// we do not want to trigger implicit hydration ourself
if ((attributes & FILE_ATTRIBUTE_SPARSE_FILE) != 0) {
continue;
}
if (!SetFileSecurityW(childFileStdWString.c_str(), info, &newSecurityDescriptor)) {
qCWarning(lcFileSystem) << "error when calling SetFileSecurityW" << childFile << GetLastError();
return false;
}