From 3c8aeee167538134bf3d6518820f1193de1f93ab Mon Sep 17 00:00:00 2001 From: Matthieu Gallien Date: Wed, 28 May 2025 17:14:46 +0200 Subject: [PATCH] fix(readonly): avoid implicit hydration when modifying permissions Signed-off-by: Matthieu Gallien --- src/libsync/filesystem.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/libsync/filesystem.cpp b/src/libsync/filesystem.cpp index 7fa9acb75b..6845083e79 100644 --- a/src/libsync/filesystem.cpp +++ b/src/libsync/filesystem.cpp @@ -473,7 +473,17 @@ bool FileSystem::setFolderPermissions(const QString &path, const auto childFiles = currentFolder.entryList(QDir::Filter::Files); for (const auto &oneEntry : childFiles) { const auto childFile = QDir::toNativeSeparators(path + QDir::separator() + oneEntry); - if (!SetFileSecurityW(childFile.toStdWString().c_str(), info, &newSecurityDescriptor)) { + + const auto &childFileStdWString = childFile.toStdWString(); + const auto attributes = GetFileAttributes(childFileStdWString.c_str()); + + // testing if that could be a pure virtual placeholder file (i.e. CfApi file without data) + // we do not want to trigger implicit hydration ourself + if ((attributes & FILE_ATTRIBUTE_SPARSE_FILE) != 0) { + continue; + } + + if (!SetFileSecurityW(childFileStdWString.c_str(), info, &newSecurityDescriptor)) { qCWarning(lcFileSystem) << "error when calling SetFileSecurityW" << childFile << GetLastError(); return false; }