Mumble.com kindly reported that the getRegistration() Ice method fails with an "enumerator out of range" error, due to a missing value in the "UserInfo" enum.
The value was added to Murmur in 813aceb854 and then renamed and moved in 5131d9e303.
This commit fixes a warning encountered today on FreeBSD, probably because Clang was updated and now `-Wdangling-else` is enabled by default.
Messages.cpp:1330:5: error: add explicit braces to avoid dangling else [-Werror,-Wdangling-else]
foreach(int id, pg->members()) {
^
I just had a FreeBSD build fail because AudioStats.cpp is using QPalette::Background, which apparently has been declared deprecated.
AudioStats.cpp:213:45: error: 'Background' is deprecated: Use QPalette::Window instead [-Werror,-Wdeprecated-declarations]
paint.fillRect(rect(), pal.color(QPalette::Background));
^
The Qt docs advise to use QPalette::Window instead (see https://doc.qt.io/qt-5/qpalette.html), so I went ahead and changed the code accordingly.
This commit fixes a warning encountered today on FreeBSD, probably because Clang was updated and now '-Wdangling-else' is enabled by default.
ConnectDialog.cpp:1178:3: error: add explicit braces to avoid dangling else [-Werror,-Wdangling-else]
foreach(ServerItem *si, qlItems)
^
The suggestion to use DirectSound was valid only for Windows versions prior to Vista, because WASAPI was introduced with it.
Fortunately DirectSound didn't appear in the UI as an option in case WASAPI was detected, hopefully we didn't mislead users into thinking that DirectSound is better than WASAPI.
Also, the description was suggesting to use DirectSound on non-Windows operating systems.
DirectSound was the first audio backend supported by Mumble, in 2005.
Windows Vista introduced a brand new audio stack called WASAPI, which entirely replaced DirectSound. Support for it was added in 9a018148bb, 6bef650e57 and 677a39951f.
This commit entirely removes our DirectSound implementation, not needed anymore because we are dropping support for Windows XP in 1.4.
This commit changes the Linux build script so that it retrieves the full Mumble version using mumble-version.py.
Previously we were using the first 7 characters of the commit hash as version, which is not very descriptive.
Copied from our current build environment, the header has been changed to match the one in the other scripts.
mumble-version.py determines the full Mumble version based on multiple variables, such as the current commit hash and the latest tag.
There's no reason to keep it in the build environment repository (mumble-releng), because it's supposed to be run inside the Mumble repository and doesn't depend on anything from the build environment.
https://maemo.org/api_refs/5.0/5.0-final/pulseaudio/paplay_8c-example.html
In the example the stream writer callback does nothing and returns in case there is no data to send.
Our code, instead, creates a buffer, fills it with zeroes and writes it to the stream if audio output is not enabled.
This commit changes the callback function's code so that it returns immediately in such case.
The change has been tested by setting an underflow callback function (using pa_stream_set_underflow_callback()) and checking whether underflows occurred.
