From fa73d472e4380d38f9889ca04100f68cb4042869 Mon Sep 17 00:00:00 2001
From: szaimen <szaimen@e.mail.de>
Date: Wed, 18 Nov 2020 23:19:36 +0100
Subject: [PATCH] allow to reinstall automatic updates (#1681)

Signed-off-by: szaimen <szaimen@e.mail.de>
---
 addons/automatic_updates.sh | 57 ++++++++++++++++++++-----------------
 1 file changed, 31 insertions(+), 26 deletions(-)

diff --git a/addons/automatic_updates.sh b/addons/automatic_updates.sh
index 2402ccb0..388a57d3 100644
--- a/addons/automatic_updates.sh
+++ b/addons/automatic_updates.sh
@@ -6,8 +6,11 @@ true
 SCRIPT_NAME="Automatic Updates"
 # shellcheck source=lib.sh
 source /var/scripts/fetch_lib.sh || source <(curl -sL https://raw.githubusercontent.com/nextcloud/vm/master/lib.sh)
-
-print_text_in_color "$ICyan" "Configuring automatic updates..."
+SCRIPT_EXPLAINER="This option will update your server every week on Saturdays at $AUT_UPDATES_TIME:00.
+The update will run the built in script '$SCRIPTS/update.sh' which will update both the server packages and Nextcloud itself.\n
+You can read more about it here: https://www.techandme.se/nextcloud-update-is-now-fully-automated/
+Please keep in mind that automatic updates might fail hence it's \
+important to have a proper backup in place if you plan to run this option."
 
 # Check for errors + debug code and abort if something isn't right
 # 1 = ON
@@ -18,29 +21,31 @@ debug_mode
 # Check if root
 root_check
 
-msg_box "This option will update your server every week on Saturdays at $AUT_UPDATES_TIME:00.
-The update will run the built in script '$SCRIPTS/update.sh' which will update both the server packages and Nextcloud itself.
-
-You can read more about it here: https://www.techandme.se/nextcloud-update-is-now-fully-automated/
-Please keep in mind that automatic updates might fail hence it's \
-important to have a proper backup in place if you plan to run this option.
-
-You can disable the automatic updates by entering the crontab file like this:
-'sudo crontab -e -u root'
-Then just put a hash (#) in front of the row that you want to disable.
-
-In the next step you will be able to choose to proceed or exit." "$SUBTITLE"
-
-if yesno_box_yes "Do you want to enable automatic updates?"
+# Check if automatic updates are already installed
+if ! crontab -u root -l | grep -q "$SCRIPTS/update.sh"
 then
-    # TODO: delete the following line after a few releases. It was copied to the install-script.
-    nextcloud_occ config:app:set updatenotification notify_groups --value="[]"
-    touch $VMLOGS/update.log
-    crontab -u root -l | { cat; echo "0 $AUT_UPDATES_TIME * * 6 $SCRIPTS/update.sh minor >> $VMLOGS/update.log"; } | crontab -u root -
-    if yesno_box_yes "Do you want to reboot your server after every update? *recommended*"
-    then
-        sed -i "s|exit|/sbin/shutdown -r +1|g" "$SCRIPTS"/update.sh
-        echo "exit" >> "$SCRIPTS"/update.sh
-    fi
-    msg_box "Please remember to keep backups in case something should go wrong, you never know." "$SUBTITLE"
+    # Ask for installing
+    install_popup "$SCRIPT_NAME"
+else
+    # Ask for removal or reinstallation
+    reinstall_remove_menu "$SCRIPT_NAME"
+    # Removal
+    crontab -u root -l | grep -v "$SCRIPTS/update.sh"  | crontab -u root -
+    sed -i '/shutdown/d' "$SCRIPTS/update.sh"
+    sed -i '/reboot/d' "$SCRIPTS/update.sh"
+    # Show successful uninstall if applicable
+    removal_popup "$SCRIPT_NAME"
 fi
+
+# Install automatic updates
+touch $VMLOGS/update.log
+crontab -u root -l | { cat; echo "0 $AUT_UPDATES_TIME * * 6 $SCRIPTS/update.sh minor >> $VMLOGS/update.log 2>&1"; } | crontab -u root -
+if yesno_box_yes "Do you want to reboot your server after every update? *recommended*"
+then
+    sed -i "s|exit|/sbin/shutdown -r +1|g" "$SCRIPTS"/update.sh
+    echo "exit" >> "$SCRIPTS"/update.sh
+fi
+
+msg_box "Please remember to keep backups in case something goes wrong, you never know."
+
+exit