From ab13071e07d98a0349eaedc16db2f4a77f5e5932 Mon Sep 17 00:00:00 2001 From: Caleb Maclennan Date: Tue, 10 Sep 2024 15:14:14 +0300 Subject: [PATCH] chore: Remove self-update from default crate features (#1139) The self-updater feature is problematic for distro package builders where the executable does not have permission and should not be trying to monkey with the system installed binaries. Distros have their own update mechanisms that shouldn't be tampered with by every app that comes along. This means distro have to build with --no-default-features for apps that include self-updaters by default, but that also means we have to maintain a list of features we do want. This is not only tedious it is error-prone because there is a very good chance of new features getting overlooked when doing version bumps. Setting up a feature group like this makes it much easier for distros to build without the unwanted features without getting out of sync with upstream enhancements over time. Co-authored-by: simonsan <14062932+simonsan@users.noreply.github.com> --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index b9b4de4..03cebb1 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -18,7 +18,7 @@ rustic - fast, encrypted, deduplicated backups powered by Rust """ [features] -default = ["self-update", "tui", "webdav"] +default = ["tui", "webdav"] mimalloc = ["dep:mimalloc"] jemallocator = ["dep:jemallocator-global"] self-update = ["dep:self_update", "dep:semver"]