pfsense/usr/local/www/interfaces_vlan_edit.php
Ermal Luçi 3aa3cee261 Remove the parent interface reconfiguration functions they are only bogusly/erroneously called here:
* On bootup without this change the parent interface will be configured twice.
* Even when the system is up a vlan does not have to mock up with the parent apart guaranteeing that it is up.

The only thing that does not work is makeing a VLAN on dynamic interfaces like pppoe/pptp.
Afaik it has never worked and i do not think that many people would use vlans over pppoe,
if a feature request for such things comes up it will be on my TODO around 2.x of pfSense.
2008-07-09 18:55:46 +00:00

159 lines
5.8 KiB
PHP
Executable File

<?php
/* $Id$ */
/*
interfaces_vlan_edit.php
part of m0n0wall (http://m0n0.ch/wall)
Copyright (C) 2003-2004 Manuel Kasper <mk@neon1.net>.
All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
*/
require("guiconfig.inc");
if (!is_array($config['vlans']['vlan']))
$config['vlans']['vlan'] = array();
$a_vlans = &$config['vlans']['vlan'];
$portlist = get_interface_list();
$id = $_GET['id'];
if (isset($_POST['id']))
$id = $_POST['id'];
if (isset($id) && $a_vlans[$id]) {
$pconfig['if'] = $a_vlans[$id]['if'];
$pconfig['vlanif'] = $a_vlans[$id]['vlanif'];
$pconfig['tag'] = $a_vlans[$id]['tag'];
$pconfig['descr'] = $a_vlans[$id]['descr'];
}
if ($_POST) {
unset($input_errors);
$pconfig = $_POST;
/* input validation */
$reqdfields = explode(" ", "if tag");
$reqdfieldsn = explode(",", "Parent interface,VLAN tag");
do_input_validation($_POST, $reqdfields, $reqdfieldsn, &$input_errors);
if ($_POST['tag'] && (!is_numericint($_POST['tag']) || ($_POST['tag'] < '1') || ($_POST['tag'] > '4094'))) {
$input_errors[] = "The VLAN tag must be an integer between 1 and 4094.";
}
foreach ($a_vlans as $vlan) {
if (isset($id) && ($a_vlans[$id]) && ($a_vlans[$id] === $vlan))
continue;
if (($vlan['if'] == $_POST['if']) && ($vlan['tag'] == $_POST['tag'])) {
$input_errors[] = "A VLAN with the tag {$vlan['tag']} is already defined on this interface.";
break;
}
}
if (!$input_errors) {
$vlan = array();
$vlan['if'] = $_POST['if'];
$vlan['tag'] = $_POST['tag'];
$vlan['descr'] = $_POST['descr'];
$vlan['vlanif'] = $_POST['vlanif'];
$vlan['vlanif'] = interface_vlan_configure($vlan['if'], $vlan['tag'], $vlan['vlanif']);
if ($vlan['vlanif'] == "" || !stristr($vlan['vlanif'], "vlan"))
$input_errors[] = "Error occured creating interface, please retry.";
else {
if (isset($id) && $a_vlans[$id])
$a_vlans[$id] = $vlan;
else
$a_vlans[] = $vlan;
write_config();
header("Location: interfaces_vlan.php");
exit;
}
}
}
$pgtitle = array("Firewall","VLAN","Edit");
include("head.inc");
?>
<body link="#0000CC" vlink="#0000CC" alink="#0000CC">
<?php include("fbegin.inc"); ?>
<?php if ($input_errors) print_input_errors($input_errors); ?>
<form action="interfaces_vlan_edit.php" method="post" name="iform" id="iform">
<table width="100%" border="0" cellpadding="6" cellspacing="0">
<tr>
<td width="22%" valign="top" class="vncellreq">Parent interface</td>
<td width="78%" class="vtable">
<select name="if" class="formselect">
<?php
foreach ($portlist as $ifn => $ifinfo)
if (is_jumbo_capable($ifn)) {
echo "<option value=\"{$ifn}\"";
if ($ifn == $pconfig['if'])
echo "selected";
echo ">";
echo htmlspecialchars($ifn . " (" . $ifinfo['mac'] . ")");
echo "</option>";
}
?>
</select>
<br/>
<span class="vexpl">Only VLAN capable interfaces will be shown.</span></td>
</tr>
<tr>
<td valign="top" class="vncellreq">VLAN tag </td>
<td class="vtable">
<input name="tag" type="text" class="formfld unknown" id="tag" size="6" value="<?=htmlspecialchars($pconfig['tag']);?>">
<br>
<span class="vexpl">802.1Q VLAN tag (between 1 and 4094) </span></td>
</tr>
<tr>
<td width="22%" valign="top" class="vncell">Description</td>
<td width="78%" class="vtable">
<input name="descr" type="text" class="formfld unknown" id="descr" size="40" value="<?=htmlspecialchars($pconfig['descr']);?>">
<br> <span class="vexpl">You may enter a description here
for your reference (not parsed).</span></td>
</tr>
<tr>
<td width="22%" valign="top">&nbsp;</td>
<td width="78%">
<input type="hidden" name="vlanif" value="<?=$pconfig['vlanif']; ?>">
<input name="Submit" type="submit" class="formbtn" value="Save"> <input type="button" value="Cancel" onclick="history.back()">
<?php if (isset($id) && $a_vlans[$id]): ?>
<input name="id" type="hidden" value="<?=$id;?>">
<?php endif; ?>
</td>
</tr>
</table>
</form>
<?php include("fend.inc"); ?>
</body>
</html>