Main repository for pfSense
Go to file
Phil Davis 7af43cb02d interface_netgraph_needed can miss setting found equals true
This routine seems to go looking to see if the passed-in interface is PPP-style. At the end, if it is not PPP-style then it calls pfsense_ngctl_detach.
This foreach loop in its current state will always exit after the first iteration that is not mode "server". But it looks like it should look through all the 'pppoe' entries until it finds the interface or gets to the end.
In theory the code will sometimes miss setting $found = true when it should have. And thus pfsense_ngctl_detach would get called later for a PPP-style interface.
I noticed this while reviewing for code style guide - it is an example where the indenting shows the intention but there are no curlies to implement it.
2015-02-25 23:06:32 +05:45
boot Remove old write caching tunable as well. Ticket #4203 2015-01-12 12:43:34 -06:00
cf/conf Its long overdue the ez-ipupdate.cache file 2014-04-26 09:59:37 +00:00
conf.default Update Unbound defaults 2015-02-09 22:28:15 -06:00
etc interface_netgraph_needed can miss setting found equals true 2015-02-25 23:06:32 +05:45
root Set proxy env vars on interactive shell and also on crontab to make all scripts be able to use it. Ticket #3789 2014-11-11 11:57:38 -02:00
sbin Set this to /8 instead since that's how it's done in stock FreeBSD 10.1. Ticket #3941 2014-11-10 21:52:52 -06:00
tmp Deal correct with filenames with spaces 2014-11-14 07:46:57 -02:00
usr Ticket #4418 make sure the dns_split is separated with spaces rather than space or comma to comply with strongswan requirements. 2015-02-25 16:19:26 +01:00
.gitattributes include gettext locales in line encoding list 2014-01-13 22:05:10 -05:00
.gitignore
license.txt Welcome 2015 2014-12-31 16:22:00 -02:00