mirror of
https://github.com/pfsense/pfsense.git
synced 2025-10-26 11:38:35 +00:00
Main repository for pfSense
2cd249edf0
I cannot understand how this worked anywhere in the recent past. The code fragment:
if(isset($rule[$target]['not']))
$src = " !{$src}";$src = " !{$src}";
Appeared in multiple if/else clauses but was missing in 2 places, which I have added.
Actually, it is now duplicated in every part of the filter_generate_address if/else structure, and so it could be applied once at the end of the routine.
I have taken the minimal risk approach here, since I am not in a position to test every if/else case properly. But I can easily create a version that removes the code duplication, and someone else can test it well before committing (this is a fundamental bit of rule code that everyone uses, so I don't want to accidenatally break it worse for some poor sod.)
|
||
|---|---|---|
| boot | ||
| cf/conf | ||
| conf.default | ||
| etc | ||
| root | ||
| sbin | ||
| tmp | ||
| usr | ||
| .gitattributes | ||
| .gitignore | ||