Commit Graph

160 Commits

Author SHA1 Message Date
Phil Davis
6317d31dfc Fix lineup of copyright lines
and module names and other bits of formatting and typos in header
comment sections.
2015-01-01 10:13:14 -02:00
Renato Botelho
d961e7e33e Welcome 2015 2014-12-31 16:22:27 -02:00
Jim Thompson
29aef6c45b Change copyright statement to reflect reality 2014-11-10 23:36:14 -06:00
Renato Botelho
62424bdbbb Remove almost all calls to history.back() and make Cancel button back to HTTP_REFERER, there are a couple of places I didn't touch on this commit because it requires more work 2014-09-12 16:37:08 -03:00
Chris Buechler
cac386b68e remove openbgpd bits from system_gateways_edit and system.inc. The package
match is case-sensitive and hasn't matched the openbgpd package's name in
at least 5 years, so it doesn't do anything. It's far from functional in
any useful manner even fixing that issue.
2014-05-30 20:01:46 -05:00
Renato Botelho
7f7626ba44 Merge branch 'master-br' of https://github.com/ayvis/pfsense into ayvis-master-br 2014-03-17 11:17:29 -03:00
Chris Buechler
5721595b8d standardize on https://www.pfsense.org 2014-03-14 19:08:43 -05:00
ayvis
8cd558b61b xhtml Compliance
replaced <br>, <br/> and </br> with <br />
2014-03-14 21:24:03 +01:00
Renato Botelho
e41ec5848f Improve checks for params 'id', 'dup' and other similar ones to make sure they are numeric integer, also, pass them through htmlspecialchars() before print 2014-03-12 11:42:49 -03:00
N0YB
ec5c28cde6 Gateway Monitor Advanced Settings
Recommended changes made to calculated value input behavior.
Restrict interval to integer of 1 or greater.
2014-01-25 12:49:30 -08:00
N0YB
3c6787ed65 Gateway Monitor Advanced Settings
Exposes 3 additional apinger configuration options in the gateway monitor advanced section which can either be set manually, calculated based on interval, or use the hard coded defaults.
	1) Avg Delay Samples
	2) Avg Loss Samples
	3) Avg Loss Delay Samples

The current hard coded defaults are okay for a short interval such as the 1 second default.  But do not work well when a longer interval is required.
2014-01-24 22:28:18 -08:00
Renato Botelho
81f1947666 Add an option to force a gateway to be down, it fixes #2847 2014-01-06 14:11:14 -02:00
Renato Botelho
fcd01c8a29 Delete static route when monitor IP is removed, also save monitor IP even when it's disabled 2013-12-27 12:12:44 -02:00
Renato Botelho
96ef7db031 Add an option to disable gateway items 2013-11-26 18:41:44 -02:00
Renato Botelho
23d9f68660 Fix an issue that changes wrong gateway entry when items are hidden 2013-11-21 09:37:02 -02:00
Renato Botelho
bf75550387 Use a more accurate error message, fixes #3282 2013-10-25 10:42:02 -02:00
Renato Botelho
1e9b461124 Remove call-time pass by reference for do_input_validation, helps ticket #2565 2013-09-12 11:28:14 -03:00
Renato Botelho
605ae5537d Fix #3127
By default htmlspecialchars does not consider single quotes, what can be
a problem when value attribute is set using it. Replace value attribute
set to use double quotes on places where it's obviously recieving a
result of htmlspecialchars() call.
2013-09-06 08:08:03 -03:00
Ermal
32a9eb1873 Bring back static routes to fix issues reported on Ticext #3179 2013-09-03 16:52:43 +00:00
Renato Botelho
beb7cd97eb Use ipprotocol to check gateway protocol, this fix a issue that allow to set more than one default gateway when it's dynamic 2013-08-29 14:38:31 -03:00
Phil Davis
490cd4388b Use Probe Interval on gateway advanced settings 2013-06-21 08:33:29 +05:45
jim-p
94744c2710 Correct gateway down/probe interval text. 2013-06-19 08:47:21 -04:00
jim-p
4f30185f85 Fix up gateway advanced option note that was missed from 2.1 but on 2.0.x. 2013-05-29 12:34:32 -04:00
Renato Botelho
db7a628c0f Replace all linklocal checks by is_linklocal() 2013-05-09 08:05:13 -03:00
Renato Botelho
55705b3335 Allow IPs inside virtual IP networks to be used as gateways. Fixed #2962 2013-04-23 09:40:27 -03:00
Chris Buechler
612170a7ac make fe80 gateway check case-insensitive 2013-04-14 12:21:40 -05:00
Colin Fleming
a1dccfc653 Tidy up "system_gateways_edit.php" XHTML
Add CDATA section to SCRIPT tags
Close INPUT and BR tags
Update HTML boolean operators
2013-04-03 20:51:36 +01:00
Renato Botelho
0b844b73b5 Fix indent, whitespaces and unbalanced <tr> and <td> tags 2013-02-26 10:15:42 -03:00
Ermal
b5b5bcc041 Make more strict checks during is_ip* functions. Helps http://forum.pfsense.org/index.php/topic,58399.0.html and http://forum.pfsense.org/index.php/topic,58273.0.html 2013-02-04 13:36:25 +00:00
bcyrill
60037e00aa Update usr/local/www/system_gateways_edit.php
Correct IP family mix-up.
2013-02-01 22:18:21 +01:00
Colin Fleming
a3381369d9 Update PHP shorthand tag
Standardise all PHP start tags from "<?" to "<?PHP"
2013-01-14 13:27:36 +00:00
jim-p
a138f06536 Encode parameters before showing them to users. 2012-10-31 15:51:42 -04:00
jim-p
b32dd0a6b7 Activate new shortcuts/status in the rest of the areas that are currently setup. 2012-08-10 13:32:16 -04:00
Phil Davis
eb2335174c Validate advanced gateway monitoring settings
Use the default values from return_apinger_defaults.
Validate values - low less than high, probe interval less than "down" time, values are positive numeric.
Update descriptions on the UI to show the defaults used.
2012-07-25 21:57:27 +05:45
smos
2972b3e786 Now that we actually have a IP protocol tag in the config.xml we can make this check a lot simpler and do less guessing.
Redmine ticket #2503
2012-06-18 18:37:20 +02:00
smos
e02caf4ab9 Actually save the IPprotocol variable into the config, otherwise it stil won't work.
People will likely need to edit and save their gateways now if they have double entries.
e.g. both manual and automatically added entries, these will dissapear as soon as you save.
If we know if the gateway or monitor is ipv4 or ipv6 we can autodetect which prevents this.
Because we don't know what address family the gateway on a dual stack interface belongs to we better not guess, and let the user figure it out. Often, a edit and save is the fastest.
For upgrading from 2.0 we could mark all gateways as being ipv4 which prevents half of the issues.
Redmine ticket #2463
2012-06-01 07:46:55 +02:00
smos
c1d36d26a9 Finally give in and sprout a Internet Protocol drop down on the gateways edit screen.
With added validation and multiple detection parts to work when the value is not set yet.
Redmine ticket #2463
2012-05-31 18:28:16 +02:00
Darren Embry
cd485c4fce remove some log_error calls 2012-05-17 19:02:01 -04:00
Darren Embry
283d78c632 bug fix for #2426
Input validaton on interface gateway creation box needs to reject duplicate names
2012-05-17 19:00:06 -04:00
Darren Embry
a0edece98b report errors adding a gateway through ajax calls 2012-05-17 18:33:21 -04:00
smos
2a9cb3b2a8 Fix the link local check when trying to add a link local gateway
Ticket #2071
2012-03-13 20:39:42 +01:00
smos
35af71416e Fix for ticket 2071, this allows link local addresses for gateways.
Backend already added the interface scope for link local addresses, hurrah.
2012-01-15 12:40:38 +01:00
jim-p
ec9bb09fe2 Clarify the potential pitfalls when setting the Frequency Probe and Down parameters. 2011-12-29 14:23:01 -05:00
smos
16106d2e4b Fix for redmine ticket #1993. Allow saving multiple dynamic entries.
Make sure that return_gateways_status() also returns all gateways that have monitoring disabled as up.
2011-11-27 20:09:48 +01:00
Nachtfalkeaw
a574b9607d Add default values for latency, packet loss, down on GUI 2011-08-28 06:41:20 +03:00
Seth Mos
16b03b7985 Fix a typo in the subnet generation causing the code to fail 2011-08-24 15:07:05 +02:00
Seth Mos
9e80d14cab Add address family input validation on the Gateways edit page, also prevent adding gateways on interfaces that do not carry that address family.
Fix Ticket #1633
2011-08-24 12:42:16 +02:00
jim-p
28ce79ad04 Simplify this code a bit, should be the same test in both locations since this should be either/or, and with the other code it can apparently fall into a trap where it shows neither. 2011-08-23 16:36:23 -04:00
Ermal
f720398561 Add an override for default interval to send icmp 2011-07-28 20:56:38 +00:00
Ermal
33c06ef791 Add a new option to allow disabling of gateway monitoring. This gateways will always be reported as up. 2011-07-28 20:31:57 +00:00