mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
24,910 Commits 27 Branches 53 Tags 494 MiB
ff7990df20
Commit Graph

171 Commits

Author SHA1 Message Date
Phil Davis
fc03ca0112 Fix POST typo in interfaces_assign.php 
Obviously a typo. But this section is inside:
if (isset($_POST['add_x']) && isset($_POST['if_add'])) {
and I cannot find where 'add_x' is ever sent here, so I do not see how this whole code section is ever executed (and that will be why this typo bug has no symptoms). What is the history here? Can the whole block of code be removed?
The code normally executed is the section for 'Submit' lower down.
 2015-01-11 11:03:51 -02:00
Phil Davis
6317d31dfc Fix lineup of copyright lines 
and module names and other bits of formatting and typos in header
comment sections.
 2015-01-01 10:13:14 -02:00
Renato Botelho
d961e7e33e Welcome 2015 2014-12-31 16:22:27 -02:00
Phil Davis
b8959f3c85 Provide friendly descr in error message in Interfaces Assign 
I was doing drastic things testing some stuff, swapping WAN and OPT1 interfaces in Interfaces->Assign. I accidentally pressed Save when I had the same real device selected for both. Thankfully there was input validation! But I noticed that the error message reported just the names WAN and OPT1, but actual I had them named as different things. So the names in the error message did not match the names (friendly descriptions) in the table of interfaces.
This change makes it display both like FRIENDLY_DESC (FRIENDLY_NAME) so there is less room for confusion.
 2014-12-04 08:40:06 -02:00
Phil Davis
d4b9bc5a4d Make OpenVPN desccriptions appear in interfaces assign dropdown 
As reported in forum https://forum.pfsense.org/index.php?topic=84251.0
The fix turned out to be easy.
 2014-11-18 09:38:52 +05:45
Jim Thompson
29aef6c45b Change copyright statement to reflect reality 2014-11-10 23:36:14 -06:00
Renato Botelho
7c611a3ea0 Improvements on interfaces_assign.php: 
- Let user select network port to add instead of pick the first
  available, it fixes #3846
- While I'm here, drop GET and use only POST
 2014-09-08 17:36:16 -03:00
Renato Botelho
1c4b163695 Convert this block into a function for later use 2014-09-08 17:24:55 -03:00
Renato Botelho
e4034dcb7d Fix indent 2014-09-08 17:24:55 -03:00
Renato Botelho
eb2ab5ebee Remove unecessary var initialization 2014-09-08 17:24:55 -03:00
Renato Botelho
19498fbf0a Replace mwexec() by unlink_if_exists() and respect global tmp_path 2014-09-08 17:24:55 -03:00
Renato Botelho
1b0e073e2a Fix indent and whitespaces 2014-09-08 17:24:55 -03:00
Renato Botelho
0b252f7a3a Fix text description for interface mismatch, fixes #3820 2014-08-21 07:31:57 -03:00
Ermal
0b5fc1d1a6 Change the logic of the vpn config generation to make connectivity more stable especially ipsec. Also for IKEv1 just generate the policies and only on traffic start them. 2014-08-07 18:53:12 +00:00
Renato Botelho
f3d8851136 Fix #3575, do not allow user to set IPs for GRE interfaces on interface edit page. 2014-07-25 12:48:17 -03:00
Ermal
1b34f8a73f Add require_once where needed to avoid redeclaration from nested includes 2014-03-20 19:26:41 +00:00
ayvis
8cd558b61b xhtml Compliance 
replaced <br>, <br/> and </br> with <br />
 2014-03-14 21:24:03 +01:00
jim-p
f6339216b7 s/require/require_once/g for filter.inc to avoid redeclaration errors in some rare cases. 2013-08-28 13:54:30 -04:00
Colin Fleming
c620c1817e Add missing quotes 2013-05-24 17:10:27 +02:00
Colin Fleming
e2ad8d0edf Tidy up "interfacess_assign.php" XHTML 
Close BR, INPUT and IMG tags
Update HTML boolean operators
Move NOWRAP to "class" statement
Deprecate the ampersand in ANCHOR tags
Add missing closing U tag
Remove closing P tag
 2013-04-15 20:07:57 +01:00
jim-p
7f07804662 Use the correct interface number (old code broke for >= 10) 2013-03-04 14:55:59 -05:00
Renato Botelho
95540233e3 Do not allow bridge members to be assigned to itself. Fixes #1153 2013-02-21 15:18:33 -03:00
Renato Botelho
ef88e1e1d8 Fix indent and whitespaces 2013-02-21 14:21:02 -03:00
Renato Botelho
e99ba2d66e Fix outbound NAT rules when interface is deleted: 
- When delete interface, do not touch outbound NAT rules
- Skip outbound NAT rules when interface doesn't exist
- Bump latest_config to 9.2
- Since rules with no interface were considered as wan, convert old
  rules adding interface 'wan' to avoid breaking old configs

It should fix #2338
 2013-01-05 12:13:55 -02:00
jim-p
b32dd0a6b7 Activate new shortcuts/status in the rest of the areas that are currently setup. 2012-08-10 13:32:16 -04:00
jim-p
198ac406ed LAN is not special here anymore. Do not remove the interface again (it was alraedy removed before this block), do not remove NAT and such (OPTs may still need it!) and no need to remove shaper. Improve DHCP check and generalize it to work on any interface, not just LAN. 2012-06-27 16:55:25 -04:00
jim-p
a7a1316811 Add small patch from #466 to make interface names clickable on Interfaces > (assign). Implements #466 2012-02-27 11:07:17 -05:00
Vinicius Coque
3f978888f0 converting from prototype to jQuery on interfaces_assign.php 2011-10-08 18:36:22 -03:00
Chris Buechler
581e4f7afd Merge branch 'master' of github.com:bsdperimeter/pfsense 2011-07-25 05:23:31 -04:00
Scott Ullrich
2a74593eee Add pre_input_errors hook to interfaces assign 2011-07-18 18:07:51 -04:00
Chris Buechler
271e9b69bb fix whitespace 2011-06-25 05:37:05 -04:00
Scott Ullrich
ca4acbcdd8 After an interface mismatch and apply actually show when we are rebooting instead of the same message that the interface mismatch exists when really the system is rebooting. 2011-06-23 14:08:38 -04:00
jim-p
144fbff2a1 Show the OpenVPN instance description when listing interfaces to assign in the gui. 2011-06-14 16:36:37 -04:00
Ermal
40b0c024db Correct code description during assignment 2011-04-28 19:16:18 +00:00
lgcosta
b877803194 Add a check if the configuration of dhcpd exists for wan before unset, resolves #1303 2011-02-22 23:32:30 -03:00
Ermal
66bcba1bcd Ticket #802. During a config restore detect if the vlan interfaces need reassignment too. This might be problematic for other type of interfaces on 2.0! 2010-12-28 22:39:51 +00:00
Erik Fonnesbeck
310a9d7bdc Confirm before deleting the interface. 2010-12-01 22:29:43 -07:00
Ermal
65c5cec3e3 Make sure we cannot add interfaces by entering the link directly on url address bar. This does the same check as the one for showing the plus button on interfaces_assign. 2010-11-30 22:16:27 +00:00
Scott Ullrich
e3feac4e91 Revert "Interface names should appear as uppercase" 
This reverts commit 66d57db5e4.
 2010-11-29 15:34:44 -05:00
Scott Ullrich
96302ebdb3 Revert "Interface names should appear as uppercase" 
This reverts commit 4cea35b344.
 2010-11-29 15:34:32 -05:00
Erik Fonnesbeck
88bc276013 Fix filter_rules_sort's compare function to know about floating rules so it won't change their order. 2010-11-10 22:43:08 -07:00
Scott Ullrich
66d57db5e4 Interface names should appear as uppercase 2010-11-06 14:11:35 -04:00
Scott Ullrich
4cea35b344 Interface names should appear as uppercase 2010-11-06 14:10:09 -04:00
Ermal
48f236320d Fixes #847. Check even interface groups before allowing deletion of an interface. Also try to readd to a group an interface when configuring. 2010-08-26 14:21:47 +00:00
jim-p
036371d201 Capitalize 2010-08-16 16:19:39 -04:00
jim-p
31b8549261 Remove these three bullet points that don't seem to make any sense on their own. 2010-08-16 16:16:40 -04:00
jim-p
1f9921aa6d Also show the save button if we have just performed an action. 2010-08-16 15:54:24 -04:00
jim-p
32600a9625 Do not escape this $ 2010-08-16 15:52:42 -04:00
Ermal
67299a3fe7 There is no need to clear this anymore. 2010-08-16 13:53:28 +00:00
Ermal
ef26b049db Fixes #823. Do not reload all interfaces, there is already code to do this for changed interfaces. 2010-08-16 12:18:34 +00:00