Commit Graph

5256 Commits

Author SHA1 Message Date
jim-p
fa628b1a15 Improve the way the auth server list is generated and account for a key being removed from the array when deleting. Fixes #7682 2017-07-10 12:15:13 -04:00
Renato Botelho
7da9f1e5fe Stop using pecl-ssh2 2017-07-06 15:27:44 -03:00
Robbert Rijkse
2f55e55156 Removed MSS clamping exclusions
(cherry picked from commit 53c26adeca)
2017-07-06 08:27:11 -04:00
jim-p
c59b2bc36d Several complaints of unbound problems after commiting, so back this out. Revert "Change the way unbound is stopped when the process is being restarted, to give the old process enough time to exit cleanly. Fixes #7326"
This reverts commit 0577d9df46.
2017-07-06 08:21:28 -04:00
jim-p
c369871083 Fix missing line from openssl.cnf 2017-07-05 15:06:57 -04:00
Renato Botelho
12e31e8726 Include User Agent information when update bogons list 2017-07-05 13:56:48 -03:00
Renato Botelho
0d3d86c8f0 Remove extra spaces from User Agent 2017-07-05 13:27:46 -03:00
Renato Botelho
48600bc6d4 Send uniqueid instead of UUID on user-agent 2017-07-05 13:22:10 -03:00
Renato Botelho
7928e41968 Declare user_agent variable in the function it's used 2017-07-05 13:22:08 -03:00
Renato Botelho
cb61e2d844 Move uniqueid read to a function system_get_uniqueid() 2017-07-05 13:00:40 -03:00
jim-p
0577d9df46 Change the way unbound is stopped when the process is being restarted, to give the old process enough time to exit cleanly. Fixes #7326
(cherry picked from commit 38d110824c)
2017-06-29 12:34:47 -04:00
jim-p
eb95f88cec unbound-control needs to know the config path or else it can't work properly. Fixes #7667
(cherry picked from commit 8a0aa42c19)
2017-06-29 12:34:47 -04:00
jim-p
86ab9eb54b Set a value for this variable in each case, so a previous value isn't re-used in a loop.
(cherry picked from commit faab657a25)
2017-06-29 10:02:22 -04:00
BBcan177
882bb24e64 Update diag_gmirror.php
Fix typo

(cherry picked from commit 55588e0ce3)
2017-06-26 10:16:26 -03:00
Phil Davis
f3f285d9a6 Issue #7659 foreach warning on adding gateway RELENG_2_3
Signed-off-by: Phil Davis <phil@jankaritech.com>
(cherry picked from commit 5c88dacbc2)
2017-06-26 10:12:21 -03:00
jim-p
c0dd390b66 Fix interface groups link 2017-06-23 08:39:26 -04:00
jim-p
751f2a7f77 Add more checks to eliminate empty config tags in package settings. Fixes #7624 2017-06-21 13:56:27 -04:00
jim-p
8cb09b2953 Match whitespace after $vhid when checking CARP status to avoid partial matches. Fixes #7638
While here, fix variable references with braces and combine the two calls to grep into a single pattern.

(cherry picked from commit fd4e14b885)
2017-06-20 10:49:50 -04:00
jim-p
bae3b2be97 Add input validation for interface names on firewall_nat_edit.php and fix encoding of the interface name in dst_change. Fixes #7651 2017-06-16 15:36:25 -04:00
jim-p
6c989d4ac2 Fix handling of the 'type' parameter so it is validated and encoded on diag_table.php. Fixes #7652 2017-06-16 15:26:22 -04:00
jim-p
d6f20c3297 Prevent the filename from being used to run XSS in the diag_edit.php file browser. Fixes #7650 2017-06-16 15:24:47 -04:00
Steve Beaver
16bf962333 Change paid support help link to new support URL 2017-06-16 07:49:09 -04:00
jim-p
d0dab7f6d5 Restore the captive portal feature to view the captive portal page directly from the portal web server. Add this as an additional button so both methods are possible. Fixes #7646 2017-06-14 10:30:25 -04:00
jim-p
4122033534 Redact BGP MD5 password/key in status output. Fixes #7642
(cherry picked from commit aa18c5b9b6)
2017-06-13 13:11:55 -04:00
jim-p
be263d6c8b Don't remove examples from packages as obsolete, some packages rely on the files being there.
(cherry picked from commit 835d8b72ef)
2017-06-12 14:48:41 -04:00
Martin Hagelin
407f0b854e Fix DNS wildcard support for Loopia
Fix for the problem that wildcard CNAME records disappear from Loopia when doing a DNS update. As discussed here: https://forum.pfsense.org/index.php?topic=67793.0
2017-06-09 08:32:32 -04:00
Renato Botelho
3ca5945685 Fix preg_match call without delimiter and also use preg_quote() to variable used in pattern 2017-05-30 07:44:52 -03:00
stilez
ce5e28672e Don't create system notices for errors in user-entered ad-hoc PHP (diag_command.php)
(cherry picked from commit ff4e29fb9d)
2017-05-29 15:20:48 -03:00
stilez
39dc4fc510 Various updates to PR
1) convert echo to print, and add infobox, as requested in PR comments
2) If no identifiable line number, say so
3) EVAL gives an error message format that wasn't picked up, it is now. Test case - enter as the code:  eval("X");
4) Warn that EVAL gives a "spurious" "error at line 1" as well, the real error is in the (...). See above test case for this.
5) Simplify translators' job a bit
6) Try to reduce errors in user code giving NOTICES (see PR comments). Start by defining a dir for user code (only) and putting code in it.
(cherry picked from commit 1155cd6318)
2017-05-29 15:20:46 -03:00
stilez
ad6be377ed create global for user code dir, in diag_command.php
Going to try and stop user code generating notices, by putting it in a specific dir which doesn't give notices for syntax errors.
(cherry picked from commit 8d80a771e3)
2017-05-29 15:20:44 -03:00
stilez
6be84d7fd5 add comment
(cherry picked from commit d2d58d6ad1)
2017-05-29 15:20:42 -03:00
stilez
1ca0f7f7a0 typo
(cherry picked from commit 4711322b4a)
2017-05-29 15:20:41 -03:00
stilez
5c1fea1711 If user-entered PHP errors out, display the error line in context to help the user
If the user enters PHP in the command-line page, and it errors out, it's usually a typo or something minor. But the user is left with an error that references a /tmp file which doesn't exist at the point they read the message, a line number that's incorrect, and their input which doesn't display line numbers anyhow.

This patch fixes this, so that a user who wants to enter php command-line in the GUI and gets an error, can quickly identify the exact line causing the error.

If an error occurs (detected by either non-zero return value or output matching an error message referencing the temp script file), then an short DIV is shown above the usual PHP output for "error location". It gives the correct error line number, and shows the code with line numbers and syntax highlighting (using php's native "-s" option), pre-scrolled to the error line.
(cherry picked from commit fd1bd705c5)
2017-05-29 15:20:40 -03:00
Yoann Lecuyer
b4ff414aef Removed htmlspecialchars when loading leases from config
(cherry picked from commit 2322e9f3cb)
2017-05-29 15:20:11 -03:00
PiBa-NL
afe8afac75 auth_check, faster authentication check while automatically refreshing diag_routes
(cherry picked from commit 60ba7c7642)
2017-05-26 11:56:20 -03:00
PiBa-NL
183c713b3c auth_check, move the cmp_page_matches() to its own file so it can be shared by both auth_check.inc and priv.inc
(cherry picked from commit ddd54e83f2)
2017-05-26 11:55:38 -03:00
PiBa-NL
a4c64e37cf auth_check lowers cpu usage for checking if the user has permission for the page requested when used in place of guiconfig, especially useful for frequent requests like those made by stats and traffic widgets
(cherry picked from commit c07071cbca)
2017-05-26 11:55:37 -03:00
Phil Davis
2c4865e3fa Add missing break for cloudflare case
(cherry picked from commit d900381c93)
2017-05-26 11:54:55 -03:00
Phil Davis
543ea703f2 Integrate various cloudflare changes
(cherry picked from commit 5ce6ce4b1a)
2017-05-26 11:54:54 -03:00
Phil Davis
2e294992e4 Diag DNS disable Add Alias button when host field is changed
(cherry picked from commit 45eafdbd7b)
2017-05-23 13:59:24 -03:00
Lorenz Schori
12ca33f4dc Remove stray debug-code (/tmp/script)
(cherry picked from commit a29361a2d9)
2017-05-23 13:57:43 -03:00
PiBa-NL
3af287f33a virtualips, ability to sort the table
(cherry picked from commit 77c53e65fb)
2017-05-23 13:55:14 -03:00
Phil Davis
4c4504b1e7 Make consistent rule information section
(cherry picked from commit f0dc8b688c)
2017-05-23 13:54:30 -03:00
jim-p
b44ee60da8 Add download button/function directly on status.php to ease confusion.
(cherry picked from commit f7a72733f8)
2017-05-23 12:52:30 -04:00
PiBa-NL
eb65e543b4 pkg_edit, fix empty config tag check
(cherry picked from commit 6bf2a65086)
2017-05-23 13:42:24 -03:00
Phil Davis
e78a436c55 Diag DNS fix update alias button text after add alias
1) Lookup a name with Diag DNS
2) Press "Add Alias"
The alias is added, but the button still says "Add Alias".

Actually the alias exists by now. The button should say "Update Alias".

Fix: once we have emitted the alias create/update success message, we can set $alias_exists true so that the rest of the code is based on the (possibly new) state.(cherry picked from commit 474b275684)
2017-05-23 13:41:54 -03:00
Phil Davis
f54a3ede59 Diag DNS do not show Add Alias if no priv to add alais
(cherry picked from commit 7fcccc8f09)
2017-05-23 13:41:15 -03:00
Phil Davis
14e90f2e5d Diag DNS do not create an empty alias if name does not resolve
(cherry picked from commit f445385114)
2017-05-23 13:40:25 -03:00
jim-p
2e7f67b274 Add NGID to status.php
(cherry picked from commit fcc24426ab)
2017-05-23 12:13:00 -04:00
Renato Botelho
03af3cfd44 Use recently added hwaddr field to restore original MAC address 2017-05-19 13:21:46 -03:00