Commit Graph

11800 Commits

Author SHA1 Message Date
Chris Buechler
f8d1587b6e Merge pull request #882 from derelict-pf/cp-nohttpsforwards
Add checkbox and logic to disable forwarding HTTPS/SSL (Port 443)
2014-01-09 00:18:49 -08:00
Renato Botelho
51922cb793 Add 'limited' to ntpd restrict list to workaround CVE-2013-5211. It fixes #3384 2014-01-07 08:58:48 -02:00
jim-p
0959b4d3ac This might also say "icmpv6" here and lead to a bad rule. 2014-01-06 12:08:36 -05:00
Ermal
762b34c472 Do not allocate the same pipe to everyone rather give each person its own! 2014-01-03 15:05:33 +00:00
Ermal
c8d611ed35 Use empty here for testing even if the setting is unset 2014-01-03 14:52:49 +00:00
Ermal
d68494e6ed Correct the check to what was intended 2013-12-27 21:34:16 +00:00
Ermal
53555bf2f7 Make sense of interface mtu handling code. No need to do unneeded operations. This fixes slow boot times and proper handling of mtu for vlans though some work or better model is needed for other interface types. 2013-12-27 20:37:34 +00:00
Renato Botelho
14be28af75 No reason to set the same value to ipprotocol 2013-12-27 12:58:10 -02:00
Ermal
141254eb9a Use empty even here 2013-12-26 20:54:26 +00:00
Ermal
fed1b37258 Check if there is a value before trying to do any operation 2013-12-26 20:28:23 +00:00
Ermal
9e63dca959 Use intval even here 2013-12-24 16:28:15 +00:00
Ermal
b0ae52134e Use intval here to not trust php and also use empty which gives more protections 2013-12-24 16:25:57 +00:00
Renato Botelho
e675625187 Remove /var/run/booting early to be consistent with $g['booting'] 2013-12-24 13:06:44 -02:00
Renato Botelho
f9dfaeaeb2 Revert "Make sure functions called by rc.start_packages can see $g['booting'] when we are booting"
This reverts commit 5eb99ec9fa.
2013-12-24 13:04:34 -02:00
Renato Botelho
0450ae5564 Revert "Only unset $g['booting'] when it was set here"
This reverts commit 73abb573fe.
2013-12-24 13:04:33 -02:00
Renato Botelho
73abb573fe Only unset $g['booting'] when it was set here 2013-12-24 12:43:10 -02:00
Renato Botelho
5eb99ec9fa Make sure functions called by rc.start_packages can see $g['booting'] when we are booting 2013-12-24 12:17:03 -02:00
Ermal
e049c5e74f unset these values to not confuse php 2013-12-24 10:28:26 +00:00
Ermal
3f2ae9d58f Properly initialize this 2013-12-24 10:23:57 +00:00
Ermal
4fd85b115e Switch to a while loop to make things clear and readble. Also properly set zone dedicated rules in the rules/pipes DBs to properly release when a zone is deactivated 2013-12-24 10:22:54 +00:00
Ermal
27cea9a385 Remove not relevant comment now. Also make the operation clear to avoid priority issues. 2013-12-24 10:00:05 +00:00
Renato Botelho
f2aa828754 Remove 'deny unknown clients' option from DHCPv6 since it's not supported, it fixes #3364 2013-12-23 14:40:58 -02:00
jim-p
db817c937c Make sure to give the zone a name during the upgrade, or else it comes through with a blank/null name. 2013-12-23 11:15:28 -05:00
derelict-pf
e98daec596 Add checkbox and logic to disable forwarding HTTPS/SSL (Port 443)
connections to the captive portal if HTTPS logins is enabled.
2013-12-20 17:25:02 -08:00
Ermal
27a015571a Use proper function to check for ipaddr and also do not call the module ip set function since its only v4 fro now 2013-12-18 22:00:35 +00:00
Ermal
6a3b460168 Correct removing the ip addresses from an interface! 2013-12-18 21:59:19 +00:00
jim-p
e183e1cee7 Reduce the total minutes by the remote minutes used, do not use the value directly. Otherwise the voucher will be cut short or listed invalid when it otherwise should have time left over. 2013-12-17 14:38:31 -05:00
Phil Davis
b3b3d115cc Check that DHCP end IP is >= DHCP start IP 2013-12-09 09:49:33 -02:00
Phil Davis
2c71286836 Use correct vars for IPv6 when checking subnet start and end 2013-12-09 09:49:25 -02:00
Phil Davis
9b74931109 Fix checking DHCP end IP is in range
Cut-paste bug
2013-12-09 07:08:20 -02:00
Ermal
e08ba4bba6 Load only the options rather than clearing the whole ruleset. This solves a problematic issue on 2.1 2013-12-06 14:05:03 +00:00
Renato Botelho
9401e47c26 Check if dhcp start and end addresses are inside interface subnet, helps #3196 2013-12-06 09:43:18 -02:00
Renato Botelho
9d1225a90a Add function is_inrange() that calls is_inrange_v6 or is_inrange_v4 accordingly 2013-12-06 09:43:08 -02:00
Renato Botelho
97049b79c9 When user attempt to set network or broadcast address, ask again for the IP address. Issue #3196 2013-12-06 09:39:50 -02:00
Renato Botelho
21d74c8e79 Prevent network or broadcast address to be set on interface (console, GUI and wizard). It should fix #3196 2013-12-04 18:21:30 -02:00
Renato Botelho
1ebb561de3 Remove 0.0.0.0 from automatic outbound nat rules 2013-11-28 16:43:35 -02:00
Renato Botelho
4c91880c59 Fix 0.0.0.0 mask for automatic outbound NAT 2013-11-28 08:55:27 -02:00
Renato Botelho
82d1a33e4a Fix #3331. Set interface subnet as destination when VIP is in the same subnet, otherwise use VIP subnet instead of IP address 2013-11-21 13:57:53 -02:00
Renato Botelho
1ad6ad279f Fix an issue that changes wrong gateway entry when items are hidden 2013-11-21 09:36:50 -02:00
jim-p
186ab4ea1a Don't flush interface cache on each call of the function when looping through all gateways. 2013-11-20 15:56:42 -05:00
Renato Botelho
58fac6951c Add subnet to 0.0.0.0 otherwise it's not added to table, ticket #2416 2013-11-18 16:42:29 -02:00
Renato Botelho
6b1f9a9941 Many fixes on privileges, ticket #3216:
- Remove unused privilege page-diagnostics-logs-wireless
- Remove duplicated privileges
- Fix limiter-info, pf-info and system-pftop that were using wrong name
- Add privs for services-igmpproxy-edit
- Fix ID for acptiveportal allowedhostnames and editallowedhostnames
- Fix some wrong matches
2013-11-15 19:30:31 -02:00
Renato Botelho
4e38f1c26b Remove unused variables and fix automatic nat to alias-address 2013-11-13 10:36:02 -02:00
Renato Botelho
ed25d803bf Add missing count increment 2013-11-13 10:21:23 -02:00
Phil Davis
d07a2a2a67 Handle comma-separated list of remote networks when making vpn_networks table
If remote_networks for an OpenVPN instance is a list of more than 1 network then none of the networks gets added to the vpn_networks table. The code simply did not address this new comma-separated list feature. Now it does, and the vpn_networks table contains all the remote networks listed.
Related to forum thread: http://forum.pfsense.org/index.php/topic,66776.msg377169.html#msg377169
and bug report #3309 - but from the bug report, there might be some other issue to be addressed also.
2013-11-12 15:06:44 -02:00
jim-p
2ffc7dc3cf Rework the usage of the shell i/o during stop_packages(), fixes the "Syntax error: bad fd number" for the remaining people who still saw it on shutdown 2013-11-11 16:27:35 -05:00
jim-p
793299b8f5 This tag could be present, but empty. Skip processing if the interface has no IP address. 2013-11-11 13:11:17 -05:00
jim-p
58ee84b4b2 If the interface is configured and not enabled, bail. We do not need to change settings for disabled interfaces. Fixes #3313 2013-11-11 13:10:46 -05:00
Ermal
892d23bc7a Unset this variable used in the loop to avoid having wrong information 2013-11-07 19:35:30 +00:00
Ermal
a00acb4c9f Do not forget the trace in the pf.conf that something went wrong during rules generation to be able to at least detect what is going on 2013-11-07 19:27:07 +00:00