Commit Graph

12392 Commits

Author SHA1 Message Date
Phil Davis
9241d942b9 Typo CIDR in UPnP GUI page
As reported by johnpoz https://forum.pfsense.org/index.php?topic=84964.0
2014-12-07 19:10:59 +05:45
Phil Davis
95d045fcd7 Set text and color of Gateways Widget Status
getstats.php calls functions.inc.php get_stats(), which calls get_gatewaystats().
get_gatewaystats() now returns the text for each field and an optional color separated by "/" - "text/color" e.g. "Online/#90EE90"
Parse the the new format, separating out text and color.
If color is specified, then also set it with jQuery to css.
2014-12-05 17:54:30 +05:45
Phil Davis
beb7d9e332 Explicitly pass gateway status and color
This code was passing a whole load of html to attempt to set various properties of the Gateways Widget Status column so that it would display the new status (Online, Offline...) and in the appropriate color.
Now that I am using class=listr, the css fro listr already specifies white. Setting bgcolor in HTML does not override that.
Pass both the status text and color as ordinary text, separated by "/". The consumer of this output can do their thing with jQuery to set the color as well as text of the element.
2014-12-05 17:43:48 +05:45
Phil Davis
6404148cf3 Use proper listr class for Gateways Widget Status
The Gateways Widget Status was not using the listr class, and so it was missing the borders for the right and bottom of its box.
Use the listr class.
Then use javascript to explicitly set the background-color to match the status, overriding the white that is specified in listr.
2014-12-05 17:36:49 +05:45
Phil Davis
5eeee40fb8 Fix gateway widget status update
Redmine #4077
2014-12-05 13:40:52 +05:45
Jean Cyr
ad62d077a3 Don't include link-locals as unbound interface candidates
Unbound does not presently support link-local interfaces.
2014-12-04 13:07:22 -05:00
Phil Davis
f0eef2ef62 Provide friendly descr in error message in Interfaces Assign
I was doing drastic things testing some stuff, swapping WAN and OPT1 interfaces in Interfaces->Assign. I accidentally pressed Save when I had the same real device selected for both. Thankfully there was input validation! But I noticed that the error message reported just the names WAN and OPT1, but actual I had them named as different things. So the names in the error message did not match the names (friendly descriptions) in the table of interfaces.
This change makes it display both like FRIENDLY_DESC (FRIENDLY_NAME) so there is less room for confusion.
2014-12-04 16:16:05 +05:45
Renato Botelho
99a8036453 Merge pull request #1363 from phil-davis/patch-3 2014-12-04 08:01:10 -02:00
Phil Davis
62a407dad5 Put -4 in the right place in ntpq clockver command #4074
I had pasted it in here between "-c" and "clockvar", that was not good.
That's all I have for #4074 (I hope)
2014-12-04 13:50:11 +05:45
Phil Davis
c2914fc984 Use IPv4 for ntpq if IPv6 not allowed in widget #4074
Similar code here. Shame it was not in a subroutine called from both places, but not about to re-engineer that now:)
2014-12-04 13:44:20 +05:45
Phil Davis
e4a496ae8f Use IPv4 for ntpq if IPv6 not allowed
Forum: https://forum.pfsense.org/index.php?topic=84890.0
2014-12-04 11:26:45 +05:45
Phil Davis
efa2869209 Display installed pkg version even if pkg server not available
Forum: https://forum.pfsense.org/index.php?topic=84820.0
It seems reasonable to me to display the currently installed package version numbers, along with text like "Latest: N/A". and the Version box being red-filled when someone goes to System->Packages and displays the installed packages but the package server is not reachable for some reason.
This code does it.
What do you think?
2014-12-03 17:27:58 +05:45
Chris Buechler
a94b1edc7f Merge pull request #1348 from phil-davis/patch-4 2014-12-02 21:35:54 -06:00
Ermal LUÇI
110967a4ba Try to not make useless entries in the config file for very rare used configuration values. Makes config file readble and with less size 2014-12-02 12:35:36 +01:00
Chris Buechler
c5cd9b7503 validate MTU and MSS as integers, and don't allow MSS larger than pf will accept to avoid broken rulesets. 2014-11-28 19:33:30 -06:00
Chris Buechler
a96dc32e35 Add input validation on vpn_ipsec_settings.php. Fixes #4052. 2014-11-28 19:17:18 -06:00
Chris Buechler
b7960673be Fix input validation for DNS resolver when localhost is enabled in resolv.conf and "all" chosen in Network Interfaces. While here, set something other than '' when all is chosen. 2014-11-28 15:54:58 -06:00
Ermal LUÇI
4854e3a22b Remove these booting settings since are useless 2014-11-28 13:04:28 +01:00
Chris Buechler
f865302fe3 Add input validation to Unbound advanced settings page. Ticket #4050 2014-11-28 02:10:43 -06:00
Chris Buechler
823cabba18 Validate as integers, not just numeric, to prevent possible breakage. 2014-11-28 00:47:19 -06:00
Chris Buechler
f8f5ba1a1f Add option to disable auto-added access-control entries for users who want to manually manage ACLs. Ticket #4023 2014-11-27 22:10:48 -06:00
Ermal LUÇI
5d4b883068 Unset any previous dat 2014-11-27 21:44:35 +01:00
Ermal LUÇI
e6283dfd0c Use the pfsense module functions rather than execing. Fixes also possible attack vectors. 2014-11-27 21:44:01 +01:00
Ermal LUÇI
0174c48022 Use the pfsense module functions rather than execing. Fixes also possible attack vectors. 2014-11-27 21:44:01 +01:00
Ermal LUÇI
5e0a3256b2 convert_real_interface_to_friendly_interface_name() goes and checks the parent and this gives wrong information 99.9 percent of the time on scenarios like when this is called for unassigned vlans etc, while its real purpose is just to check if the interface is assigned and return the intermeddiate/config name of the interface. Leave the get_parent_option there in the function but it needs to be asked specifically for. 2014-11-26 20:34:28 +01:00
jim-p
4f5577f662 Fix JavaScript confirmation dialog for EasyRule. 2014-11-26 14:18:09 -05:00
Ermal LUÇI
94b0ac1c00 Remove a blank row in the tab display during firmware update 2014-11-26 15:21:00 +01:00
Ermal LUÇI
32e834ffd3 Reorder the inclusion of headers so that globals.inc comes first 2014-11-26 12:41:50 +01:00
Chris Buechler
edee528c53 Send the gateway name to this function. Fixes #4047 2014-11-25 23:42:53 -06:00
Chris Buechler
f1a6f696b4 If localhost is configured to be included in resolv.conf, force its selection in Unbound. The resolv.conf logic prevents that from being a problem, but people don't seem to realize they have to pick that to use Unbound for the host itself. Force it here rather than just silently skipping its inclusion in resolv.conf. 2014-11-25 21:12:49 -06:00
Chris Buechler
f72fce18ec fix text here, variables came back empty and aren't all that useful here anyway. 2014-11-25 19:36:07 -06:00
Chris Buechler
563ea7ea9a only show aggressive/main mode for IKEv1 2014-11-25 16:16:39 -06:00
Ermal LUÇI
8e87f7140a Unset the aggressive mode settings for not IKEv1 settings 2014-11-25 21:43:47 +01:00
Chris Buechler
79f4c97009 fix IPsec widget status display after recent changes broke it. Ticket #4045 2014-11-25 13:30:59 -06:00
Ermal LUÇI
2d2e466c2b Show Mtu on status interfaces. 2014-11-25 20:23:30 +01:00
Ermal LUÇI
bc8f326432 Ticket #2786 there is an issue with convert_real_interface_to_friendly_interface which might return not expected data as in the situation checked for vlan case her ein the validation. Avoid for this case here the issue to allow properly setting mtu on vlans with not assigned parent. 2014-11-25 19:23:53 +01:00
Phil Davis
8ce58e05f0 Option for browser tab text order 2014-11-25 22:16:06 +05:45
Phil Davis
0274d41abe Option for browser tab text order
Easy thing to do - add an option for the user to select if they want the host name or page name text to display first in the browser tab.
Forum: https://forum.pfsense.org/index.php?topic=84528.0
2014-11-25 22:14:06 +05:45
Chris Buechler
24aa9e4064 fix up text 2014-11-24 23:37:56 -06:00
jim-p
efed74dab4 Make this note more accurate. 2014-11-24 16:23:04 -05:00
Ermal LUÇI
2f851abff9 Fixes #4039 remove the toggle from IPSec settings since its not anymore useful. 2014-11-24 22:07:38 +01:00
Ermal LUÇI
f07008f559 Fixes #4037
Revert "Do not let the user mess with SAs from this page. The daemon and primary status page handles tat"

This reverts commit bb55330aca.
2014-11-24 21:54:00 +01:00
Ermal LUÇI
0771969b40 Fixes #4015. Hide Negotiation mode when in IKEv2 since it is not required. 2014-11-24 09:44:44 +01:00
SunStroke74
cfbe7e091f Removing extra closing bracket 2014-11-24 00:35:40 +05:00
Chris Buechler
e840fc8cd0 Don't unset these items for PPP configurations as they're not configured here and doing so loses settings configured in interfaces_ppps_edit.php. Ticket #3727 2014-11-22 13:24:51 -06:00
Renato Botelho
15fbb5ecf3 Fix ovpn-linkup for tun + topology subnet case setting router as ifconfig_local envvaar when route_vpn_gateway and ifconfig_remote are both not defined. Keep using 5th parameter as a seatbelt in last case. While I'm here, improve sh syntax. It should fix #3968 2014-11-22 17:13:02 -02:00
Chris Buechler
68ce5a28f8 phone number is a required field 2014-11-22 13:03:48 -06:00
Chris Buechler
b7b3f34314 fix up text 2014-11-22 01:15:12 -06:00
Chris Buechler
5b506a493f Fix input validation of custom-type dynamic DNS hostnames. 2014-11-21 12:27:45 -06:00
Ermal LUÇI
e3cffd6cef Properly remove IPv6 carp vips as reported from https://forum.pfsense.org/index.php?topic=84392.0 2014-11-21 11:20:46 +01:00