Commit Graph

11325 Commits

Author SHA1 Message Date
Renato Botelho
ce9d5d7255 Protect servicestatusfilter parameter with htmlspecialchars() 2014-06-17 15:13:42 -03:00
Renato Botelho
860b102acb Protect rssfeed parameters with htmlspecialchars() 2014-06-17 14:53:50 -03:00
Renato Botelho
62480a449e Avoid directory traversal on restorefullbackup 2014-06-17 13:47:46 -03:00
Matt Smith
7be297a2ce Fix core dump on viewing invalid package log 2014-06-17 11:30:53 -05:00
Renato Botelho
1cfe54900a Remove . and / from pkg name to avoid directory traversal 2014-06-17 11:17:15 -03:00
Renato Botelho
73944f6824 Remove id=0 from miniupnpd menu and shortcut 2014-06-17 10:48:21 -03:00
Renato Botelho
9ddd3418da Avoid directory traversal when reading package xml files, also check if file exists before try to read it 2014-06-17 10:33:05 -03:00
Renato Botelho
aa27de6e78 Make sure variables are escaped, also replace exec calls to run rm by unlink_if_exists() 2014-06-17 10:19:34 -03:00
Renato Botelho
592abfa4a4 Remove useless code, variable is set again on next line 2014-06-17 10:18:44 -03:00
Renato Botelho
e41ab9aa32 Escape parameters passed to shell_exec() 2014-06-17 09:40:06 -03:00
Renato Botelho
ee4ba9fba1 Be more careful with host parameter and make sure it's escaped when call shell functions 2014-06-17 09:28:35 -03:00
Renato Botelho
54a9da9fce Validate starttime and stoptime format 2014-06-17 07:34:03 -03:00
Renato Botelho
f5629ea6b8 Be more precise to match members of a bridge interface, it should fix #3637 2014-06-10 14:21:16 -03:00
Renato Botelho
6da518fcee Do not allow interface group name to be bigger than 15 chars, helps ticket #3208 2014-06-09 15:32:24 -03:00
Renato Botelho
4cc342453c Add some protection to parameters that come through _GET 2014-06-06 11:53:21 -03:00
Chris Buechler
bc76b18eb9 remove openbgpd bits from system_gateways_edit and system.inc. The package
match is case-sensitive and hasn't matched the openbgpd package's name in
at least 5 years, so it doesn't do anything. It's far from functional in
any useful manner even fixing that issue.
2014-05-30 19:57:51 -05:00
Renato Botelho
268258b5aa Unset iflist and iflist_disabled 2014-05-29 10:53:28 -03:00
Renato Botelho
22ed6e3eab Show disabled interface when it was already part of interface group, it avoids to show a random interface instead and let user to add it by mistake. It should fix #3680 2014-05-29 08:53:05 -03:00
Chris Buechler
ad57eacf87 add guiconfig to widgets not including it. ticket #3498 2014-05-14 10:37:29 -05:00
Chris Buechler
d3fa8a8775 remove text not relevant to Allowed IPs. Ticket #3594 2014-05-14 10:27:11 -05:00
Renato Botelho
29282ddc09 Merge pull request #1131 from razzfazz/make_upnp_listen_on_if_optional 2014-05-09 14:57:17 -03:00
Renato Botelho
91946ea44d Merge pull request #1130 from razzfazz/status_upnp_int_port 2014-05-08 18:41:20 -03:00
Renato Botelho
7e736f3850 Fix #3646, Revert part of 082c9d961e and fix highlight selected rules 2014-05-08 07:50:07 -03:00
Daniel Becker
d973a602ab make listening on interface rather than IP optional for miniupnp 2014-05-06 17:27:36 -07:00
Daniel Becker
a0dd23e0dc add column for internal port on UPnP status page 2014-05-05 15:35:32 -07:00
Phil Davis
b6ba57f67e Fix Bug #3627 Diagnostics: Tables - Remove button dont work after update to PfSense 2.1.2
This annoyed me also, so I thought it worth finding what changes exactly broke this.
del_entry was broken on 2.1 branch by fe3088b965
These 2 small changes make it work again without needing to reverse the other bits of stuff in that commit.
Note that Master does not have that commit at all. There are lots of these "XHTML Compliance" and similar commits in 2.1 branch that are not done in master. I don't understand why that is. Why don't those code cleanups also need to be applied to master?
2014-04-30 22:45:18 -07:00
Renato Botelho
19166f7d2d Check the right field here 2014-04-29 15:36:33 -03:00
Renato Botelho
2ae503264c Unbreak 'add rule on top of the list' allowing after param to be -1 2014-04-29 14:56:49 -03:00
Renato Botelho
2db29614d2 Move clog from /usr to /usr/local
Conflicts:
	etc/inc/filter_log.inc
	etc/inc/system.inc
	etc/rc
	usr/local/www/guiconfig.inc
2014-04-28 11:56:06 -03:00
Daniel Becker
b1c9aff653 make miniupnpd listen on interface instead of IP
The 'listening_ip' option in miniupnpd.conf can accept an interface name
directly instead of having to translate it to an IPv4 address first. (This is
actually required if IPv6 support is enabled.)
2014-04-27 16:09:50 -07:00
Chris Buechler
549b7ce250 Don't refuse to delete a bridge in the GUI just because its bridge interface doesn't exist, just log that it doesn't exist and don't attempt to ifconfig destroy it, delete it from config 2014-04-26 17:20:32 -05:00
Ermal
2f0401aff5 Remove problematic code without proper checks but even not needed here 2014-04-18 14:34:00 +00:00
Phil Davis
f4065455b0 List GWGs in Interface to send update from
Back-port of this fix done in master 31300a95f7 and 8f56dd2794
Unfortunately this never got back-merged to 2.1 branch. A user on the forum noticed the issue again on 2.1.1 - https://forum.pfsense.org/index.php?topic=74922.0
I am submitting this so that when the next security issue happens, and there is 2.1.n+1 then this little fix will also happen automagically. I wonder what other fixes are in master that missed being back-ported to 2.1 branch.
2014-04-09 17:58:10 -07:00
jim-p
d22169cfd6 Use an alphanumeric test rather than purely is_numericint because the ID is generated by uniqid and is not purely numeric. Fixes #3591 2014-04-09 08:45:31 -04:00
Marcello Coutinho
251a12460e fixes Bug #3569
On packages that uses row_helper when user clicks on add or delete button, the page scrolls to top.
It seems something with ajax
http://stackoverflow.com/questions/1061580/jquery-click-on-anchor-element-forces-scroll-to-top

A simple return false after jquery action fixes the unwanted scroll.
2014-04-04 10:04:57 -03:00
Renato Botelho
2def89a2dd Fix #3555, on chrome it is not initializing correct minutes when adding a new time, just drop unused php variables and set it on js 2014-03-31 16:39:15 -03:00
Renato Botelho
02b29d72f9 Revert "XHTML Compliance"
This commit broke schedules edit, it should fix #3555.

This reverts commit e1002cd272.
2014-03-31 09:56:17 -03:00
jim-p
013b4695d0 Handle the reinstallall case with confirmation. Fixes #3548 2014-03-27 10:10:04 -04:00
Renato Botelho
51b2f811ae Fix days and weeks selection on schedules, reported at https://forum.pfsense.org/index.php?topic=74101.0 2014-03-25 16:06:52 -03:00
Renato Botelho
b121ffad22 Only consider javascript files that ends with .js 2014-03-25 12:29:01 -03:00
Renato Botelho
9ebe5b7c27 Detect Zones and Cores for thermal sensors using regex, it fixes #3337 2014-03-21 09:31:12 -03:00
Chris Buechler
141566ffb6 remove unused supportedbybsdperimeter tag 2014-03-21 01:07:26 -04:00
Chris Buechler
ebfb0929d1 s/BSDP/ESF/ 2014-03-21 01:02:50 -04:00
Renato Botelho
e538fc1844 Automatic outbound NAT rules skip openvpn interfaces, lets skip them when creating the first set of manual rules too. It fixes #3528 2014-03-18 15:09:45 -03:00
Chris Buechler
358b6cdcd2 standardize URLs 2014-03-14 19:36:27 -05:00
Chris Buechler
b1d64b46e3 standardize URLs 2014-03-14 19:33:49 -05:00
Chris Buechler
1aadf5d547 standardize URLs 2014-03-14 19:29:53 -05:00
Chris Buechler
e564437727 standardize URLs 2014-03-14 19:28:27 -05:00
Chris Buechler
c3abc75aca standardize on https://www.pfsense.org 2014-03-14 19:16:32 -05:00
Chris Buechler
d1ec51ba61 standardize pfsense.com references to https://www.pfsense.org 2014-03-14 19:07:28 -05:00