Since https://redmine.pfsense.org/issues/1835 got exactly nowhere for the past 4 years, the input should be properly validated, instead of allowing people to configure nonfunctional/broken nonsense.
P.S. If you don't plan on fixing the above-linked feature for 2.3, let me know and I'll do the same for 2.3
This was fixed in master for 2.3 by 50e6c063e6 - in master all of these $tab_array entries, in each file that they appear in, had been modified to just use the $tab_array[] = form.
But in RELENG_2_2 that has not happened. So it seems nicer to just fix the numbering here to match what is already in the other interfaces_*.php files in RELENG_2_2.
Note that the code works OK without this "fix" - display_top_tabs() just loops through the existing array keys anyhow and so did not notice the missing number.
/usr/local/sbin/ppp-ipv6 <real interface> up|down
Interface using SLAAC or DHCP6 going down:
* bring down dhcp6c if it is running
* disable router advertisements (and therefore SLAAC)
* remove any autoconfigured IPv6 addresses
Interface using SLAAC or DHCP6 coming up:
* call interface_dhcpv6_configure() if dhcp6c not running and router advertisements off
interface_dhcpv6_configure() will enable router advertisements,
configure rtsold and dhcp6c, then set rtsold to prime dhcp6c as
required.
This code checks if the user has somehow posted a group deletion for a group that has "system" scope. If so, then the delete is not done and an input error is displayed.
Note that in normal use the group manager page does not display a delete button for "system" groups, so normally this does not happen - only if the user manually messes with the $POST variables.
This code checks if the user has somehow posted a user deletion for a user that has "system" scope. If so, then the delete iscnot done and an input error is displayed.
Note that in normal use the user manager page does not display a delete button for "system" users, so normally this does not happen - only if the user manually messes with the $POST variables.
I noticed this while comparing alias popup behavior between 2.2.5-DEVELOPMENT and 2.3
Might as well fix the grammar here for 2.2.5
This tip does not exist in 2.3 because the popup works more nicely there and so this text is not needed.
Therefore this change does not need to be ported forward to master.
The correct text is already displayed under the DNS server boxes at line 892.
This should also be done to master once the conversion of services_dhcp.php to bootstrap is stable.
Backport from PR #1906 / PR #1787 for RELENG_2_2.
Check if the actual $fieldname element is present in the $a_pkg[$id] array before trying to assign its value. Do same with default_value. Fixes issue where default value was not being populated for newly added fields.
