Commit Graph

214 Commits

Author SHA1 Message Date
Colin Fleming
e3e1f7480f Tidy up "pkg_mgr_install.php" XHTML
While using the widescreen theme, when you update the firmware or add a
new package the TEXTAREAs are side-by-side which doesn't look neat.
Add BR tag between TEXTAREA
2014-09-14 12:49:05 +01:00
jim-p
bfe9c9e7a3 Move the fetching of a package's config file and additional files to separate functions, and then have the "xml" package button perform these so that it is not only a redundant copy of the "pkg" reinstall button. This can help ensure a package files are in a known-good state before other actions are performed, in case the deinstall would fail or behave erratically due to other files being missing. 2014-08-19 14:32:46 -04:00
Renato Botelho
7145cd87d1 Remove . and / from pkg name to avoid directory traversal 2014-06-17 11:17:23 -03:00
jim-p
544a89c5d1 Handle the reinstallall case with confirmation. Fixes #3548 2014-03-27 10:16:02 -04:00
Renato Botelho
7f7626ba44 Merge branch 'master-br' of https://github.com/ayvis/pfsense into ayvis-master-br 2014-03-17 11:17:29 -03:00
Chris Buechler
34e2973ed9 standardize URLs 2014-03-14 19:33:03 -05:00
ayvis
8cd558b61b xhtml Compliance
replaced <br>, <br/> and </br> with <br />
2014-03-14 21:24:03 +01:00
Renato Botelho
d291634ad9 Take single and double quotes into consideration 2014-02-18 16:38:35 -03:00
Ermal
133f8b3347 Fixes #3460. Ask for validation when real operation will be done and ask for the operation with POST to get protection from CRSF. 2014-02-18 16:39:59 +00:00
Ermal
0635519b6e Remove code that is commented 2014-02-18 16:39:59 +00:00
Ermal
6766e4771e Fixes #3461. Remove any special char that can lead to shell/XSS compromises from submitted input. 2014-02-18 13:18:33 +00:00
Renato Botelho
7bc1b96813 Remove remaining hardcoded theme names 2013-07-17 12:29:06 -03:00
Colin Fleming
600933eee3 Tidy up "pkg_mgr_install.php" XHTML
Add start and TR tags
Tidy up the TABLE tag, move height and colspacing in to STYLE paramenter
Update TD tag with correct background syntax
Move end BODY and end HTML tags to the end of the file, this helps
reduce the error count.
2013-04-08 19:59:39 +01:00
bcyrill
633d51b75c Add version check to package install 2013-01-17 19:36:17 +01:00
jim-p
33ba41314b Sanitize some variables
Discovered-By: Yann CAM
2012-10-04 09:14:48 -04:00
Phil Davis
06aa745e29 pkg_mgr_install - only mount rw when needed
When entering pkg_mgr_install the filesystem was being mounted rw and a backup made of the config, even if the case was "showlog" or "installedinfo". This resulted in:
a) an extra "backup" of the config being made after an install - it could be seen in Diagnostics, Backup Restore, Config History
b) Unnecessary conf_mount_rw and conf_mount_ro calls. These slow down the process on nanobsd-like systems.
This change fixes both these issues.
2012-08-03 13:39:16 +05:45
jim-p
2229d94e84 This is apparently breaking reinstalls. Revert "Actually make reinstallpkg remove the bionaries and really reinstall them"
This reverts commit 12b0fa564d.
2012-06-15 22:06:58 -04:00
Ermal
12b0fa564d Actually make reinstallpkg remove the bionaries and really reinstall them 2012-06-15 10:02:05 +00:00
Chris Buechler
f0e69fca01 don't show version on this page either, to match the other pages 2011-01-25 05:32:14 -05:00
Scott Ullrich
9d308f58da Do not nuke /var/db/pkg now that 2.0 has better handling 2011-01-05 16:50:08 -05:00
Scott Ullrich
d3bea81878 Add 10 to row count on textarea 2010-12-29 15:54:53 -05:00
Scott Ullrich
5edb6feecd Unbreak installedinfo option 2010-12-29 15:48:30 -05:00
Scott Ullrich
9b3ade76ca Increase textarea col size now that there is a lot more pkg install/deinstall information being output 2010-12-25 13:07:43 -05:00
Scott Ullrich
fb548cde59 No need to use escapeshellcmd here. 2010-12-14 22:47:46 -05:00
Scott Ullrich
70ed5a6af5 Use file_put_contents() 2010-12-14 15:59:39 -05:00
Scott Ullrich
d98d2db3ca Redirect to the installedinfo page after package installation giving the system a chance to refresh the menus and the final installation text 2010-12-14 15:57:41 -05:00
Ermal
4c3d9312e8 Ticket #1017. Put a @ before each fwrite to silence errors. Also setup the log file in the beginning rather than on each individual function. 2010-11-17 19:47:01 +00:00
Ermal
fcf92daec2 * Use pkg_info -E pkgname* for testing if a package is installed.
* Do not call eval if we cannot include an .inc file since that will make the whole script fail.
* Keep the log from the start to the end without overwriting. This makes debugging and problem reporting easy and explains what is done during installation.
* Check retrun value of download_with_progress_bar to make it possible catching errors during download.
* Lots of improvements in between

Related to Ticket #950
2010-11-16 19:40:20 +00:00
Ermal
2c794549af Ticket #950. Correctly handle failures while installing packages which might leave stale information behind. Also do not try to startup services twice. Rename uninstall_package_from_name to uninstall_package because the operation on packages is only done through package names. 2010-10-14 19:32:16 +00:00
Ermal
b2a6623150 Ticket #873. Call write_config() before including file to avoid loosing already done modifications. While here do some code cleanup and formating to make it more readble. 2010-09-03 22:54:14 +00:00
Renato Botelho
31c78e5dc0 Add missing ) 2010-08-12 10:54:00 -03:00
Renato Botelho
381af65980 Small gettext() fixes 2010-08-11 14:11:26 -03:00
Renato Botelho
0897ff7bd3 Implement gettext() 2010-04-29 10:37:51 -03:00
Scott Ullrich
4f6a5e6a45 Update (C) to 2010 2010-04-27 19:32:30 -04:00
Ermal Luçi
68347742f6 Close before unmounting. 2010-03-08 17:32:58 +00:00
Ermal Luçi
1570d27a49 When removing a package delete its underlying FreeBSD pacakges.
Correct checks for avioding as much as possible errors.
Simplify logic in some cases.
Remove package include files when uninstalling packages.

NOTE: Some work is needed to have more error reporting. Espescially when failing to retrieve files or add them locally.
2010-02-03 23:55:22 +00:00
Scott Ullrich
0089af7c1e Increase execution time 2010-01-21 19:20:10 -05:00
Scott Ullrich
7a927e67a5 Require filter.inc and shaper.inc 2009-11-21 19:28:00 -05:00
Scott Ullrich
1d333258dc Add pfSense_BUILDER_BINARIES: and pfSense_MODULE:. Adjust Copyright to include 2009 on files that I have asserted (C) on 2009-09-14 21:49:40 -04:00
Ermal Luçi
f69d50cead Since we could not use anchors now we need to reload the filter whenever we add/remove/reinstall a package. 2009-07-08 14:56:59 +00:00
Scott Ullrich
ba6d35216b Nuke packages for any platform 2009-06-30 22:31:37 -04:00
Scott Ullrich
e2d15485e4 Unbreak installed information screen. After package installation the form redirects to the info page that looks identical to display the final package information and to give the menus a chance to reload with the new package options. 2009-06-30 12:43:03 -04:00
Bill Marquette
f8a437b69c remove new lines 2009-03-14 18:58:19 -05:00
Scott Ullrich
16654db500 After package installation, redirect and show the installation
was OK.  This has the side effect of reloading the menus so the package
can be clicked on immediately.
2009-03-10 22:35:30 -04:00
Scott Ullrich
cfde64b8b8 * Add get_after_install_info()
* Show installation instructions for package if they exist (after_install_info)
2009-02-22 14:31:34 -05:00
Scott Ullrich
864b397664 Create a backup of the configuration prior to package installation. 2008-11-22 23:42:14 +00:00
Scott Ullrich
87294f24e4 Correctly delete package 2008-10-25 20:43:21 +00:00
Scott Ullrich
c85c6f1e72 Correctly delete package 2008-10-24 22:45:13 +00:00
Matthew Grooms
4c951cc9c9 Whitespace and minor bug fixes for package manager pages. 2008-09-10 18:41:07 +00:00
Scott Ullrich
3c43b72893 Fix error: Warning: Invalid argument supplied for foreach() in /usr/local/www/pkg_mgr_install.php on line 155 2008-08-05 16:17:59 +00:00