Commit Graph

11144 Commits

Author SHA1 Message Date
Renato Botelho
b3cbb07729 Fix some wrong escapeshellarg() calls
Conflicts:
	etc/inc/filter_log.inc
	etc/inc/pkg-utils.inc
2014-02-04 18:38:50 -02:00
Renato Botelho
af7a83737e Simplify logic calling grep less times, as done on mail_reports.inc on 2c6efc9 2014-02-04 17:07:01 -02:00
Renato Botelho
4bdb08e3b0 Use unlink_if_exists or @unlink to avoid PHP errors when file doesn't exist
Conflicts:
	usr/local/www/firewall_aliases_edit.php
2014-02-04 17:02:24 -02:00
Ermal Luçi
4b9011f5c5 Merge pull request #901 from Klaws--/patch-2
Added previously missing DSCP VA (requires kernel patch patch submitted ...
2014-02-04 10:08:40 -08:00
Renato Botelho
1eb03024fe Add escapeshellarg() calls on exec parameters. While I'm here, replace some exec() calls by php functions like symlink, copy, unlink, mkdir
Conflicts:
	usr/local/www/diag_logs_vpn.php
	usr/local/www/firewall_aliases_edit.php
	usr/local/www/guiconfig.inc
2014-02-04 12:47:20 -02:00
Renato Botelho
44f2ef9b48 Fix an obvious typo on var name 2014-02-04 12:36:54 -02:00
Klaws--
7962a55f15 Added previously missing DSCP VA (requires kernel patch patch submitted by me) 2014-02-04 14:31:21 +01:00
Renato Botelho
cf3189ffa9 Merge pull request #897 from N0YB/RELENG_2_1
XHTML Compliance - Status: System logs: Firewall
2014-02-03 03:17:42 -08:00
N0YB
472e484cd1 Update shortcuts.inc
XHTML Compliance
Shortcuts edit link - r/&id/&id
2014-01-30 22:16:57 -08:00
N0YB
30a58cf802 Couple style vertical-align corrections 2014-01-30 18:29:12 -08:00
N0YB
d284845398 Include these check boxes. 2014-01-28 16:50:31 -08:00
Phil Davis
f70adc8245 Really fix #3376
Thanks to  Grischa Zengel for spotting the semi-colon at the end of the "if" line that was the real cause. Please also back merge this to 2.1 branch.
2014-01-28 07:37:05 -02:00
N0YB
93dcedc1ec XHTML Compliance - Status: System logs: Firewall
An attribute value specification must be an attribute value literal unless SHORTTAG YES is specified
Quote (or escape) the quotes so they show up in the HTML.
Use style where attribute not supported.
Relocate tfoot to supported location and add tbody.
Apply htmlspecialchars to rule name.
Assorted tweaks.
2014-01-27 22:49:32 -08:00
N0YB
4efc1c8df6 Also make the dialog_output query string option XHTML compliant. 2014-01-27 10:59:00 -08:00
N0YB
df5501dcd3 Make select option XHTML compliant for "Number of lines to display".
http://validator.w3.org/check
"SELECTED" is not a member of a group specified for any attribute
<option value="7" SELECTED >7</option>

The name and VI delimiter can be omitted from an attribute specification only if SHORTTAG YES is specified
<option value="7" selected >7</option>

"VI delimiter" is a technical term for the equal sign. This error message means that the name of an attribute and the equal sign cannot be omitted when specifying an attribute. A common cause for this error message is the use of "Attribute Minimization" in document types where it is not allowed, in XHTML for instance.

How to fix: For attributes such as compact, checked or selected, do not write e.g <option selected ... but rather <option selected="selected" ...
2014-01-27 10:45:18 -08:00
N0YB
30469c9b0c Missing a couple table element end tags. 2014-01-26 22:53:04 -08:00
N0YB
cd6173f48c The service status icon (get_service_status_icon) is not always in a table.
So the caller should apply table td element, rather than the function.

Document type does not allow element "td" here <td class="listr" align="center">
The element named above was found in a context where it is not allowed.
2014-01-26 21:58:25 -08:00
Renato Botelho
8467c588e4 Do not list the same CARP ip as an option for Interface 2014-01-23 10:05:23 -02:00
Renato Botelho
43045948c8 Revert "Fix #3350. Do not destroy an interface when it's being disabled"
Ermal reported issues when changes are made on VLAN parent interface
with this patch. He did other changes and interface_configure() will now
be able to re-create VLAN interface

This reverts commit f70a140fe1.
2014-01-21 10:38:00 -02:00
jim-p
3d54553b87 ports ntp moved to sbin, follow 2014-01-15 12:28:06 -05:00
Chris Buechler
d2dd579401 updates to license.php 2014-01-13 02:56:04 -06:00
Chris Buechler
43656206a0 Should to go master, not RELENG_2_1. Revert "Merge pull request #882 from derelict-pf/cp-nohttpsforwards"
This reverts commit f8d1587b6e, reversing
changes made to 51922cb793.
2014-01-09 02:23:13 -06:00
Chris Buechler
f8d1587b6e Merge pull request #882 from derelict-pf/cp-nohttpsforwards
Add checkbox and logic to disable forwarding HTTPS/SSL (Port 443)
2014-01-09 00:18:49 -08:00
Phil Davis
7c2ea0cc22 Update reserved_keywords checks to match firewall_aliases_edit
firewall_aliases_import should have the same checks for reserved names as firewall_aliases_edit
This code should really be in a function in a common include file, but which one is the appropriate one?
For now I made the checks the same.
2014-01-07 07:41:04 -02:00
Phil Davis
44b72c67ec Fix display of CIDR/Update Freq in Alias Edit
Fixes #3376. I have no idea what the "^" characters were meant to do, but removing them makes the CIDR/Update Freq value be displayed correctly when editing. Will there be some other side-effect from removing the "^"?
2013-12-30 09:23:43 +00:00
phildd
d564ed2426 Validate IP address ranges correctly on Alias Bulk Import
The code was there to attempt to validate and implement IP address range lines in Alias Bulk Import e.g.
10.20.0.0-10.21.22.0
should produce a bunch of smaller ranges with appropriate CIDRs.
This fixes the code so IP address ranges actually make it through into the resulting Alias.
2013-12-30 09:23:17 +00:00
Ermal
57b02731c1 Remove not needed code 2013-12-27 20:50:01 +00:00
Ermal
53555bf2f7 Make sense of interface mtu handling code. No need to do unneeded operations. This fixes slow boot times and proper handling of mtu for vlans though some work or better model is needed for other interface types. 2013-12-27 20:37:34 +00:00
Renato Botelho
1a4ef44e5c Delete static route when monitor IP is removed, also save monitor IP even when it's disabled 2013-12-27 12:58:19 -02:00
Renato Botelho
e2edc30daa When WANTIME is empty, there is nothing to do here 2013-12-24 12:16:56 -02:00
Renato Botelho
811ecea47e test only does integer comparison, use bc to compare float 2013-12-24 12:16:48 -02:00
Renato Botelho
8f105c8a9e Save status even if no script is executed 2013-12-24 12:16:45 -02:00
Renato Botelho
9886478019 On first run REVIOUSSTATUS doesn't exist, so it cannot be UP or DOWN, invert the logic to fix this. While I'm here, check if file exists before cat it 2013-12-24 12:16:40 -02:00
Renato Botelho
56301bed30 Fix DHCP lease time display, strftime already convert it to local timezone, so we no need to calc offset 2013-12-23 17:28:08 -02:00
Renato Botelho
f2aa828754 Remove 'deny unknown clients' option from DHCPv6 since it's not supported, it fixes #3364 2013-12-23 14:40:58 -02:00
phildd
e20a0af708 Avoid dashboard divide by zero errors 2013-12-22 07:37:37 -06:00
derelict-pf
e98daec596 Add checkbox and logic to disable forwarding HTTPS/SSL (Port 443)
connections to the captive portal if HTTPS logins is enabled.
2013-12-20 17:25:02 -08:00
jim-p
c1d5f0ef4a Fix saving of voucher sync settings. 2013-12-16 15:11:09 -05:00
Renato Botelho
d8b011b8e6 Fix vpn_pppoe_get_id and stop duplicating pppoeid for multiple servers, it fixes #2286 2013-12-09 09:22:13 -02:00
Renato Botelho
3c263d4541 Merge pull request #860 from iamzam/RELENG_2_1
Allow setting a default scale type preference for the traffic graphs wid...
2013-12-07 12:49:21 -08:00
jim-p
a6d96f9b80 Also account for a widget being null/not defined, and not just closed/open. 2013-12-05 15:05:24 -05:00
dwayne voelker
8ff8325599 added missing quotes
thx rbgarga
2013-12-05 10:24:36 -05:00
dwayne voelker
943d52cf12 Allow setting a default scale type preference for the traffic graphs widget
I originally submitted this at https://redmine.pfsense.org/issues/2994
but it seems that is not used for commits now so I am adding it here.
It works great on my box, and I can't see these changes causing any
issues on other types.

I like to have Autoscale (follow) set for the traffic graphs widget and
hate having to click on Autoscale (up) to change it to follow every
time I enter the dashboard page.

This preference is written to the traffic graph widget section in
config.xml
2013-12-05 00:19:31 -05:00
Renato Botelho
21d74c8e79 Prevent network or broadcast address to be set on interface (console, GUI and wizard). It should fix #3196 2013-12-04 18:21:30 -02:00
Renato Botelho
f70a140fe1 Fix #3350. Do not destroy an interface when it's being disabled 2013-12-03 12:37:36 -02:00
Renato Botelho
4e4e35dd93 One more typo on Alternative Names fill, that was setting type field with $value 2013-11-29 10:07:32 -02:00
Renato Botelho
30c15c58a1 Fix a (probably) copy/paste issue that is making all Alternative Names disapear when an input error is detected 2013-11-29 09:57:21 -02:00
jim-p
48f1333bfd Allow an "empty" CRL to be exported, since this is still a valid action. 2013-11-25 12:40:07 -05:00
Renato Botelho
1ad6ad279f Fix an issue that changes wrong gateway entry when items are hidden 2013-11-21 09:36:50 -02:00
Renato Botelho
6b1f9a9941 Many fixes on privileges, ticket #3216:
- Remove unused privilege page-diagnostics-logs-wireless
- Remove duplicated privileges
- Fix limiter-info, pf-info and system-pftop that were using wrong name
- Add privs for services-igmpproxy-edit
- Fix ID for acptiveportal allowedhostnames and editallowedhostnames
- Fix some wrong matches
2013-11-15 19:30:31 -02:00