Commit Graph

123 Commits

Author SHA1 Message Date
Darren Embry
cd485c4fce remove some log_error calls 2012-05-17 19:02:01 -04:00
Darren Embry
283d78c632 bug fix for #2426
Input validaton on interface gateway creation box needs to reject duplicate names
2012-05-17 19:00:06 -04:00
Darren Embry
a0edece98b report errors adding a gateway through ajax calls 2012-05-17 18:33:21 -04:00
smos
2a9cb3b2a8 Fix the link local check when trying to add a link local gateway
Ticket #2071
2012-03-13 20:39:42 +01:00
smos
35af71416e Fix for ticket 2071, this allows link local addresses for gateways.
Backend already added the interface scope for link local addresses, hurrah.
2012-01-15 12:40:38 +01:00
jim-p
ec9bb09fe2 Clarify the potential pitfalls when setting the Frequency Probe and Down parameters. 2011-12-29 14:23:01 -05:00
smos
16106d2e4b Fix for redmine ticket #1993. Allow saving multiple dynamic entries.
Make sure that return_gateways_status() also returns all gateways that have monitoring disabled as up.
2011-11-27 20:09:48 +01:00
Nachtfalkeaw
a574b9607d Add default values for latency, packet loss, down on GUI 2011-08-28 06:41:20 +03:00
Seth Mos
16b03b7985 Fix a typo in the subnet generation causing the code to fail 2011-08-24 15:07:05 +02:00
Seth Mos
9e80d14cab Add address family input validation on the Gateways edit page, also prevent adding gateways on interfaces that do not carry that address family.
Fix Ticket #1633
2011-08-24 12:42:16 +02:00
jim-p
28ce79ad04 Simplify this code a bit, should be the same test in both locations since this should be either/or, and with the other code it can apparently fall into a trap where it shows neither. 2011-08-23 16:36:23 -04:00
Ermal
f720398561 Add an override for default interval to send icmp 2011-07-28 20:56:38 +00:00
Ermal
33c06ef791 Add a new option to allow disabling of gateway monitoring. This gateways will always be reported as up. 2011-07-28 20:31:57 +00:00
Vinicius Coque
d1d0a1ad1b makes correct use of printf and gettext
removes variables names and replace it with '%s'
2011-07-18 14:33:20 -03:00
Seth Mos
9498c8d728 Fix field lengths for IPv6 addresses 2011-03-17 12:52:26 +01:00
Seth Mos
2f14d0213c Make it possible to set the default gateway bit for 1 ipv4 gateway and 1 ipv6 gateway 2011-02-07 08:34:33 +01:00
Seth Mos
54ac51b569 Make the subnet check failure better readable 2011-02-03 23:08:58 +01:00
Seth Mos
1f74cd2d10 Merge remote branch 'upstream/master'
Conflicts:
	etc/inc/interfaces.inc
	etc/inc/system.inc
2011-01-18 09:10:36 +01:00
Chris Buechler
3380267983 fix text 2010-12-25 16:19:49 -05:00
Seth Mos
81afb50916 Merge remote branch 'upstream/master'
Conflicts:
	etc/inc/interfaces.inc
	etc/inc/vslb.inc
	usr/local/www/interfaces.php
2010-12-20 21:06:33 +01:00
Erik Fonnesbeck
bddcbff274 When adding/editing a gateway, check IP alias subnets, too. Fixes #1015 2010-11-22 09:23:03 -07:00
Seth Mos
172007f50c Merge remote branch 'upstream/master'
Conflicts:
	etc/inc/filter.inc
	etc/inc/system.inc
	usr/local/www/interfaces.php
	usr/local/www/interfaces_gif_edit.php
2010-11-15 12:46:58 +01:00
Scott Ullrich
225a2f0b46 Bring in XSS id fixes from m0n0wall 2010-11-12 11:03:51 -05:00
Seth Mos
7617e245bb Verify that we validate against a ipv6 subnet properly. This should help for static route gateways 2010-11-02 21:43:07 +01:00
Seth Mos
47593ac6ff Allow for configuring a IPv6 address on the interfaces page.
Add code to verify a ipv6 address
Let is_ipaddr() return true on a v4 and v6 address.
Change system gateways edit to fetch the global ipv6 interface ipv6 addresses and subnets
The current ipv6 function might need folding into filter_var() when that catches some documented corner cases.
The ajax widget on interfaces.php does not currently work for saving a IPv6 gateway address.
Gateways edit screen does not complain when using it's own IP address as the gateway. FIXME.
2010-10-22 13:32:56 +02:00
gnhb
7fa03a98aa Simplify this code so it's obvious what we're really testing for.
Should be no functional change here.
2010-10-06 00:11:38 +07:00
Ermal
c6865c5ec2 Fix intended behaviour when the default gateway changes interface. 2010-10-02 07:29:11 +00:00
Ermal
a531d6875a This breaks the code because the ASSUMPTION is to reload the gateway interface that was a defaultgw previously and not the interface that just became defaultgw. Mostly for dynamic connections like dhcp/ppp*
Pointy-hat: gnhb

Revert "Update code to actually accomplish the intended behavior of NOT reloading the interface"

This reverts commit 318baca5f6.
2010-10-02 07:14:59 +00:00
gnhb
318baca5f6 Update code to actually accomplish the intended behavior of NOT reloading the interface
if not necessary when a GW record is saved.
2010-10-02 12:27:16 +07:00
Ermal
23fafd1482 Do not allow a gateway to be renamed. Possibly a better solution is to rename the gateway in all pointed places! 2010-10-01 17:08:25 +00:00
Ermal
c568e68281 Handle the cases to not save data on config better. 2010-10-01 17:03:06 +00:00
Ermal
78ae2b1406 Make sure we do not overwrite the gateway stored in config with a dynamic gateway info. Correct POST var name(Found by ghnb). Also correctly reload only the defaultgw interface changed only if it is different than the present one. 2010-10-01 16:51:21 +00:00
Ermal
d44d26c13e Fix the problem of not saving data when most of the information is not being posted. Also do not disable any field anymore to allow people to choose static gateways for dynamic interfaces. Also do not save any information when the user Clicks save but has not posted any information not known already. Do not prevent to post a dynamic value for gateway on an interface that is configured with static ip. 2010-10-01 16:08:45 +00:00
gnhb
80a5b5f7e6 We don't store monitor ip in the <interfaces> config any more.
Requested by cbuechler in ticket #919.
2010-10-01 09:10:49 +07:00
gnhb
24d4a39050 When a dynamic interface is up, we still need to report that it's "dynamic" to this GUI in system_gateways_edit.php.
If user edits a dynamic gateway that is up, the gateway IP address (reported by return_gateways_array) will end up
in the "Gateway" field, and then the gateway will get saved as a static gateway unless user manually changes field
to "dynamic" again.
2010-10-01 07:04:52 +07:00
Ermal
11d2be5485 Revert previous change to enter a hidden value when interface is disabled. GHNB broke this on revision 58611e3a1d and it does not make sense. 2010-09-30 15:39:43 +00:00
Ermal
bc50b3321a Remove forgotten code. 2010-09-30 15:20:10 +00:00
Ermal
bb849003af Initialize variable properly. Handle the case when the interfaces select box is disabled and it will not be posted(Reported-by: ghnb 2010-09-30 15:14:32 +00:00
gnhb
58611e3a1d Fixes #919 by properly saving <gateway> field as "dynamic"
`
2010-09-23 16:57:13 +07:00
Ermal
ea939fc3a6 Oops bring back this code too. 2010-09-16 17:23:56 +00:00
Ermal
0c4846ff69 Actually this part should not have been committed at all. 2010-09-16 17:14:17 +00:00
Ermal
5657aa95e5 Fix gettext! Needed here?! 2010-09-16 17:09:29 +00:00
Ermal
99c6135271 Bring code up to speed with latest world. 2010-09-16 17:01:48 +00:00
Ermal
3befe730ff Cleanup code. 2010-09-15 18:46:46 +00:00
smos
6216690bf0 Correct my email address, adjust copyright to 2010 2010-07-24 22:10:43 +02:00
Chris Buechler
e88ace7563 fix gettext 2010-06-27 01:27:30 -04:00
Ermal
5a5447abab Correctly check when to actually save dynamic gateways or not. 2010-06-07 20:52:32 +00:00
jim-p
3dd81dea7a Ensure that monitor IP stays blank when editing a system dynamic gateway. 2010-06-02 11:26:58 -04:00
jim-p
41d984713b Default to "dynamic" for a dynamic gateway. 2010-06-02 11:13:32 -04:00
jim-p
02ca24c9d2 Add status links to gateway/route pages. 2010-06-02 09:58:31 -04:00