Commit Graph

35313 Commits

Author SHA1 Message Date
PiBa-NL
9fa31c24e6 dhcp-relay, replace the dhcprelay specific implementation of get_realinterface_for_destination() by the generic guess_interface_from_ip() 2017-06-05 18:07:49 +02:00
jim-p
de147d3d61 Add more checks to eliminate empty config tags in package settings. Fixes #7624 2017-06-05 11:24:17 -04:00
Steve Beaver
067a2bdf96 Improve comment 2017-06-01 09:15:41 -04:00
Steve Beaver
de88f4218c Use the section ID as an anchor so that hyperlinks can jump directly to that sectiom
e.g.: $section = new Form_Section("My section", "a_here");
then: https://firewall/system_somepage.php#a_here
2017-06-01 08:58:46 -04:00
Renato Botelho
63cbb6551b Fix preg_match call without delimiter and also use preg_quote() to variable used in pattern 2017-05-30 07:44:44 -03:00
Renato Botelho
7c2ca1543c Merge pull request #3740 from stilez/patch-59 2017-05-29 15:20:35 -03:00
Renato Botelho
d4d9aa66ac Merge pull request #3731 from ylecuyer/ylecuyer-patch-1 2017-05-29 15:19:56 -03:00
Renato Botelho
1ab0621507 Update translation files 2017-05-29 08:28:41 -03:00
Renato Botelho
766084d35f Regenerate pot 2017-05-29 08:25:03 -03:00
PiBa-NL
06d8454bd8 dhcp-relay, combine clean and fix code for destination interface discovery 2017-05-29 02:00:16 +02:00
stilez
8452bfc2b6 Code cleanup, and add an info message under widget list
Minor code cleanup/simplifying. Also many pages have their settings in their built-in settings panel, so the fact that the dashboard has settings elsewhere isn't obvious. Added a brief message on the widget selection panel to aid discoverability
2017-05-28 14:43:46 +01:00
stilez
ff4e29fb9d Don't create system notices for errors in user-entered ad-hoc PHP (diag_command.php) 2017-05-27 14:14:46 +01:00
stilez
1155cd6318 Various updates to PR
1) convert echo to print, and add infobox, as requested in PR comments
2) If no identifiable line number, say so
3) EVAL gives an error message format that wasn't picked up, it is now. Test case - enter as the code:  eval("X");
4) Warn that EVAL gives a "spurious" "error at line 1" as well, the real error is in the (...). See above test case for this.
5) Simplify translators' job a bit
6) Try to reduce errors in user code giving NOTICES (see PR comments). Start by defining a dir for user code (only) and putting code in it.
2017-05-27 13:49:30 +01:00
stilez
8d80a771e3 create global for user code dir, in diag_command.php
Going to try and stop user code generating notices, by putting it in a specific dir which doesn't give notices for syntax errors.
2017-05-27 13:44:06 +01:00
Renato Botelho
2c8c85787b Merge pull request #3728 from PiBa-NL/20170511-fastauth 2017-05-26 11:55:19 -03:00
Renato Botelho
8b8fb93d41 Merge pull request #3717 from phil-davis/patch-11 2017-05-26 11:54:38 -03:00
Renato Botelho
c57f66ffad Enable aws-sdk-php build 2017-05-25 13:58:12 -03:00
stilez
d2d58d6ad1 add comment 2017-05-25 05:11:37 +01:00
stilez
4711322b4a typo 2017-05-25 05:08:56 +01:00
Phil Davis
d900381c93 Add missing break for cloudflare case 2017-05-25 06:18:28 +05:45
Renato Botelho
6691686113 Enable iprange build 2017-05-24 13:43:31 -03:00
jim-p
90f3f55659 Activate bandwidthd for testing 2017-05-24 09:36:05 -04:00
stilez
fd1bd705c5 If user-entered PHP errors out, display the error line in context to help the user
If the user enters PHP in the command-line page, and it errors out, it's usually a typo or something minor. But the user is left with an error that references a /tmp file which doesn't exist at the point they read the message, a line number that's incorrect, and their input which doesn't display line numbers anyhow.

This patch fixes this, so that a user who wants to enter php command-line in the GUI and gets an error, can quickly identify the exact line causing the error. 

If an error occurs (detected by either non-zero return value or output matching an error message referencing the temp script file), then an short DIV is shown above the usual PHP output for "error location". It gives the correct error line number, and shows the code with line numbers and syntax highlighting (using php's native "-s" option), pre-scrolled to the error line.
2017-05-24 07:39:28 +01:00
Renato Botelho
7b084fd314 SG-23* serial number is igb0 mac address 2017-05-23 16:04:51 -03:00
Renato Botelho
62174481d7 Merge pull request #3739 from PiBa-NL/20170521-js-versioning 2017-05-23 13:59:58 -03:00
Renato Botelho
f8ba7256e0 Merge pull request #3737 from phil-davis/diag-dns-hide-add-alias-button 2017-05-23 13:59:20 -03:00
Renato Botelho
2470b276fe Merge pull request #3729 from znerol/bug/master/tmp-script 2017-05-23 13:57:38 -03:00
Renato Botelho
fbac0f199e Merge pull request #3715 from phil-davis/if-stats-widget-settings 2017-05-23 13:55:47 -03:00
Renato Botelho
d6b030d732 Merge pull request #3730 from PiBa-NL/20170517-sort-virtualips 2017-05-23 13:54:54 -03:00
Renato Botelho
6e0474ed68 Merge pull request #3732 from phil-davis/rule-created-updated 2017-05-23 13:54:13 -03:00
jim-p
f7a72733f8 Add download button/function directly on status.php to ease confusion. 2017-05-23 12:51:26 -04:00
Renato Botelho
977d48d2d8 Merge pull request #3733 from PiBa-NL/20170520-pkgedit-shiftemptyelement 2017-05-23 13:42:18 -03:00
Renato Botelho
d6f6e63dd6 Merge pull request #3734 from phil-davis/patch-1 2017-05-23 13:41:41 -03:00
Renato Botelho
5175d2d8aa Merge pull request #3735 from phil-davis/dns-lookup-add-alias 2017-05-23 13:40:57 -03:00
Renato Botelho
8c102a4bea Merge pull request #3736 from phil-davis/diag-dns-change-host-add-alias 2017-05-23 13:39:03 -03:00
jim-p
fcc24426ab Add NGID to status.php 2017-05-23 12:12:44 -04:00
Renato Botelho
b0572bad67 Add Bosnian to GUI since it's over 75% translated 2017-05-23 10:17:32 -03:00
Renato Botelho
7eee170ce9 Update translation files 2017-05-23 10:10:43 -03:00
Renato Botelho
cd4fd16bc7 Regenerate pot 2017-05-23 10:02:23 -03:00
jim-p
ce2d9c6ed9 Fix links to CP MAC management page so they include the zone name. Fixes #7591 2017-05-22 16:18:16 -04:00
jim-p
d80812af5d Select "No Authentication" for a portal zone by default, since it is the default behavior, but the GUI requires a value to be set. Fixes #7591 2017-05-22 16:10:08 -04:00
jim-p
bc07c19263 Fix options text/display for IPv4 DNS and Verify SSL on DynDNS clients. Fixes #7588 2017-05-22 15:53:37 -04:00
jim-p
2c1a08a8a3 Standardize privilege page and sorting between users and groups. Fixes #7587 2017-05-22 15:42:28 -04:00
jim-p
8abe827287 Add username to display when adding user privileges. Fixes #7586 2017-05-22 15:34:57 -04:00
jim-p
fc1913fef2 Provide a useful error message to the user when there is no private CA with which to create a new user certificate. Fixes #7585 2017-05-22 15:29:10 -04:00
jim-p
ec0736af25 Fix path to old pftop file in obsolete list. Fixes #7581 2017-05-22 14:48:06 -04:00
jim-p
c07a2b866b Do not offer the 'peak' and 'rate' views for pftop since they only work in interactive mode with cached data, not batch mode like the GUI uses. Fixes #7580 2017-05-22 14:43:31 -04:00
jim-p
9cf0609b8b Remove "size" option from pftop as it does nothing. The "bytes" option is the correct one to use. Fixes #7579 2017-05-22 14:38:17 -04:00
jim-p
7120ef411c In the OpenVPN wizard, if the user chooses a different auth server type, clear out stored settings so the wizard does not pre-fill bad info. Fixes #7569 2017-05-22 14:16:25 -04:00
jim-p
919a0f4a4b The logic for resolv-retry infinite was always setting it in client mode no matter what the GUI option wanted. Remove the GUI option and clean up the logic so it isn't duplicated. Fixes #7572 2017-05-22 13:35:29 -04:00