diff --git a/usr/local/www/pkg_edit.php b/usr/local/www/pkg_edit.php index cf27668004..0d7c3cd9f7 100644 --- a/usr/local/www/pkg_edit.php +++ b/usr/local/www/pkg_edit.php @@ -469,9 +469,12 @@ if ($pkg['tabs'] <> "") { } $size = ""; + $colspan=""; if (isset($pkga['dontdisplayname'])){ $input=""; - if ($pkga['combinefields'] != "begin") + // We do not want a separate tr tag pair for each field in a set of combined fields. + // The case of putting the first tr tag at the beginning of a combine-fields set is already handled above. + if (!isset($pkga['combinefields'])) $input .= ""; if(isset($pkga['usecolspan2'])) $colspan="colspan='2'"; @@ -489,7 +492,9 @@ if ($pkg['tabs'] <> "") { if (isset($pkga['required'])) $req = 'req'; $input=""; - if ($pkga['combinefields'] != "begin") { + // We do not want a separate tr tag pair for each field in a set of combined fields. + // The case of putting the first tr tag at the beginning of a combine-fields set is already handled above. + if (!isset($pkga['combinefields'])) { $input .= ""; } $input .= ""; @@ -903,13 +908,16 @@ if ($pkg['tabs'] <> "") { #check typehint value if($pkga['typehint']) echo " " . $pkga['typehint']; - $input = ""; #check combinefields options if (isset($pkga['combinefields'])){ + // At the end of each combined-fields field we just want to end a td tag. + $input = ""; + // The tr tag and... ends are only used to end the whole set of combined fields. if ($pkga['combinefields']=="end") - $input.=""; + $input.=""; } else{ + $input = ""; if($pkga['usecolspan2']) $input.= "
"; }