From eea7eb99843ee807fd9e41f5fda8ee8f6356bef2 Mon Sep 17 00:00:00 2001 From: Renato Botelho Date: Tue, 22 Jan 2013 15:00:28 -0200 Subject: [PATCH] Validate QinQ vlan interface to be sure it exists --- usr/local/www/interfaces_qinq.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/usr/local/www/interfaces_qinq.php b/usr/local/www/interfaces_qinq.php index c9eef3441a..dcb6b55473 100755 --- a/usr/local/www/interfaces_qinq.php +++ b/usr/local/www/interfaces_qinq.php @@ -59,11 +59,14 @@ function qinq_inuse($num) { } if ($_GET['act'] == "del") { + $id = $_GET['id']; + /* check if still in use */ - if (qinq_inuse($_GET['id'])) { + if (qinq_inuse($id)) { $input_errors[] = gettext("This QinQ cannot be deleted because it is still being used as an interface."); + } elseif (empty($a_qinqs[$id]['vlanif']) || !does_interface_exist($a_qinqs[$id]['vlanif'])) { + $input_errors[] = gettext("QinQ interface does not exist"); } else { - $id = $_GET['id']; $qinq =& $a_qinqs[$id]; $delmembers = explode(" ", $qinq['members']);