mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify mode parameter validation

Browse Source
This commit is contained in:
Renato Botelho 2016-06-08 14:10:50 -04:00
parent d85e29b74b
commit ddbe2c0cd9
1 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/usr/local/www/pkg_mgr_install.php
View File

@ -221,23 +221,20 @@ function waitfor_string_in_file($filename, $string, $timeout) {
}
$pkgmode = '';
if (!empty($_POST['mode'])) {
$pkgmode = $_POST['mode'];
} elseif (!empty($_GET['mode'])) {
$pkgmode = $_GET['mode'];
}
if (!empty($_REQUEST['mode'])) {
$valid_modes = array(
'reinstallall',
'reinstallpkg',
'delete',
'installed'
);
$valid_modes = array(
'',
'reinstallall',
'reinstallpkg',
'delete',
'installed'
);
if (!in_array($_REQUEST['mode'], $valid_modes)) {
header("Location: pkg_mgr_installed.php");
return;
}
if (!in_array($pkgmode, $valid_modes)) {
header("Location: pkg_mgr_installed.php");
return;
$pkgmode = $_REQUEST['mode'];
}
if ($_POST) {