From da56c4d74cf92edfee8a2a98ff07a745927692c3 Mon Sep 17 00:00:00 2001
From: Scott Ullrich <sullrich@pfsense.org>
Date: Sun, 6 Nov 2005 23:28:24 +0000
Subject: [PATCH] MFC 7413 Make FTP Its own area with header bar

---
 usr/local/www/interfaces.php     | 23 +++++++++++++++--------
 usr/local/www/interfaces_lan.php |  8 +++++++-
 usr/local/www/interfaces_opt.php |  8 +++++++-
 usr/local/www/interfaces_wan.php | 23 +++++++++++++++--------
 4 files changed, 44 insertions(+), 18 deletions(-)

diff --git a/usr/local/www/interfaces.php b/usr/local/www/interfaces.php
index 9b5b817933..34f2bcf7e0 100755
--- a/usr/local/www/interfaces.php
+++ b/usr/local/www/interfaces.php
@@ -671,6 +671,20 @@ function type_change(enable_change,enable_change_pptp) {
                   <td class="vtable">
                     <input name="bigpond_minheartbeatinterval" type="text" class="formfld" id="bigpond_minheartbeatinterval" size="8" value="<?=htmlspecialchars($pconfig['bigpond_minheartbeatinterval']);?>">seconds<br>Setting this to a sensible value (e.g. 60 seconds) can protect against DoS attacks. </td>
                 </tr>
+                <tr>
+                  <td colspan="2" valign="top" height="16"></td>
+                </tr>
+                <tr>
+                  <td colspan="2" valign="top" class="listtopic">FTP Helper</td>
+                </tr>		
+		<tr>
+			<td width="22%" valign="top" class="vncell">FTP Helper</td>
+			<td width="78%" class="vtable">
+				<input name="disableftpproxy" type="checkbox" id="disableftpproxy" value="yes" <?php if (isset($config['system']['disableftpproxy'])) echo "checked"; ?> onclick="enable_change(false)" />
+				<strong>Disable the userland FTP-Proxy application</strong>
+				<br />
+			</td>
+		</tr>
 		        <?php
 				/* Wireless interface? */
 				if (isset($wancfg['wireless']))
@@ -699,14 +713,7 @@ function type_change(enable_change,enable_change_pptp) {
                     are reserved (but not RFC 1918) or not yet assigned by IANA.<br>
                     Bogons are prefixes that should never appear in the Internet routing table, and obviously should not appear as the source address in any packets you receive.</td>
 		</tr>
-		<tr>
-			<td width="22%" valign="top" class="vncell">FTP Helper</td>
-			<td width="78%" class="vtable">
-				<input name="disableftpproxy" type="checkbox" id="disableftpproxy" value="yes" <?php if (isset($config['system']['disableftpproxy'])) echo "checked"; ?> onclick="enable_change(false)" />
-				<strong>Disable the userland FTP-Proxy application</strong>
-				<br />
-			</td>
-		</tr>		
+	
                 <tr>
                   <td width="100" valign="top">&nbsp;</td>
                   <td> &nbsp;<br> <input name="Submit" type="submit" class="formbtn" value="Save" onClick="enable_change_pptp(true)&&enable_change(true)">
diff --git a/usr/local/www/interfaces_lan.php b/usr/local/www/interfaces_lan.php
index 1133335b7e..27321bacd5 100755
--- a/usr/local/www/interfaces_lan.php
+++ b/usr/local/www/interfaces_lan.php
@@ -242,6 +242,12 @@ function enable_change(enable_over) {
 			<br> The bandwidth setting will define the speed of the interface for traffic shaping.  Do not enter your "Internet" bandwidth here, only the physical speed!
 		  </td>
                 </tr>
+                <tr>
+                  <td colspan="2" valign="top" height="16"></td>
+                </tr>
+                <tr>
+                  <td colspan="2" valign="top" class="listtopic">FTP Helper</td>
+                </tr>		
 		<tr>
 			<td width="22%" valign="top" class="vncell">FTP Helper</td>
 			<td width="78%" class="vtable">
@@ -249,7 +255,7 @@ function enable_change(enable_over) {
 				<strong>Disable the userland FTP-Proxy application</strong>
 				<br />
 			</td>
-		</tr>		
+		</tr>	
                 <tr>
                   <td width="22%" valign="top">&nbsp;</td>
                   <td width="78%">
diff --git a/usr/local/www/interfaces_opt.php b/usr/local/www/interfaces_opt.php
index 3add7d3b5e..2542e570d3 100755
--- a/usr/local/www/interfaces_opt.php
+++ b/usr/local/www/interfaces_opt.php
@@ -424,6 +424,12 @@ function type_change(enable_change,enable_change_pptp) {
 			<br> The bandwidth setting will define the speed of the interface for traffic shaping.  Do not enter your "Internet" bandwidth here, only the physical speed!
 		  </td>
                 </tr>
+                <tr>
+                  <td colspan="2" valign="top" height="16"></td>
+                </tr>
+                <tr>
+                  <td colspan="2" valign="top" class="listtopic">FTP Helper</td>
+                </tr>		
 		<tr>
 			<td width="22%" valign="top" class="vncell">FTP Helper</td>
 			<td width="78%" class="vtable">
@@ -431,7 +437,7 @@ function type_change(enable_change,enable_change_pptp) {
 				<strong>Disable the userland FTP-Proxy application</strong>
 				<br />
 			</td>
-		</tr>		
+		</tr>	
 		<tr>
                   <td width="22%" valign="top">&nbsp;</td>
                   <td width="78%">
diff --git a/usr/local/www/interfaces_wan.php b/usr/local/www/interfaces_wan.php
index 9b5b817933..34f2bcf7e0 100755
--- a/usr/local/www/interfaces_wan.php
+++ b/usr/local/www/interfaces_wan.php
@@ -671,6 +671,20 @@ function type_change(enable_change,enable_change_pptp) {
                   <td class="vtable">
                     <input name="bigpond_minheartbeatinterval" type="text" class="formfld" id="bigpond_minheartbeatinterval" size="8" value="<?=htmlspecialchars($pconfig['bigpond_minheartbeatinterval']);?>">seconds<br>Setting this to a sensible value (e.g. 60 seconds) can protect against DoS attacks. </td>
                 </tr>
+                <tr>
+                  <td colspan="2" valign="top" height="16"></td>
+                </tr>
+                <tr>
+                  <td colspan="2" valign="top" class="listtopic">FTP Helper</td>
+                </tr>		
+		<tr>
+			<td width="22%" valign="top" class="vncell">FTP Helper</td>
+			<td width="78%" class="vtable">
+				<input name="disableftpproxy" type="checkbox" id="disableftpproxy" value="yes" <?php if (isset($config['system']['disableftpproxy'])) echo "checked"; ?> onclick="enable_change(false)" />
+				<strong>Disable the userland FTP-Proxy application</strong>
+				<br />
+			</td>
+		</tr>
 		        <?php
 				/* Wireless interface? */
 				if (isset($wancfg['wireless']))
@@ -699,14 +713,7 @@ function type_change(enable_change,enable_change_pptp) {
                     are reserved (but not RFC 1918) or not yet assigned by IANA.<br>
                     Bogons are prefixes that should never appear in the Internet routing table, and obviously should not appear as the source address in any packets you receive.</td>
 		</tr>
-		<tr>
-			<td width="22%" valign="top" class="vncell">FTP Helper</td>
-			<td width="78%" class="vtable">
-				<input name="disableftpproxy" type="checkbox" id="disableftpproxy" value="yes" <?php if (isset($config['system']['disableftpproxy'])) echo "checked"; ?> onclick="enable_change(false)" />
-				<strong>Disable the userland FTP-Proxy application</strong>
-				<br />
-			</td>
-		</tr>		
+	
                 <tr>
                   <td width="100" valign="top">&nbsp;</td>
                   <td> &nbsp;<br> <input name="Submit" type="submit" class="formbtn" value="Save" onClick="enable_change_pptp(true)&&enable_change(true)">