From d9797fd60a09140555bcbd26bbb08bc5b1308dee Mon Sep 17 00:00:00 2001 From: Renato Botelho Date: Tue, 21 Jan 2014 10:36:57 -0200 Subject: [PATCH] Revert "Fix #3350. Do not destroy an interface when it's being disabled" Ermal reported issues when changes are made on VLAN parent interface with this patch. He did other changes and interface_configure() will now be able to re-create VLAN interface This reverts commit 5bc623536d8bb3b93e68a1b1535c9de582721a09. --- usr/local/www/interfaces.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/usr/local/www/interfaces.php b/usr/local/www/interfaces.php index d19d2acffc..bfea79db76 100755 --- a/usr/local/www/interfaces.php +++ b/usr/local/www/interfaces.php @@ -413,9 +413,11 @@ if ($_POST['apply']) { if (file_exists("{$g['tmp_path']}/.interfaces.apply")) { $toapplylist = unserialize(file_get_contents("{$g['tmp_path']}/.interfaces.apply")); foreach ($toapplylist as $ifapply => $ifcfgo) { - interface_bring_down($ifapply, false, $ifcfgo); - if (isset($config['interfaces'][$ifapply]['enable'])) + if (isset($config['interfaces'][$ifapply]['enable'])) { + interface_bring_down($ifapply, false, $ifcfgo); interface_configure($ifapply, true); + } else + interface_bring_down($ifapply, true, $ifcfgo); } } /* restart snmp so that it binds to correct address */