diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc index 784b37ba78..97a4cc202b 100644 --- a/etc/inc/filter.inc +++ b/etc/inc/filter.inc @@ -1064,6 +1064,14 @@ function filter_nat_rules_generate() { $natrules .= "# TFTP proxy\n"; $natrules .= "rdr-anchor \"tftp-proxy/*\"\n"; + if (!empty($config['system']['tftpinterface'])) { + $tftpifs = explode(",", $config['system']['tftpinterface']); + foreach($tftpifs as $tftpif) { + if ($FilterIflist[$tftpif]) + $natrules .= "rdr pass on {$FilterIflist[$tftpif]['if']} proto udp from any to any port tftp -> 127.0.0.1 port 6969\n"; + } + } + $interface_counter = 0; $vpns_list = filter_get_vpns_list(); $direct_networks_list = filter_get_direct_networks_list(); @@ -1085,7 +1093,7 @@ function filter_nat_rules_generate() { // Open inetd.conf write handle $inetd_fd = fopen("/var/etc/inetd.conf","w"); /* add tftp protocol helper */ - fwrite($inetd_fd, "tftp\tdgram\tudp\twait\t\troot\t/usr/local/sbin/tftp-proxy\ttftp-proxy -v\n"); + fwrite($inetd_fd, "tftp-proxy\tdgram\tudp\twait\t\troot\t/usr/local/sbin/tftp-proxy\ttftp-proxy -v\n"); if(isset($config['nat']['rule'])) { if(!isset($config['system']['disablenatreflection'])) { @@ -2008,8 +2016,7 @@ EOD; # package manager late specific hook anchor "packagelate" -EOD; - $ipfrules .= <<ssl = 0; $smtp->debug = 0; $smtp->html_debug = 0; + $smtp->localhost=$config['system']['hostname'].".".$config['system']['domain']; if($config['notifications']['smtp']['fromaddress']) $from = $config['notifications']['smtp']['fromaddress']; @@ -345,9 +346,12 @@ function notify_via_growl($message) { global $config; $growl_ip = $config['notifications']['growl']['ipaddress']; $growl_password = $config['notifications']['growl']['password']; + $growl_name = $config['notifications']['growl']['name']; + $growl_notification = $config['notifications']['growl']['notification_name']; + if(!empty($growl_ip)) { - $growl = new Growl($growl_ip, $growl_password); - $growl->notify("pfSense growl alert", "pfSense", "{$message}"); + $growl = new Growl($growl_ip, $growl_password, $growl_name); + $growl->notify("{$growl_notification}", "pfSense", "{$message}"); } } @@ -364,8 +368,12 @@ function register_via_growl() { global $config; $growl_ip = $config['notifications']['growl']['ipaddress']; $growl_password = $config['notifications']['growl']['password']; + $growl_name = $config['notifications']['growl']['name']; + $growl_notification = $config['notifications']['growl']['notification_name']; + if($growl_ip) { - $growl = new Growl($growl_ip, $growl_password); + $growl = new Growl($growl_ip, $growl_password, $growl_name); + $growl->addNotification($growl_notification); $growl->register(); } } diff --git a/usr/local/www/fbegin.inc b/usr/local/www/fbegin.inc index 3f69cd6257..29b94642c9 100755 --- a/usr/local/www/fbegin.inc +++ b/usr/local/www/fbegin.inc @@ -105,12 +105,11 @@ $interfaces_menu = msort(array_merge($interfaces_menu, return_ext_menu("Interfac // Firewall $firewall_menu = array(); $firewall_menu[] = array("Aliases", "/firewall_aliases.php"); -if($config['interfaces']['lan']) +if(count($config['interfaces']) > 1) $firewall_menu[] = array("NAT", "/firewall_nat.php"); $firewall_menu[] = array("Rules", "/firewall_rules.php"); $firewall_menu[] = array("Schedules", "/firewall_schedule.php"); -if($config['interfaces']['lan']) - $firewall_menu[] = array("Traffic Shaper", "/firewall_shaper.php"); +$firewall_menu[] = array("Traffic Shaper", "/firewall_shaper.php"); $firewall_menu[] = array("Virtual IPs", "/firewall_virtual_ip.php"); $firewall_menu = msort(array_merge($firewall_menu, return_ext_menu("Firewall")),0); @@ -128,7 +127,7 @@ $services_menu[] = array("OLSR", "/pkg_edit.php?xml=olsrd.xml&id=0"); $services_menu[] = array("PPPoE Server", "/vpn_pppoe.php"); $services_menu[] = array("RIP", "/pkg_edit.php?xml=routed/routed.xml&id=0"); $services_menu[] = array("SNMP", "/services_snmp.php"); -if($config['interfaces']['lan']) { +if(count($config['interfaces']) > 1) { /* no use for UPnP in single-interface deployments remove to reduce user confusion */ @@ -166,7 +165,7 @@ $status_menu[] = array("RRD Graphs", "/status_rrd_graph.php"); $status_menu[] = array("Services", "/status_services.php"); $status_menu[] = array("System Logs", "/diag_logs.php"); $status_menu[] = array("Traffic Graph", "/status_graph.php?if=wan"); -if($config['interfaces']['lan']) +if(count($config['interfaces']) > 1) $status_menu[] = array("UPnP", "/status_upnp.php"); $ifentries = get_configured_interface_with_descr(); foreach ($ifentries as $ent => $entdesc) { diff --git a/usr/local/www/interfaces_gif_edit.php b/usr/local/www/interfaces_gif_edit.php index ba7f7aa999..908277f8cc 100644 --- a/usr/local/www/interfaces_gif_edit.php +++ b/usr/local/www/interfaces_gif_edit.php @@ -75,7 +75,7 @@ if ($_POST) { if ((!is_ipaddr($_POST['tunnel-local-addr'])) || (!is_ipaddr($_POST['tunnel-remote-addr'])) || (!is_ipaddr($_POST['remote-addr']))) { - $input_errors[] = "All fildes must have valid ip addresses."; + $input_errors[] = "The tunnel local and tunnel remote fields must have valid IP addresses."; } foreach ($a_gifs as $gif) { diff --git a/usr/local/www/interfaces_gre_edit.php b/usr/local/www/interfaces_gre_edit.php index 5fee315a1a..1144bcd7a0 100644 --- a/usr/local/www/interfaces_gre_edit.php +++ b/usr/local/www/interfaces_gre_edit.php @@ -76,7 +76,7 @@ if ($_POST) { if ((!is_ipaddr($_POST['tunnel-local-addr'])) || (!is_ipaddr($_POST['tunnel-remote-addr'])) || (!is_ipaddr($_POST['remote-addr']))) { - $input_errors[] = "All fildes must have valid ip addresses."; + $input_errors[] = "The tunnel local and tunnel remote fields must have valid IP addresses."; } foreach ($a_gres as $gre) { diff --git a/usr/local/www/javascript/sorttable.js b/usr/local/www/javascript/sorttable.js index b7950f1420..c8c72be838 100644 --- a/usr/local/www/javascript/sorttable.js +++ b/usr/local/www/javascript/sorttable.js @@ -363,18 +363,6 @@ if (document.addEventListener) { document.addEventListener("DOMContentLoaded", sorttable.init, false); } -/* for Internet Explorer */ -/*@cc_on @*/ -/*@if (@_win32) - document.write("