From cedc8184606a4cfdf6cb7542e43d205205005865 Mon Sep 17 00:00:00 2001 From: kristoffer-ekenstam <54392779+kristoffer-ekenstam@users.noreply.github.com> Date: Thu, 22 Aug 2019 10:12:10 +0200 Subject: [PATCH] Fixed #8014 Fixed wildcard variable not being set correctly. Updated CURLOPT_URL according to provider's documentation. Added support for MX records. --- src/etc/inc/dyndns.class | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/etc/inc/dyndns.class b/src/etc/inc/dyndns.class index d1ba329657..5e2da57918 100644 --- a/src/etc/inc/dyndns.class +++ b/src/etc/inc/dyndns.class @@ -95,7 +95,7 @@ * ODS - Last Tested: 02 August 2005 * FreeDNS - Last Tested: 01 May 2016 * FreeDNS IPv6 - Last Tested: 01 May 2016 - * Loopia - Last Tested: NEVER + * Loopia - Last Tested: 21 August 2019 * StaticCling - Last Tested: 27 April 2006 * DNSexit - Last Tested: 20 July 2008 * OpenDNS - Last Tested: 4 August 2008 @@ -633,9 +633,13 @@ break; case 'loopia': $needsIP = TRUE; - if (isset($this->_dnsWildcard) && $this->_dnsWildcard != "OFF") $this->_dnsWildcard = "ON"; - curl_setopt($ch, CURLOPT_USERPWD, $this->_dnsUser.':'.$this->_dnsPass); - curl_setopt($ch, CURLOPT_URL, 'https://dns.loopia.se/XDynDNSServer/XDynDNS.php?hostname='.$this->_dnsHost.'&myip='.$this->_dnsIP.'&wildcard='.$this->_dnsWildcard); + if(isset($this->_dnsWildcard) && $this->_dnsWildcard == TRUE) { + $this->_dnsWildcard = "ON"; + } else { + $this->_dnsWildcard = "OFF"; + } + curl_setopt($ch, CURLOPT_USERPWD, "{$this->_dnsUser}:{$this->_dnsPass}"); + curl_setopt($ch, CURLOPT_URL, "https://dyndns.loopia.se/?system=custom&hostname={$this->_dnsHost}&myip={$this->_dnsIP}&wildcard={$this->_dnsWildcard}&mx={$this->_dnsMX}&backmx=NO"); break; case 'opendns': $needsIP = FALSE;