mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add input validation so users do not add gateways to local dns servers

Browse Source
This commit is contained in:
Seth Mos 2008-11-11 23:04:22 +00:00
parent 5aaf13c437
commit c98d28e12e
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
usr/local/www/system.php
View File

@ -121,6 +121,21 @@ if ($_POST) {
$input_errors[] = "A valid TCP/IP port must be specified for the webConfigurator port.";
}
$direct_networks_list = explode(" ", get_direct_networks_list());
for ($dnscounter=1; $dnscounter<5; $dnscounter++) {
$dnsitem = "dns{$dnscounter}";
$dnsgwitem = "dns{$dnscounter}gwint";
if ($_POST[$dnsgwitem]) {
if(interface_has_gateway($_POST[$dnsgwitem])) {
foreach($direct_networks_list as $direct_network) {
if(ip_in_subnet($_POST[$dnsitem], $direct_network)) {
$input_errors[] = "You can not assign a gateway to DNS '{$_POST[$dnsitem]}' server which is on a directly connected network.";
}
}
}
}
}
$t = (int)$_POST['timeupdateinterval'];
if (($t < 0) || (($t > 0) && ($t < 6)) || ($t > 1440)) {
$input_errors[] = "The time update interval must be either 0 (disabled) or between 6 and 1440.";