From aba2f06d3a16fa5bee0153992a7cc00d69f60a52 Mon Sep 17 00:00:00 2001
From: Erik Fonnesbeck <efonnes@gmail.com>
Date: Sat, 8 May 2010 18:17:09 -0600
Subject: [PATCH] Do not install reflection rules for port forwards when the
 destination is invalid.

---
 etc/inc/filter.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc
index 0da950e27c..eac5877d2e 100644
--- a/etc/inc/filter.inc
+++ b/etc/inc/filter.inc
@@ -869,6 +869,8 @@ function filter_generate_reflection($rule, $nordr, $rdr_ifs, $srcaddr, $dstaddr_
 		else
 			$rflctintrange = "";
 		$dstaddr = $dstaddr[0];
+		if(empty($dstaddr) || strtolower(trim($dstaddr)) == "port")
+			return "";
 
 		if(isset($rule['destination']['any'])) {
 			if(!$rule['interface'])