mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

MFC 8805

Browse Source 
Fix protocol checking so that existing input validation works use endport as startport if specified w/out startport
This commit is contained in:
Scott Ullrich 2005-12-29 20:55:21 +00:00
parent fd6135414d
commit aa3400b8fb
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
usr/local/www/firewall_nat_edit.php
View File

@ -75,14 +75,17 @@ if ($_POST) {
if (!$_POST['endport'])
$_POST['endport'] = $_POST['beginport'];
/* Make beginning port end port if not defined and endport is */
if (!$_POST['beginport'] && $_POST['endport'])
$_POST['beginport'] = $_POST['endport'];
unset($input_errors);
$pconfig = $_POST;
/* input validation */
if($_POST['proto'] == "TCP" or $_POST['proto'] == "UDP" or $_POST['proto'] == "TCP/UDP") {
if(strtoupper($_POST['proto']) == "TCP" or strtoupper($_POST['proto']) == "UDP" or strtoupper($_POST['proto']) == "TCP/UDP") {
$reqdfields = explode(" ", "interface proto beginport localip localbeginport");
$reqdfieldsn = explode(",", "Interface,Protocol,Start port,NAT IP,Local port");
$reqdfieldsn = explode(",", "Interface,Protocol,Ext. start port,NAT IP,Local port");
} else {
$reqdfields = explode(" ", "interface proto localip");
$reqdfieldsn = explode(",", "Interface,Protocol,NAT IP");
@ -95,7 +98,7 @@ if ($_POST) {
}
/* only validate the ports if the protocol is TCP, UDP or TCP/UDP */
if($_POST['proto'] == "TCP" or $_POST['proto'] == "UDP" or $_POST['proto'] == "TCP/UDP") {
if(strtoupper($_POST['proto']) == "TCP" or strtoupper($_POST['proto']) == "UDP" or strtoupper($_POST['proto']) == "TCP/UDP") {
if (($_POST['beginport'] && !is_ipaddroralias($_POST['beginport']) && !is_port($_POST['beginport']))) {
$input_errors[] = "The start port must be an integer between 1 and 65535.";